Do not refresh overview twice on a change

wonder-sk · wonder-sk · commit 48c1b57664ea · 2014-02-25T16:59:42.000+07:00
diff --git a/src/app/legend/qgslegend.cpp b/src/app/legend/qgslegend.cpp
@@ -2445,11 +2445,6 @@ void QgsLegend::updateMapCanvasLayerSet()
   mMapCanvas->setLayerSet( layers );
 }
 
-void QgsLegend::updateOverview()
-{
-  mMapCanvas->updateOverview();
-}
-
 void QgsLegend::enableOverviewModeAllLayers( bool isInOverview )
 {
   for ( QTreeWidgetItem* theItem = firstItem(); theItem; theItem = nextItem( theItem ) )
@@ -2462,7 +2457,6 @@ void QgsLegend::enableOverviewModeAllLayers( bool isInOverview )
 
   }
   updateMapCanvasLayerSet();
-  updateOverview();
 }
 
 QStringList QgsLegend::layerIDs()
diff --git a/src/app/legend/qgslegend.h b/src/app/legend/qgslegend.h
@@ -206,9 +206,6 @@ class QgsLegend : public QTreeWidget
     /**Updates layer set of map canvas*/
     void updateMapCanvasLayerSet();
 
-    /**Updates overview*/
-    void updateOverview();
-
     /**Show/remove all layer in/from overview*/
     void enableOverviewModeAllLayers( bool isInOverview );
 
diff --git a/src/app/legend/qgslegendlayer.cpp b/src/app/legend/qgslegendlayer.cpp
@@ -494,7 +494,6 @@ void QgsLegendLayer::showInOverview()
   setInOverview( ! isInOverview() );
 
   legend()->updateMapCanvasLayerSet();
-  legend()->updateOverview();
 }
 
 QString QgsLegendLayer::nameFromLayer( QgsMapLayer* layer )

Original file line number	Diff line number	Diff line change
`@@ -2445,11 +2445,6 @@ void QgsLegend::updateMapCanvasLayerSet()`
`2445`	`2445`	`mMapCanvas->setLayerSet( layers );`
`2446`	`2446`	`}`
`2447`	`2447`
`2448`		`-void QgsLegend::updateOverview()`
`2449`		`-{`
`2450`		`- mMapCanvas->updateOverview();`
`2451`		`-}`
`2452`		`-`
`2453`	`2448`	`void QgsLegend::enableOverviewModeAllLayers( bool isInOverview )`
`2454`	`2449`	`{`
`2455`	`2450`	`for ( QTreeWidgetItem* theItem = firstItem(); theItem; theItem = nextItem( theItem ) )`
`@@ -2462,7 +2457,6 @@ void QgsLegend::enableOverviewModeAllLayers( bool isInOverview )`
`2462`	`2457`
`2463`	`2458`	`}`
`2464`	`2459`	`updateMapCanvasLayerSet();`
`2465`		`- updateOverview();`
`2466`	`2460`	`}`
`2467`	`2461`
`2468`	`2462`	`QStringList QgsLegend::layerIDs()`
Original file line number	Diff line number	Diff line change
`@@ -494,7 +494,6 @@ void QgsLegendLayer::showInOverview()`
`494`	`494`	`setInOverview( ! isInOverview() );`
`495`	`495`
`496`	`496`	`legend()->updateMapCanvasLayerSet();`
`497`		`- legend()->updateOverview();`
`498`	`497`	`}`
`499`	`498`
`500`	`499`	`QString QgsLegendLayer::nameFromLayer( QgsMapLayer* layer )`