Skip to content

Commit

Permalink
Fix double clear actions sometimes show in spin boxes
Browse files Browse the repository at this point in the history
Fixes #19178
  • Loading branch information
nyalldawson committed Jun 13, 2018
1 parent dab4437 commit 494f7bc
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/gui/qgsfilterlineedit.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,12 @@ void QgsFilterLineEdit::updateClearIcon()
}
else if ( !showClear && mClearAction )
{
// pretty freakin weird... seems the deleteLater call on the mClearAction
// isn't sufficient to actually remove the action from the line edit, and
// a kind of "ghost" action gets left behind... resulting in duplicate
// clear actions appearing if later we re-create the action.
// in summary: don't remove this "removeAction" call!
removeAction( mClearAction );
mClearAction->deleteLater();
mClearAction = nullptr;
}
Expand Down

0 comments on commit 494f7bc

Please sign in to comment.