Move licensecheck to external folder

Author: nyalldawson

tests/code_layout/licensecheck.pl external/licensecheck/licensecheck.pl

@@ -3,14 +3,14 @@
 # This test checks that all source files correctly have license headers
 
 INCLUDE_EXTENSIONS="h|cpp|hpp|py|c"
-EXCLUDE_LIST="(.*\/(qtermwidget)\/|ui_defaults\\.h|CREDITS|TODO|README|URI|^[^.]*$|.*\\.(?!($INCLUDE_EXTENSIONS)$))"
+EXCLUDE_LIST="(.*\\/(qtermwidget)\\/|ui_defaults\\.h|CREDITS|TODO|README|URI|^[^.]*$|.*\\.(?!($INCLUDE_EXTENSIONS)$))"
 
 DIR=$(git rev-parse --show-toplevel)
 
-pushd ${DIR} > /dev/null
-missing=$(! { tests/code_layout/licensecheck.pl -r -i "$EXCLUDE_LIST" src & licensecheck -r -i "$EXCLUDE_LIST" python; } | grep UNKNOWN)
+pushd "${DIR}" || exit > /dev/null
+missing=$(! { external/licensecheck/licensecheck.pl -r -i "$EXCLUDE_LIST" src & licensecheck -r -i "$EXCLUDE_LIST" python; } | grep UNKNOWN)
 
-popd > /dev/null
+popd || exit > /dev/null
 
 if [[ $missing ]]; then
   echo " *** Found source files without valid license headers"