Skip to content

Commit 4bc60ff

Browse files
committed
Removed unused QgsFeature::isDirty() and QgsFeature::clean()
1 parent eb6d4d3 commit 4bc60ff

File tree

3 files changed

+0
-42
lines changed

3 files changed

+0
-42
lines changed

python/core/qgsfeature.sip

-12
Original file line numberDiff line numberDiff line change
@@ -147,18 +147,6 @@ class QgsFeature
147147
*/
148148
void setValid( bool validity );
149149

150-
/**
151-
* Return the dirty state of this feature.
152-
* Dirty is set if (e.g.) the feature's geometry has been modified in-memory.
153-
*/
154-
bool isDirty() const;
155-
156-
/**
157-
* Reset the dirtiness of the feature. (i.e. make clean)
158-
* You would normally do this after it's saved to permanent storage (e.g. disk, an ACID-compliant database)
159-
*/
160-
void clean();
161-
162150
/**
163151
* Get the geometry object associated with this feature
164152
*/

src/core/qgsfeature.cpp

-14
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ QgsFeature::QgsFeature( QgsFeatureId id )
2727
, mGeometry( 0 )
2828
, mOwnsGeometry( 0 )
2929
, mValid( false )
30-
, mDirty( 0 )
3130
, mFields( 0 )
3231
{
3332
// NOOP
@@ -39,7 +38,6 @@ QgsFeature::QgsFeature( QgsFeature const & rhs )
3938
, mGeometry( 0 )
4039
, mOwnsGeometry( false )
4140
, mValid( rhs.mValid )
42-
, mDirty( rhs.mDirty )
4341
, mFields( rhs.mFields )
4442
{
4543

@@ -57,7 +55,6 @@ QgsFeature & QgsFeature::operator=( QgsFeature const & rhs )
5755
return *this;
5856

5957
mFid = rhs.mFid;
60-
mDirty = rhs.mDirty;
6158
mAttributes = rhs.mAttributes;
6259
mValid = rhs.mValid;
6360
mFields = rhs.mFields;
@@ -195,17 +192,6 @@ void QgsFeature::setValid( bool validity )
195192
mValid = validity;
196193
}
197194

198-
bool QgsFeature::isDirty() const
199-
{
200-
return mDirty;
201-
}
202-
203-
void QgsFeature::clean()
204-
{
205-
mDirty = false;
206-
}
207-
208-
209195
bool QgsFeature::addAttribute( const QString& name, QVariant value )
210196
{
211197
int fieldIdx = fieldNameIndex( name );

src/core/qgsfeature.h

-16
Original file line numberDiff line numberDiff line change
@@ -169,18 +169,6 @@ class CORE_EXPORT QgsFeature
169169
*/
170170
void setValid( bool validity );
171171

172-
/**
173-
* Return the dirty state of this feature.
174-
* Dirty is set if (e.g.) the feature's geometry has been modified in-memory.
175-
*/
176-
bool isDirty() const;
177-
178-
/**
179-
* Reset the dirtiness of the feature. (i.e. make clean)
180-
* You would normally do this after it's saved to permanent storage (e.g. disk, an ACID-compliant database)
181-
*/
182-
void clean();
183-
184172
/**
185173
* Get the geometry object associated with this feature
186174
*/
@@ -271,10 +259,6 @@ class CORE_EXPORT QgsFeature
271259
// TODO: still applies? [MD]
272260
bool mValid;
273261

274-
//! Flag to indicate if this feature is dirty (e.g. geometry has been modified in-memory)
275-
// TODO: still applies? [MD]
276-
bool mDirty;
277-
278262
//! Optional field map for name-based attribute lookups
279263
const QgsFieldMap* mFields;
280264

0 commit comments

Comments
 (0)