fieldEditable -> readOnly

m-kuhn · m-kuhn · commit 4cd1e38631ae · 2015-11-19T15:32:28.000+01:00
diff --git a/python/core/qgseditformconfig.sip b/python/core/qgseditformconfig.sip
@@ -190,17 +190,17 @@ class QgsEditFormConfig : QObject
     QgsEditorWidgetConfig widgetConfig( const QString& fieldName ) const;
 
     /**
-     * If this returns false, the widget at the given index will always be read-only.
+     * If this returns true, the field is manually set to read only.
      */
-    bool fieldEditable( int idx );
+    bool readOnly( int idx );
 
     /**
      * If set to false, the widget at the given index will be read-only, regardless of the
      * layer's editable state and data provider capacities.
      * If it is set to true, the widget's editable state will be synchronized with the layer's
      * edit state.
      */
-    void setFieldEditable( int idx, bool editable );
+    void setReadOnly(int idx, bool readOnly );
 
     /**
      * If this returns true, the widget at the given index will receive its label on the previous line
diff --git a/python/core/qgsvectorlayer.sip b/python/core/qgsvectorlayer.sip
@@ -1006,7 +1006,7 @@ class QgsVectorLayer : QgsMapLayer
     /** Make layer read-only (editing disabled) or not
      *  @return false if the layer is in editing yet
      */
-    bool setReadOnly( bool readonly = true );
+    bool setFieldEditable( bool editable = true );
 
     /**
      * Make layer editable.
diff --git a/src/app/qgsfieldsproperties.cpp b/src/app/qgsfieldsproperties.cpp
@@ -848,7 +848,7 @@ void QgsFieldsProperties::apply()
     int idx = mFieldsList->item( i, attrIdCol )->text().toInt();
     FieldConfig cfg = configForRow( i );
 
-    mLayer->editFormConfig()->setFieldEditable( i, cfg.mEditable );
+    mLayer->editFormConfig()->setReadOnly( i, !cfg.mEditable );
     mLayer->editFormConfig()->setLabelOnTop( i, cfg.mLabelOnTop );
 
     mLayer->editFormConfig()->setWidgetType( idx, cfg.mEditorWidgetV2Type );
@@ -900,7 +900,7 @@ QgsFieldsProperties::FieldConfig::FieldConfig()
 QgsFieldsProperties::FieldConfig::FieldConfig( QgsVectorLayer* layer, int idx )
     : mButton( 0 )
 {
-  mEditable = layer->editFormConfig()->fieldEditable( idx );
+  mEditable = !layer->editFormConfig()->readOnly( idx );
   mEditableEnabled = layer->fields().fieldOrigin( idx ) != QgsFields::OriginJoin
                      && layer->fields().fieldOrigin( idx ) != QgsFields::OriginExpression;
   mLabelOnTop = layer->editFormConfig()->labelOnTop( idx );
diff --git a/src/core/qgseditformconfig.cpp b/src/core/qgseditformconfig.cpp
@@ -4,8 +4,8 @@
 QgsEditFormConfig::QgsEditFormConfig( QObject* parent )
     : QObject( parent )
     , mEditorLayout( GeneratedLayout )
-    , mUseInitCode( false )
     , mFeatureFormSuppress( SuppressDefault )
+    , mUseInitCode( false )
 {
   connect( QgsProject::instance()->relationManager(), SIGNAL( relationsLoaded() ), this, SLOT( onRelationsLoaded() ) );
 }
@@ -72,17 +72,17 @@ void QgsEditFormConfig::setUiForm( const QString& ui )
   mEditForm = ui;
 }
 
-bool QgsEditFormConfig::fieldEditable( int idx )
+bool QgsEditFormConfig::readOnly( int idx )
 {
   if ( idx >= 0 && idx < mFields.count() )
   {
     if ( mFields.fieldOrigin( idx ) == QgsFields::OriginJoin
          || mFields.fieldOrigin( idx ) == QgsFields::OriginExpression )
-      return false;
-    return mFieldEditables.value( mFields.at( idx ).name(), true );
+      return true;
+    return !mFieldEditables.value( mFields.at( idx ).name(), true );
   }
   else
-    return true;
+    return false;
 }
 
 bool QgsEditFormConfig::labelOnTop( int idx )
@@ -93,10 +93,10 @@ bool QgsEditFormConfig::labelOnTop( int idx )
     return false;
 }
 
-void QgsEditFormConfig::setFieldEditable( int idx, bool editable )
+void QgsEditFormConfig::setReadOnly( int idx, bool readOnly )
 {
   if ( idx >= 0 && idx < mFields.count() )
-    mFieldEditables[ mFields.at( idx ).name()] = editable;
+    mFieldEditables[ mFields.at( idx ).name()] = !readOnly;
 }
 
 void QgsEditFormConfig::setLabelOnTop( int idx, bool onTop )
diff --git a/src/core/qgseditformconfig.h b/src/core/qgseditformconfig.h
@@ -441,17 +441,15 @@ class CORE_EXPORT QgsEditFormConfig : public QObject
     QgsEditorWidgetConfig widgetConfig( const QString& fieldName ) const;
 
     /**
-     * If this returns false, the widget at the given index will always be read-only.
+     * This returns true if the field is manually set to read only or if the field
+     * does not support editing like joins or vitual fields.
      */
-    bool fieldEditable( int idx );
+    bool readOnly( int idx );
 
     /**
-     * If set to false, the widget at the given index will be read-only, regardless of the
-     * layer's editable state and data provider capacities.
-     * If it is set to true, the widget's editable state will be synchronized with the layer's
-     * edit state.
+     * If set to false, the widget at the given index will be read-only.
      */
-    void setFieldEditable( int idx, bool editable );
+    void setReadOnly( int idx, bool readOnly = true );
 
     /**
      * If this returns true, the widget at the given index will receive its label on the previous line
diff --git a/src/core/qgsvectorlayer.cpp b/src/core/qgsvectorlayer.cpp
@@ -2719,7 +2719,7 @@ bool QgsVectorLayer::isReadOnly() const
   return mReadOnly;
 }
 
-bool QgsVectorLayer::setReadOnly( bool readonly )
+bool QgsVectorLayer::setFieldEditable( bool readonly )
 {
   // exit if the layer is in editing mode
   if ( readonly && mEditBuffer )
diff --git a/src/core/qgsvectorlayer.h b/src/core/qgsvectorlayer.h
@@ -1126,7 +1126,7 @@ class CORE_EXPORT QgsVectorLayer : public QgsMapLayer
     /** Make layer read-only (editing disabled) or not
      *  @return false if the layer is in editing yet
      */
-    bool setReadOnly( bool readonly = true );
+    bool setFieldEditable( bool editable = true );
 
     /**
      * Make layer editable.
@@ -1469,9 +1469,9 @@ class CORE_EXPORT QgsVectorLayer : public QgsMapLayer
     /**
      * Is edit widget editable
      *
-     * @deprecated Use `editFormConfig()->readOnly()` instead
+     * @deprecated Use `editFormConfig()->fieldEditable()` instead
      */
-    Q_DECL_DEPRECATED bool fieldEditable( int idx ) { return mEditFormConfig->readOnly( idx ); }
+    Q_DECL_DEPRECATED bool fieldEditable( int idx ) { return !mEditFormConfig->readOnly( idx ); }
 
     /**
      * Label widget on top
@@ -1481,9 +1481,9 @@ class CORE_EXPORT QgsVectorLayer : public QgsMapLayer
 
     /**
      * Set edit widget editable
-     * @deprecated Use `editFormConfig()->setReadOnly()` instead
+     * @deprecated Use `editFormConfig()->setFieldEditable()` instead
      */
-    Q_DECL_DEPRECATED void setReadOnly( int idx, bool editable ) { mEditFormConfig->setFieldEditable( idx, editable ); }
+    Q_DECL_DEPRECATED void setFieldEditable( int idx, bool editable ) { mEditFormConfig->setReadOnly( idx, !editable ); }
 
     /**
      * Label widget on top
diff --git a/src/gui/attributetable/qgsattributetabledelegate.cpp b/src/gui/attributetable/qgsattributetabledelegate.cpp
@@ -75,7 +75,7 @@ QWidget *QgsAttributeTableDelegate::createEditor(
 
   w->setAutoFillBackground( true );
 
-  eww->setEnabled( vl->editFormConfig()->fieldEditable( fieldIdx ) );
+  eww->setEnabled( !vl->editFormConfig()->readOnly( fieldIdx ) );
 
   return w;
 }
diff --git a/src/gui/attributetable/qgsattributetablemodel.cpp b/src/gui/attributetable/qgsattributetablemodel.cpp
@@ -681,7 +681,7 @@ Qt::ItemFlags QgsAttributeTableModel::flags( const QModelIndex &index ) const
   Qt::ItemFlags flags = QAbstractItemModel::flags( index );
 
   if ( layer()->isEditable() &&
-       layer()->editFormConfig()->fieldEditable( mAttributes[ index.column()] ) &&
+       !layer()->editFormConfig()->readOnly( mAttributes[ index.column()] ) &&
        (( layer()->dataProvider() && layer()->dataProvider()->capabilities() & QgsVectorDataProvider::ChangeAttributeValues ) ||
         FID_IS_NEW( rowToId( index.row() ) ) ) )
     flags |= Qt::ItemIsEditable;
diff --git a/src/gui/editorwidgets/core/qgseditorwidgetregistry.cpp b/src/gui/editorwidgets/core/qgseditorwidgetregistry.cpp
@@ -245,7 +245,7 @@ void QgsEditorWidgetRegistry::readMapLayer( QgsMapLayer* mapLayer, const QDomEle
         cfg = mWidgetFactories[ewv2Type]->readEditorConfig( ewv2CfgElem, vectorLayer, idx );
       }
 
-      vectorLayer->editFormConfig()->setFieldEditable( idx, ewv2CfgElem.attribute( "fieldEditable", "1" ) == "1" );
+      vectorLayer->editFormConfig()->setReadOnly( idx, ewv2CfgElem.attribute( "fieldEditable", "1" ) != "1" );
       vectorLayer->editFormConfig()->setLabelOnTop( idx, ewv2CfgElem.attribute( "labelOnTop", "0" ) == "1" );
       vectorLayer->editFormConfig()->setWidgetConfig( idx, cfg );
     }
@@ -301,7 +301,7 @@ void QgsEditorWidgetRegistry::writeMapLayer( QgsMapLayer* mapLayer, QDomElement&
     if ( mWidgetFactories.contains( widgetType ) )
     {
       QDomElement ewv2CfgElem = doc.createElement( "widgetv2config" );
-      ewv2CfgElem.setAttribute( "fieldEditable", vectorLayer->editFormConfig()->fieldEditable( idx ) );
+      ewv2CfgElem.setAttribute( "fieldEditable", !vectorLayer->editFormConfig()->readOnly( idx ) );
       ewv2CfgElem.setAttribute( "labelOnTop", vectorLayer->editFormConfig()->labelOnTop( idx ) );
 
       mWidgetFactories[widgetType]->writeConfig( vectorLayer->editFormConfig()->widgetConfig( idx ), ewv2CfgElem, doc, vectorLayer, idx );
diff --git a/src/gui/qgsattributeform.cpp b/src/gui/qgsattributeform.cpp
@@ -175,7 +175,7 @@ bool QgsAttributeForm::save()
         QVariant srcVar = eww->value();
         // need to check dstVar.isNull() != srcVar.isNull()
         // otherwise if dstVar=NULL and scrVar=0, then dstVar = srcVar
-        if (( dstVar != srcVar || dstVar.isNull() != srcVar.isNull() ) && srcVar.isValid() && mLayer->editFormConfig()->fieldEditable( eww->fieldIdx() ) )
+        if (( dstVar != srcVar || dstVar.isNull() != srcVar.isNull() ) && srcVar.isValid() && !mLayer->editFormConfig()->readOnly( eww->fieldIdx() ) )
         {
           dst[eww->fieldIdx()] = srcVar;
 
@@ -220,7 +220,7 @@ bool QgsAttributeForm::save()
         {
           if (( dst.at( i ) == src.at( i ) && dst.at( i ).isNull() == src.at( i ).isNull() )  // If field is not changed...
               || !dst.at( i ).isValid()                                     // or the widget returns invalid (== do not change)
-              || !mLayer->editFormConfig()->fieldEditable( i ) )                           // or the field cannot be edited ...
+              || mLayer->editFormConfig()->readOnly( i ) )                           // or the field cannot be edited ...
           {
             continue;
           }
@@ -367,7 +367,7 @@ void QgsAttributeForm::synchronizeEnabledState()
     QgsEditorWidgetWrapper* eww = qobject_cast<QgsEditorWidgetWrapper*>( ww );
     if ( eww )
     {
-      fieldEditable = mLayer->editFormConfig()->fieldEditable( eww->fieldIdx() ) &&
+      fieldEditable = !mLayer->editFormConfig()->readOnly( eww->fieldIdx() ) &&
                       (( mLayer->dataProvider() && layer()->dataProvider()->capabilities() & QgsVectorDataProvider::ChangeAttributeValues ) ||
                        FID_IS_NEW( mFeature.id() ) );
     }
diff --git a/src/plugins/geometry_checker/ui/qgsgeometrycheckerresulttab.cpp b/src/plugins/geometry_checker/ui/qgsgeometrycheckerresulttab.cpp
@@ -78,7 +78,7 @@ QgsGeometryCheckerResultTab::QgsGeometryCheckerResultTab( QgisInterface* iface,
 QgsGeometryCheckerResultTab::~QgsGeometryCheckerResultTab()
 {
   if ( mFeaturePool->getLayer() )
-    mFeaturePool->getLayer()->setReadOnly( false );
+    mFeaturePool->getLayer()->setFieldEditable( false );
   delete mChecker;
   delete mFeaturePool;
   qDeleteAll( mCurrentRubberBands );
diff --git a/src/plugins/geometry_checker/ui/qgsgeometrycheckersetuptab.cpp b/src/plugins/geometry_checker/ui/qgsgeometrycheckersetuptab.cpp
@@ -286,7 +286,7 @@ void QgsGeometryCheckerSetupTab::runChecks()
   emit checkerStarted( checker, featurePool );
 
   /** Add result layer (do this after checkerStarted, otherwise warning about removing of result layer may appear) **/
-  layer->setReadOnly( true );
+  layer->setFieldEditable( true );
   if ( ui.radioButtonOutputNew->isChecked() )
   {
     QgsMapLayerRegistry::instance()->addMapLayers( QList<QgsMapLayer*>() << layer );
diff --git a/src/plugins/geometry_snapper/qgsgeometrysnapperdialog.cpp b/src/plugins/geometry_snapper/qgsgeometrysnapperdialog.cpp
@@ -261,7 +261,7 @@ void QgsGeometrySnapperDialog::run()
     }
   }
 
-  layer->setReadOnly( true );
+  layer->setFieldEditable( true );
   if ( ui.radioButtonOutputNew->isChecked() )
   {
     QgsMapLayerRegistry::instance()->addMapLayers( QList<QgsMapLayer*>() << layer );
@@ -294,7 +294,7 @@ void QgsGeometrySnapperDialog::run()
   ui.progressBar->hide();
   ui.widgetInputs->setEnabled( true );
 
-  layer->setReadOnly( false );
+  layer->setFieldEditable( false );
 
   /** Refresh canvas **/
   mIface->mapCanvas()->refresh();
diff --git a/src/providers/grass/qgsgrassprovider.cpp b/src/providers/grass/qgsgrassprovider.cpp
@@ -1138,8 +1138,8 @@ void QgsGrassProvider::startEditing( QgsVectorLayer *vectorLayer )
 
   // TODO: enable cats editing once all consequences are implemented
   // disable cat and topo symbol editing
-  vectorLayer->editFormConfig()->setFieldEditable( mLayer->keyColumn(), false );
-  vectorLayer->editFormConfig()->setFieldEditable( mLayer->fields().size() - 1, false );
+  vectorLayer->editFormConfig()->setReadOnly( mLayer->keyColumn(), true );
+  vectorLayer->editFormConfig()->setReadOnly( mLayer->fields().size() - 1, true );
 
   mEditedCount++;
 

Original file line number	Diff line number	Diff line change
`@@ -4,8 +4,8 @@`
`4`	`4`	`QgsEditFormConfig::QgsEditFormConfig( QObject* parent )`
`5`	`5`	`: QObject( parent )`
`6`	`6`	`, mEditorLayout( GeneratedLayout )`
`7`		`- , mUseInitCode( false )`
`8`	`7`	`, mFeatureFormSuppress( SuppressDefault )`
	`8`	`+ , mUseInitCode( false )`
`9`	`9`	`{`
`10`	`10`	`connect( QgsProject::instance()->relationManager(), SIGNAL( relationsLoaded() ), this, SLOT( onRelationsLoaded() ) );`
`11`	`11`	`}`
`@@ -72,17 +72,17 @@ void QgsEditFormConfig::setUiForm( const QString& ui )`
`72`	`72`	`mEditForm = ui;`
`73`	`73`	`}`
`74`	`74`
`75`		`-bool QgsEditFormConfig::fieldEditable( int idx )`
	`75`	`+bool QgsEditFormConfig::readOnly( int idx )`
`76`	`76`	`{`
`77`	`77`	`if ( idx >= 0 && idx < mFields.count() )`
`78`	`78`	`{`
`79`	`79`	`if ( mFields.fieldOrigin( idx ) == QgsFields::OriginJoin`
`80`	`80`	`\|\| mFields.fieldOrigin( idx ) == QgsFields::OriginExpression )`
`81`		`- return false;`
`82`		`- return mFieldEditables.value( mFields.at( idx ).name(), true );`
	`81`	`+ return true;`
	`82`	`+ return !mFieldEditables.value( mFields.at( idx ).name(), true );`
`83`	`83`	`}`
`84`	`84`	`else`
`85`		`- return true;`
	`85`	`+ return false;`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`bool QgsEditFormConfig::labelOnTop( int idx )`
`@@ -93,10 +93,10 @@ bool QgsEditFormConfig::labelOnTop( int idx )`
`93`	`93`	`return false;`
`94`	`94`	`}`
`95`	`95`
`96`		`-void QgsEditFormConfig::setFieldEditable( int idx, bool editable )`
	`96`	`+void QgsEditFormConfig::setReadOnly( int idx, bool readOnly )`
`97`	`97`	`{`
`98`	`98`	`if ( idx >= 0 && idx < mFields.count() )`
`99`		`- mFieldEditables[ mFields.at( idx ).name()] = editable;`
	`99`	`+ mFieldEditables[ mFields.at( idx ).name()] = !readOnly;`
`100`	`100`	`}`
`101`	`101`
`102`	`102`	`void QgsEditFormConfig::setLabelOnTop( int idx, bool onTop )`
Original file line number	Diff line number	Diff line change
`@@ -2719,7 +2719,7 @@ bool QgsVectorLayer::isReadOnly() const`
`2719`	`2719`	`return mReadOnly;`
`2720`	`2720`	`}`
`2721`	`2721`
`2722`		`-bool QgsVectorLayer::setReadOnly( bool readonly )`
	`2722`	`+bool QgsVectorLayer::setFieldEditable( bool readonly )`
`2723`	`2723`	`{`
`2724`	`2724`	`// exit if the layer is in editing mode`
`2725`	`2725`	`if ( readonly && mEditBuffer )`
Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ QWidget *QgsAttributeTableDelegate::createEditor(`
`75`	`75`
`76`	`76`	`w->setAutoFillBackground( true );`
`77`	`77`
`78`		`- eww->setEnabled( vl->editFormConfig()->fieldEditable( fieldIdx ) );`
	`78`	`+ eww->setEnabled( !vl->editFormConfig()->readOnly( fieldIdx ) );`
`79`	`79`
`80`	`80`	`return w;`
`81`	`81`	`}`
Original file line number	Diff line number	Diff line change
`@@ -245,7 +245,7 @@ void QgsEditorWidgetRegistry::readMapLayer( QgsMapLayer* mapLayer, const QDomEle`
`245`	`245`	`cfg = mWidgetFactories[ewv2Type]->readEditorConfig( ewv2CfgElem, vectorLayer, idx );`
`246`	`246`	`}`
`247`	`247`
`248`		`- vectorLayer->editFormConfig()->setFieldEditable( idx, ewv2CfgElem.attribute( "fieldEditable", "1" ) == "1" );`
	`248`	`+ vectorLayer->editFormConfig()->setReadOnly( idx, ewv2CfgElem.attribute( "fieldEditable", "1" ) != "1" );`
`249`	`249`	`vectorLayer->editFormConfig()->setLabelOnTop( idx, ewv2CfgElem.attribute( "labelOnTop", "0" ) == "1" );`
`250`	`250`	`vectorLayer->editFormConfig()->setWidgetConfig( idx, cfg );`
`251`	`251`	`}`
`@@ -301,7 +301,7 @@ void QgsEditorWidgetRegistry::writeMapLayer( QgsMapLayer* mapLayer, QDomElement&`
`301`	`301`	`if ( mWidgetFactories.contains( widgetType ) )`
`302`	`302`	`{`
`303`	`303`	`QDomElement ewv2CfgElem = doc.createElement( "widgetv2config" );`
`304`		`- ewv2CfgElem.setAttribute( "fieldEditable", vectorLayer->editFormConfig()->fieldEditable( idx ) );`
	`304`	`+ ewv2CfgElem.setAttribute( "fieldEditable", !vectorLayer->editFormConfig()->readOnly( idx ) );`
`305`	`305`	`ewv2CfgElem.setAttribute( "labelOnTop", vectorLayer->editFormConfig()->labelOnTop( idx ) );`
`306`	`306`
`307`	`307`	`mWidgetFactories[widgetType]->writeConfig( vectorLayer->editFormConfig()->widgetConfig( idx ), ewv2CfgElem, doc, vectorLayer, idx );`
Original file line number	Diff line number	Diff line change
`@@ -175,7 +175,7 @@ bool QgsAttributeForm::save()`
`175`	`175`	`QVariant srcVar = eww->value();`
`176`	`176`	`// need to check dstVar.isNull() != srcVar.isNull()`
`177`	`177`	`// otherwise if dstVar=NULL and scrVar=0, then dstVar = srcVar`
`178`		`- if (( dstVar != srcVar \|\| dstVar.isNull() != srcVar.isNull() ) && srcVar.isValid() && mLayer->editFormConfig()->fieldEditable( eww->fieldIdx() ) )`
	`178`	`+ if (( dstVar != srcVar \|\| dstVar.isNull() != srcVar.isNull() ) && srcVar.isValid() && !mLayer->editFormConfig()->readOnly( eww->fieldIdx() ) )`
`179`	`179`	`{`
`180`	`180`	`dst[eww->fieldIdx()] = srcVar;`
`181`	`181`
`@@ -220,7 +220,7 @@ bool QgsAttributeForm::save()`
`220`	`220`	`{`
`221`	`221`	`if (( dst.at( i ) == src.at( i ) && dst.at( i ).isNull() == src.at( i ).isNull() ) // If field is not changed...`
`222`	`222`	`\|\| !dst.at( i ).isValid() // or the widget returns invalid (== do not change)`
`223`		`- \|\| !mLayer->editFormConfig()->fieldEditable( i ) ) // or the field cannot be edited ...`
	`223`	`+ \|\| mLayer->editFormConfig()->readOnly( i ) ) // or the field cannot be edited ...`
`224`	`224`	`{`
`225`	`225`	`continue;`
`226`	`226`	`}`
`@@ -367,7 +367,7 @@ void QgsAttributeForm::synchronizeEnabledState()`
`367`	`367`	`QgsEditorWidgetWrapper* eww = qobject_cast<QgsEditorWidgetWrapper*>( ww );`
`368`	`368`	`if ( eww )`
`369`	`369`	`{`
`370`		`- fieldEditable = mLayer->editFormConfig()->fieldEditable( eww->fieldIdx() ) &&`
	`370`	`+ fieldEditable = !mLayer->editFormConfig()->readOnly( eww->fieldIdx() ) &&`
`371`	`371`	`(( mLayer->dataProvider() && layer()->dataProvider()->capabilities() & QgsVectorDataProvider::ChangeAttributeValues ) \|\|`
`372`	`372`	`FID_IS_NEW( mFeature.id() ) );`
`373`	`373`	`}`
Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ QgsGeometryCheckerResultTab::QgsGeometryCheckerResultTab( QgisInterface* iface,`
`78`	`78`	`QgsGeometryCheckerResultTab::~QgsGeometryCheckerResultTab()`
`79`	`79`	`{`
`80`	`80`	`if ( mFeaturePool->getLayer() )`
`81`		`- mFeaturePool->getLayer()->setReadOnly( false );`
	`81`	`+ mFeaturePool->getLayer()->setFieldEditable( false );`
`82`	`82`	`delete mChecker;`
`83`	`83`	`delete mFeaturePool;`
`84`	`84`	`qDeleteAll( mCurrentRubberBands );`
Original file line number	Diff line number	Diff line change
`@@ -286,7 +286,7 @@ void QgsGeometryCheckerSetupTab::runChecks()`
`286`	`286`	`emit checkerStarted( checker, featurePool );`
`287`	`287`
`288`	`288`	`/ Add result layer (do this after checkerStarted, otherwise warning about removing of result layer may appear) /`
`289`		`- layer->setReadOnly( true );`
	`289`	`+ layer->setFieldEditable( true );`
`290`	`290`	`if ( ui.radioButtonOutputNew->isChecked() )`
`291`	`291`	`{`
`292`	`292`	`QgsMapLayerRegistry::instance()->addMapLayers( QList<QgsMapLayer*>() << layer );`
Original file line number	Diff line number	Diff line change
`@@ -261,7 +261,7 @@ void QgsGeometrySnapperDialog::run()`
`261`	`261`	`}`
`262`	`262`	`}`
`263`	`263`
`264`		`- layer->setReadOnly( true );`
	`264`	`+ layer->setFieldEditable( true );`
`265`	`265`	`if ( ui.radioButtonOutputNew->isChecked() )`
`266`	`266`	`{`
`267`	`267`	`QgsMapLayerRegistry::instance()->addMapLayers( QList<QgsMapLayer*>() << layer );`
`@@ -294,7 +294,7 @@ void QgsGeometrySnapperDialog::run()`
`294`	`294`	`ui.progressBar->hide();`
`295`	`295`	`ui.widgetInputs->setEnabled( true );`
`296`	`296`
`297`		`- layer->setReadOnly( false );`
	`297`	`+ layer->setFieldEditable( false );`
`298`	`298`
`299`	`299`	`/ Refresh canvas /`
`300`	`300`	`mIface->mapCanvas()->refresh();`