Skip to content
Permalink
Browse files

[Plugin manager][needs-doc] Read a CHANGELOG file in case the relevan…

…t metadata key is empty
  • Loading branch information
borysiasty committed Oct 27, 2017
1 parent a843df8 commit 4cde5202483c6dd3bed982d2af90212afce8c7f5
Showing with 7 additions and 1 deletion.
  1. +7 −1 python/pyplugin_installer/installer_data.py
@@ -663,6 +663,12 @@ def pluginMetadata(fct):
if QFileInfo(icon).isRelative():
icon = path + "/" + icon

changelog = pluginMetadata("changelog")
changelogFile = os.path.join(path, "CHANGELOG")
if not changelog and QFile(changelogFile).exists():
with open(changelogFile) as f:
changelog = f.read()

plugin = {
"id": key,
"plugin_id": None,
@@ -672,7 +678,7 @@ def pluginMetadata(fct):
"icon": icon,
"category": pluginMetadata("category"),
"tags": pluginMetadata("tags"),
"changelog": pluginMetadata("changelog"),
"changelog": changelog,
"author_name": pluginMetadata("author_name") or pluginMetadata("author"),
"author_email": pluginMetadata("email"),
"homepage": pluginMetadata("homepage"),

3 comments on commit 4cde520

@borysiasty

This comment has been minimized.

Copy link
Member Author

@borysiasty borysiasty replied Oct 27, 2017

FYI @alexbruy @elpaso

Fetching the changelog from repository on request (if not included to the repo.xml) still on my todo list (hopefully for QGIS 3.2).

@m-kuhn

This comment has been minimized.

Copy link
Member

@m-kuhn m-kuhn replied Oct 29, 2017

@borysiasty if I may propose something, can you include markdown format for the changelog?

@borysiasty

This comment has been minimized.

Copy link
Member Author

@borysiasty borysiasty replied Oct 29, 2017

@m-kuhn For QGIS 3.0 I'm going to only tweak the css a bit and make the changelog less obtrusive. Then I'm going to put some javascript logic in QGIS 3.2, so the plugin pages are sexier (firmly requested by @wonder-sk ;) ). At that stage, a markdown parser is a great idea. Thanks, added to requested features.

So let's wait until we're defrozen. Or correct me if I'm wrong and QtWebkit is already able to parse markdown. AFAIK it doesn't.

Please sign in to comment.
You can’t perform that action at this time.