[oracle] Fix crash when adding a feature with missing attributes

nyalldawson · nyalldawson · commit 4d61fb5e6342 · 2018-04-21T21:21:28.000+10:00
to data provider
diff --git a/src/providers/oracle/qgsoracleprovider.cpp b/src/providers/oracle/qgsoracleprovider.cpp
@@ -1298,7 +1298,7 @@ bool QgsOracleProvider::addFeatures( QgsFeatureList &flist, QgsFeatureSink::Flag
 
       for ( int i = 0; i < fieldId.size(); i++ )
       {
-        QVariant value = attributevec[ fieldId[i] ];
+        QVariant value = attributevec.value( fieldId[i], QVariant() );
 
         QString v;
         if ( !value.isValid() )

Original file line number	Diff line number	Diff line change
`@@ -1298,7 +1298,7 @@ bool QgsOracleProvider::addFeatures( QgsFeatureList &flist, QgsFeatureSink::Flag`
`1298`	`1298`
`1299`	`1299`	`for ( int i = 0; i < fieldId.size(); i++ )`
`1300`	`1300`	`{`
`1301`		`- QVariant value = attributevec[ fieldId[i] ];`
	`1301`	`+ QVariant value = attributevec.value( fieldId[i], QVariant() );`
`1302`	`1302`
`1303`	`1303`	`QString v;`
`1304`	`1304`	`if ( !value.isValid() )`