Skip to content

Commit 4e8635b

Browse files
committed
rename QgsVectorLayerEditUtils::deleteVertexV2
1 parent 39c4409 commit 4e8635b

File tree

5 files changed

+5
-22
lines changed

5 files changed

+5
-22
lines changed

doc/api_break.dox

+1
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,7 @@ This page tries to maintain a list with incompatible changes that happened in pr
160160
<tr><td>QgsVectorLayer<td>editorWidgetV2Type<td>editorWidgetType
161161
<tr><td>QgsVectorLayer<td>deleteVertexV2<td>deleteVertex
162162
<tr><td>QgsVectorLayer<td>rendererV2<td>renderer
163+
<tr><td>QgsVectorLayerEditUtils<td>deleteVertexV2<td>deleteVertex
163164
</table>
164165

165166
\subsection qgis_api_break_3_0_removed_classes Removed Classes

python/core/qgsvectorlayereditutils.sip

+1-7
Original file line numberDiff line numberDiff line change
@@ -28,18 +28,12 @@ class QgsVectorLayerEditUtils
2828
*/
2929
bool moveVertex( const QgsPointV2& p, QgsFeatureId atFeatureId, int atVertex ) /PyName=moveVertexV2/;
3030

31-
/** Deletes a vertex from a feature
32-
* @deprecated use deleteVertexV2() instead
33-
*/
34-
bool deleteVertex( QgsFeatureId atFeatureId, int atVertex ) /Deprecated/;
35-
3631
/** Deletes a vertex from a feature.
3732
* @param featureId ID of feature to remove vertex from
3833
* @param vertex index of vertex to delete
3934
* @note added in QGIS 2.14
4035
*/
41-
//TODO QGIS 3.0 - rename to deleteVertex
42-
QgsVectorLayer::EditResult deleteVertexV2( QgsFeatureId featureId, int vertex );
36+
QgsVectorLayer::EditResult deleteVertex( QgsFeatureId featureId, int vertex );
4337

4438
/** Adds a ring to polygon/multipolygon features
4539
* @param ring ring to add

src/core/qgsvectorlayer.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -1060,7 +1060,7 @@ QgsVectorLayer::EditResult QgsVectorLayer::deleteVertex( QgsFeatureId featureId,
10601060
return QgsVectorLayer::InvalidLayer;
10611061

10621062
QgsVectorLayerEditUtils utils( this );
1063-
EditResult result = utils.deleteVertexV2( featureId, vertex );
1063+
EditResult result = utils.deleteVertex( featureId, vertex );
10641064

10651065
if ( result == Success )
10661066
updateExtents();

src/core/qgsvectorlayereditutils.cpp

+1-7
Original file line numberDiff line numberDiff line change
@@ -85,13 +85,7 @@ bool QgsVectorLayerEditUtils::moveVertex( const QgsPointV2& p, QgsFeatureId atFe
8585
}
8686

8787

88-
bool QgsVectorLayerEditUtils::deleteVertex( QgsFeatureId atFeatureId, int atVertex )
89-
{
90-
QgsVectorLayer::EditResult res = deleteVertexV2( atFeatureId, atVertex );
91-
return res == QgsVectorLayer::Success || res == QgsVectorLayer::EmptyGeometry;
92-
}
93-
94-
QgsVectorLayer::EditResult QgsVectorLayerEditUtils::deleteVertexV2( QgsFeatureId featureId, int vertex )
88+
QgsVectorLayer::EditResult QgsVectorLayerEditUtils::deleteVertex( QgsFeatureId featureId, int vertex )
9589
{
9690
if ( !L->hasGeometryType() )
9791
return QgsVectorLayer::InvalidLayer;

src/core/qgsvectorlayereditutils.h

+1-7
Original file line numberDiff line numberDiff line change
@@ -53,18 +53,12 @@ class CORE_EXPORT QgsVectorLayerEditUtils
5353
*/
5454
bool moveVertex( const QgsPointV2& p, QgsFeatureId atFeatureId, int atVertex );
5555

56-
/** Deletes a vertex from a feature
57-
* @deprecated use deleteVertexV2() instead
58-
*/
59-
Q_DECL_DEPRECATED bool deleteVertex( QgsFeatureId atFeatureId, int atVertex );
60-
6156
/** Deletes a vertex from a feature.
6257
* @param featureId ID of feature to remove vertex from
6358
* @param vertex index of vertex to delete
6459
* @note added in QGIS 2.14
6560
*/
66-
//TODO QGIS 3.0 - rename to deleteVertex
67-
QgsVectorLayer::EditResult deleteVertexV2( QgsFeatureId featureId, int vertex );
61+
QgsVectorLayer::EditResult deleteVertex( QgsFeatureId featureId, int vertex );
6862

6963
/** Adds a ring to polygon/multipolygon features
7064
* @param ring ring to add

0 commit comments

Comments
 (0)