Skip to content

Commit 4f9e2a5

Browse files
DelazJnyalldawson
authored andcommitted
Do not change property widget status if the dialog is rejected
refs #16766
1 parent 731b57c commit 4f9e2a5

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

src/gui/qgspropertyoverridebutton.cpp

+10-8
Original file line numberDiff line numberDiff line change
@@ -639,16 +639,18 @@ void QgsPropertyOverrideButton::showAssistant()
639639
connect( buttonBox, &QDialogButtonBox::rejected, dlg, &QDialog::reject );
640640
connect( buttonBox, &QDialogButtonBox::helpRequested, this, &QgsPropertyOverrideButton::showHelp );
641641
dlg->layout()->addWidget( buttonBox );
642-
dlg->exec();
643-
settings.setValue( key, dlg->saveGeometry() );
644642

645-
widget->updateProperty( mProperty );
646-
mExpressionString = mProperty.asExpression();
647-
mFieldName = mProperty.field();
648-
widget->acceptPanel();
649-
updateGui();
643+
if ( dlg->exec() == QDialog::Accepted )
644+
{
645+
widget->updateProperty( mProperty );
646+
mExpressionString = mProperty.asExpression();
647+
mFieldName = mProperty.field();
648+
widget->acceptPanel();
649+
updateGui();
650650

651-
emit changed();
651+
emit changed();
652+
}
653+
settings.setValue( key, dlg->saveGeometry() );
652654
}
653655
}
654656

0 commit comments

Comments
 (0)