fix for a regression - QgsVectorLayer::featureAtId returns empty attribute map if not in editing mode

wonder · wonder · commit 512b99c285e4 · 2008-12-18T18:56:15.000Z
git-svn-id: http://svn.osgeo.org/qgis/trunk/qgis@9851 c8812cc2-4d05-0410-92ff-de0c093fc19c
diff --git a/src/core/qgsvectorlayer.cpp b/src/core/qgsvectorlayer.cpp
@@ -1154,6 +1154,10 @@ void QgsVectorLayer::setSubsetString( QString subset )
 
 void QgsVectorLayer::updateFeatureAttributes( QgsFeature &f )
 {
+  // do not update when we aren't in editing mode
+  if ( ! mEditable )
+    return;
+
   if ( mChangedAttributeValues.contains( f.id() ) )
   {
     const QgsAttributeMap &map = mChangedAttributeValues[f.id()];

Original file line number	Diff line number	Diff line change
`@@ -1154,6 +1154,10 @@ void QgsVectorLayer::setSubsetString( QString subset )`
`1154`	`1154`
`1155`	`1155`	`void QgsVectorLayer::updateFeatureAttributes( QgsFeature &f )`
`1156`	`1156`	`{`
	`1157`	`+ // do not update when we aren't in editing mode`
	`1158`	`+ if ( ! mEditable )`
	`1159`	`+ return;`
	`1160`	`+`
`1157`	`1161`	`if ( mChangedAttributeValues.contains( f.id() ) )`
`1158`	`1162`	`{`
`1159`	`1163`	`const QgsAttributeMap &map = mChangedAttributeValues[f.id()];`