Skip to content

Commit 5247673

Browse files
committed
Add some provider tests for empty rectangles
1 parent 619b32d commit 5247673

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

tests/src/python/providertestbase.py

+10
Original file line numberDiff line numberDiff line change
@@ -282,6 +282,11 @@ def testGetFeaturesFilterRectTests(self):
282282
features = [f['pk'] for f in self.provider.getFeatures(QgsFeatureRequest().setFilterRect(extent))]
283283
assert set(features) == set([2, 4]), 'Got {} instead'.format(features)
284284

285+
# test with an empty rectangle
286+
extent = QgsRectangle()
287+
features = [f['pk'] for f in self.provider.getFeatures(QgsFeatureRequest().setFilterRect(extent))]
288+
assert set(features) == set([1, 2, 3, 4, 5]), 'Got {} instead'.format(features)
289+
285290
def testGetFeaturesPolyFilterRectTests(self):
286291
""" Test fetching features from a polygon layer with filter rect"""
287292
try:
@@ -299,6 +304,11 @@ def testGetFeaturesPolyFilterRectTests(self):
299304
features = [f['pk'] for f in self.poly_provider.getFeatures(QgsFeatureRequest().setFilterRect(extent).setFlags(QgsFeatureRequest.ExactIntersect))]
300305
assert set(features) == set([2, 3]), 'Got {} instead'.format(features)
301306

307+
# test with an empty rectangle
308+
extent = QgsRectangle()
309+
features = [f['pk'] for f in self.provider.getFeatures(QgsFeatureRequest().setFilterRect(extent))]
310+
assert set(features) == set([1, 2, 3, 4, 5]), 'Got {} instead'.format(features)
311+
302312
def testRectAndExpression(self):
303313
extent = QgsRectangle(-70, 67, -60, 80)
304314
result = set([f['pk'] for f in self.provider.getFeatures(

0 commit comments

Comments
 (0)