Handle invalid step size

m-kuhn · m-kuhn · commit 528aee07b388 · 2018-07-05T11:44:45.000-05:00
in range widgets in combination with NULL values. Fix #18583 https://issues.qgis.org/issues/18583
diff --git a/src/gui/editorwidgets/qgsrangewidgetwrapper.cpp b/src/gui/editorwidgets/qgsrangewidgetwrapper.cpp
@@ -138,7 +138,7 @@ void QgsRangeWidgetWrapper::initWidget( QWidget *editor )
     int minval = min.toInt();
     if ( allowNull )
     {
-      int stepval = step.toInt();
+      int stepval = step.isValid() ? step.toInt() : 1;
       minval -= stepval;
       mIntSpinBox->setValue( minval );
       mIntSpinBox->setSpecialValueText( QgsApplication::nullRepresentation() );

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ void QgsRangeWidgetWrapper::initWidget( QWidget *editor )`
`138`	`138`	`int minval = min.toInt();`
`139`	`139`	`if ( allowNull )`
`140`	`140`	`{`
`141`		`- int stepval = step.toInt();`
	`141`	`+ int stepval = step.isValid() ? step.toInt() : 1;`
`142`	`142`	`minval -= stepval;`
`143`	`143`	`mIntSpinBox->setValue( minval );`
`144`	`144`	`mIntSpinBox->setSpecialValueText( QgsApplication::nullRepresentation() );`