Skip to content

Commit 5342a12

Browse files
committed
Remove special handling for attribute table "show visible" initial state
This is no longer required as the show visible option now always uses provider side filters
1 parent 6cd97d8 commit 5342a12

File tree

2 files changed

+0
-8
lines changed

2 files changed

+0
-8
lines changed

src/app/qgsattributetabledialog.cpp

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -141,11 +141,6 @@ QgsAttributeTableDialog::QgsAttributeTableDialog( QgsVectorLayer *layer, QWidget
141141
QgsMapCanvas *mc = QgisApp::instance()->mapCanvas();
142142
QgsRectangle extent( mc->mapSettings().mapToLayerCoordinates( layer, mc->extent() ) );
143143
r.setFilterRect( extent );
144-
145-
mRubberBand = new QgsRubberBand( mc, QgsWkbTypes::PolygonGeometry );
146-
mRubberBand->setToGeometry( QgsGeometry::fromRect( extent ), layer );
147-
148-
mActionShowAllFilter->setText( tr( "Show All Features In Initial Canvas Extent" ) );
149144
needsGeom = true;
150145
}
151146
else if ( initialMode == QgsAttributeTableFilterModel::ShowSelected )
@@ -344,7 +339,6 @@ QgsAttributeTableDialog::QgsAttributeTableDialog( QgsVectorLayer *layer, QWidget
344339
QgsAttributeTableDialog::~QgsAttributeTableDialog()
345340
{
346341
delete myDa;
347-
delete mRubberBand;
348342
}
349343

350344
void QgsAttributeTableDialog::updateTitle()
@@ -355,7 +349,6 @@ void QgsAttributeTableDialog::updateTitle()
355349
.arg( mMainView->featureCount() )
356350
.arg( mMainView->filteredFeatureCount() )
357351
.arg( mLayer->selectedFeatureCount() )
358-
.arg( mRubberBand ? tr( ", spatially limited" ) : QLatin1String( "" ) )
359352
);
360353

361354
if ( mMainView->filterMode() == QgsAttributeTableFilterModel::ShowAll )

src/app/qgsattributetabledialog.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,6 @@ class APP_EXPORT QgsAttributeTableDialog : public QDialog, private Ui::QgsAttrib
229229
QSignalMapper *mFilterActionMapper = nullptr;
230230

231231
QgsVectorLayer *mLayer = nullptr;
232-
QgsRubberBand *mRubberBand = nullptr;
233232
QgsSearchWidgetWrapper *mCurrentSearchWidgetWrapper = nullptr;
234233
QStringList mVisibleFields;
235234
QgsAttributeEditorContext mEditorContext;

0 commit comments

Comments
 (0)