Skip to content

Commit

Permalink
Show checkboxes in pluginmanager
Browse files Browse the repository at this point in the history
Fix #12839
Followup be15d95
  • Loading branch information
m-kuhn committed May 28, 2015
1 parent 7d7cdcd commit 5386a23
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/app/pluginmanager/qgspluginitemdelegate.cpp
Expand Up @@ -69,7 +69,7 @@ void QgsPluginItemDelegate::paint( QPainter *painter, const QStyleOptionViewItem
if ( !iconPixmap.isNull() )
{
int iconSize = pixelsHigh;
painter->drawPixmap( option.rect.left() + 0.2 * pixelsHigh , option.rect.top() + 0.2 * pixelsHigh, iconSize, iconSize, iconPixmap );
painter->drawPixmap( option.rect.left() + 1.2 * pixelsHigh , option.rect.top() + 0.2 * pixelsHigh, iconSize, iconSize, iconPixmap );
}

// Draw the text
Expand All @@ -95,7 +95,7 @@ void QgsPluginItemDelegate::paint( QPainter *painter, const QStyleOptionViewItem
font.setBold( true );
painter->setFont( font );
}
painter->drawText( option.rect.left() + pixelsHigh * 1.4, option.rect.bottom() - pixelsHigh * 0.4, index.data( Qt::DisplayRole ).toString() );
painter->drawText( option.rect.left() + pixelsHigh * 2.4, option.rect.bottom() - pixelsHigh * 0.4, index.data( Qt::DisplayRole ).toString() );

painter->restore();
}
Expand Down

3 comments on commit 5386a23

@slarosa
Copy link
Member

@slarosa slarosa commented on 5386a23 Jun 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m-kuhn is it possible to shift the left position of 0.2 px either for text or icon? For me the icons are too close to the checkbox. thanks

image

@m-kuhn
Copy link
Member Author

@m-kuhn m-kuhn commented on 5386a23 Jun 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which OS is this?

That's how it looks for me... Adding more spacing would look weird here.

Instead of using the text height as width indicator for the checkbox there should be something else used...

plugins

@slarosa
Copy link
Member

@slarosa slarosa commented on 5386a23 Jun 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m-kuhn I am on Debian with Gnome Shell, with the adwaita theme it is fine:

image

I had applied some customization to my GTK+ theme and the icons were too close to the checkbox.

Please sign in to comment.