Permalink
6 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Showing
1 changed file
with
2 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55a8d41
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@signedav looking really close - please don't forget to replace the bool enabledOnlyWhenEditable argument with a more flexible flags approach!
55a8d41
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll need some more time for the flag approach. Is the total deadline for that reached in 3 minutes or should I do it this afternoon?
55a8d41
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you skip this bool from the python bindings then, so it's not locked into api and we can revise for 3.2?
55a8d41
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with the binding, sorry.
Is this the right approach?
And is it sufficient to do it only in the constructors of QgsAction and QgsMapLayerAction or is it needed in every method?
55a8d41
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case you'd do something like
#ifndef SIP_RUN
...original declaration
#else
...declaration missing extra Param
#endif
Then run sipify and the python bindings should be missing the extra argument. I'd just do it for all the constructors with the bool argument.
55a8d41
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. I'll try that. Thanks.