Skip to content
Permalink
Browse files

Avoid undefined behaviour with signed integer overflow

  • Loading branch information
Hugo Mercier
Hugo Mercier committed Feb 1, 2019
1 parent eb5a336 commit 5609f4a87971ccb9068799e1292fb73c058e8a6e
Showing with 4 additions and 4 deletions.
  1. +4 −4 src/gui/editorwidgets/qgsrangewidgetwrapper.cpp
@@ -144,12 +144,12 @@ void QgsRangeWidgetWrapper::initWidget( QWidget *editor )
int minval = min.toInt();
if ( allowNull )
{
int stepval = step.isValid() ? step.toInt() : 1;
int newMinval = minval - stepval;
uint stepval = step.isValid() ? step.toUInt() : 1;
// make sure there is room for a new value (i.e. signed integer does not overflow)
if ( newMinval < minval )
int minvalOverflow = uint( minval ) - stepval;
if ( minvalOverflow < minval )
{
minval = newMinval;
minval = minvalOverflow;
}
mIntSpinBox->setValue( minval );
QgsSpinBox *intSpinBox( qobject_cast<QgsSpinBox *>( mIntSpinBox ) );

0 comments on commit 5609f4a

Please sign in to comment.
You can’t perform that action at this time.