Skip to content
Permalink
Browse files

Keep log button in status bar.

Removing UI elements under the user isn't good UX
  • Loading branch information
NathanW2 committed Sep 14, 2014
1 parent c076b30 commit 56a7702f3983002e7739b54832dae3f761db076d
Showing with 0 additions and 2 deletions.
  1. +0 −2 src/gui/qgsmessagelogviewer.cpp
@@ -63,7 +63,6 @@ QgsMessageLogViewer::QgsMessageLogViewer( QStatusBar *statusBar, QWidget *parent
mButton->setToolTip( tr( "No messages." ) );
#endif
mButton->setCheckable( true );
mButton->hide();
connect( mButton, SIGNAL( toggled( bool ) ), this, SLOT( buttonToggled( bool ) ) );
connect( mButton, SIGNAL( destroyed() ), this, SLOT( buttonDestroyed() ) );
statusBar->addPermanentWidget( mButton, 0 );
@@ -89,7 +88,6 @@ void QgsMessageLogViewer::showEvent( QShowEvent * )
if ( mButton )
{
mButton->setChecked( true );
mButton->hide();
}
}

2 comments on commit 56a7702

@nyalldawson

This comment has been minimized.

Copy link
Contributor

@nyalldawson nyalldawson replied Sep 14, 2014

@NathanW2 I understand the rationale behind this change, but it's a bit alarming to always have a yellow exclamation visible on the status bar. Do we even need this button here at all? Could we remove the button and leave the panel accessible only via the menu item?
Alternatively, maybe we need two icons - one grayscale, faded icon for when there's nothing to alert the user in the log, and a second yellow icon which only shows when there's an error in the log?

@NathanW2

This comment has been minimized.

Copy link
Member Author

@NathanW2 NathanW2 replied Sep 14, 2014

Please sign in to comment.
You can’t perform that action at this time.