Skip to content

Commit

Permalink
Fix constant background CPU usage
Browse files Browse the repository at this point in the history
  • Loading branch information
@nyalldawson
nyalldawson committed Sep 17, 2016
1 parent 5e96192 commit 59583e9
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/gui/qgsfilterlineedit.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,13 @@ QgsFilterLineEdit::QgsFilterLineEdit( QWidget* parent, const QString& nullValue

void QgsFilterLineEdit::setShowClearButton( bool visible )
{
bool changed = mClearButtonVisible != visible;
mClearButtonVisible = visible;
if ( !visible )
mClearHover = false;

update();
if ( changed )
update();
}

void QgsFilterLineEdit::mousePressEvent( QMouseEvent* e )
Expand Down

8 comments on commit 59583e9

@NathanW2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this what you talked to me about the other day?

@nyalldawson
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. There was an endless cycle between this and qgsdoublespinbox. All fixed:)

@NathanW2
Copy link
Member

@NathanW2 NathanW2 commented on 59583e9 Sep 17, 2016 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rduivenvoorde
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @nyalldawson !

this makes my day \o/

can you please also backport to master_2 ?

@jef-n
Copy link
Member

@jef-n jef-n commented on 59583e9 Sep 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rduivenvoorde done. Apparently also fixes a strange bug with the file selection dialog, which was only partly visible for me.

@rduivenvoorde
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jef-n yep, noticed that too. Thanks

@jef-n
Copy link
Member

@jef-n jef-n commented on 59583e9 Sep 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also #15568

@nyalldawson
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you find it?

@nirvn bisected to the offending commit

Please sign in to comment.