Skip to content
Permalink
Browse files

Fix constant background CPU usage

  • Loading branch information
nyalldawson committed Sep 17, 2016
1 parent 5e96192 commit 59583e97deef732f6884a54b518fc34225fd6012
Showing with 3 additions and 1 deletion.
  1. +3 −1 src/gui/qgsfilterlineedit.cpp
@@ -46,11 +46,13 @@ QgsFilterLineEdit::QgsFilterLineEdit( QWidget* parent, const QString& nullValue

void QgsFilterLineEdit::setShowClearButton( bool visible )
{
bool changed = mClearButtonVisible != visible;
mClearButtonVisible = visible;
if ( !visible )
mClearHover = false;

update();
if ( changed )
update();
}

void QgsFilterLineEdit::mousePressEvent( QMouseEvent* e )

8 comments on commit 59583e9

@NathanW2

This comment has been minimized.

Copy link
Member

@NathanW2 NathanW2 replied Sep 17, 2016

Was this what you talked to me about the other day?

@nyalldawson

This comment has been minimized.

Copy link
Collaborator Author

@nyalldawson nyalldawson replied Sep 17, 2016

Yep. There was an endless cycle between this and qgsdoublespinbox. All fixed:)

@NathanW2

This comment has been minimized.

Copy link
Member

@NathanW2 NathanW2 replied Sep 17, 2016

@rduivenvoorde

This comment has been minimized.

Copy link
Contributor

@rduivenvoorde rduivenvoorde replied Sep 17, 2016

thanks @nyalldawson !

this makes my day \o/

can you please also backport to master_2 ?

@jef-n

This comment has been minimized.

Copy link
Member

@jef-n jef-n replied Sep 17, 2016

@rduivenvoorde done. Apparently also fixes a strange bug with the file selection dialog, which was only partly visible for me.

@rduivenvoorde

This comment has been minimized.

Copy link
Contributor

@rduivenvoorde rduivenvoorde replied Sep 17, 2016

@jef-n yep, noticed that too. Thanks

@jef-n

This comment has been minimized.

Copy link
Member

@jef-n jef-n replied Sep 17, 2016

See also #15568

@nyalldawson

This comment has been minimized.

Copy link
Collaborator Author

@nyalldawson nyalldawson replied Sep 17, 2016

How did you find it?

@nirvn bisected to the offending commit

Please sign in to comment.
You can’t perform that action at this time.