Make Qt containers const in QgsHanaSourceSelect

qgis · Dec 21, 2020 · 5a7b509fb6e78ea6c219eb5f1c14599a402273ab · 5a7b509
1 parent fb46ff3
commit 5a7b509fb6e78ea6c219eb5f1c14599a402273ab
Unified Split

Showing with 3 additions and 2 deletions.

+3 −2 src/providers/hana/qgshanasourceselect.cpp
diff --git a/src/providers/hana/qgshanasourceselect.cpp b/src/providers/hana/qgshanasourceselect.cpp
@@ -163,7 +163,7 @@ void QgsHanaSourceSelectDelegate::setEditorData( QWidget *editor, const QModelIn
     if ( index.column() == QgsHanaTableModel::DbtmPkCol &&
          !index.data( Qt::UserRole + 2 ).toStringList().isEmpty() )
     {
-      QStringList columns = index.data( Qt::UserRole + 2 ).toStringList();
+      const QStringList columns = index.data( Qt::UserRole + 2 ).toStringList();
       for ( const QString &colName : columns )
       {
         QStandardItemModel *cbm = qobject_cast<QStandardItemModel *>( cb->model() );
@@ -500,7 +500,8 @@ void QgsHanaSourceSelect::addButtonClicked()
 {
   mSelectedTables.clear();
 
-  for ( const QModelIndex &idx : mTablesTreeView->selectionModel()->selection().indexes() )
+  const QModelIndexList indexes = mTablesTreeView->selectionModel()->selection().indexes();
+  for ( const QModelIndex &idx : indexes )
   {
     if ( idx.column() != QgsHanaTableModel::DbtmTable )
       continue;