Skip to content

Commit

Permalink
Add missing SIP_DEPRECATED
Browse files Browse the repository at this point in the history
  • Loading branch information
nyalldawson committed May 3, 2018
1 parent 1e7d479 commit 5c93666
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion python/gui/qgsattributeform.sip.in
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ on all attribute widgets.

signals:

void attributeChanged( const QString &attribute, const QVariant &value );
void attributeChanged( const QString &attribute, const QVariant &value ) /Deprecated/;

This comment has been minimized.

Copy link
@m-kuhn

m-kuhn May 3, 2018

Member

Why is that deprecated?

This comment has been minimized.

Copy link
@nyalldawson

nyalldawson May 3, 2018

Author Collaborator

I dunno - I just saw the Q_DECL_DEPRECATED without the companion SIP_DEPRECATED so added it.

This comment has been minimized.

Copy link
@3nids

This comment has been minimized.

Copy link
@m-kuhn

m-kuhn May 3, 2018

Member

lol, do you remember why I/we decided to do so? (and why we decided not to leave a comment about replacement in the \deprecated comment?)

This comment has been minimized.

Copy link
@3nids

3nids May 3, 2018

Member

to properly detect changes in the forms (the ones triggers by switching features in attribute table and the ones triggered by the user) and to fix constraint checking when going back to initial value of the field.
We introduced an additional value in the signal to distinguish the reason of widget change.

%Docstring
Notifies about changes of attributes

Expand Down
2 changes: 1 addition & 1 deletion src/gui/qgsattributeform.h
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ class GUI_EXPORT QgsAttributeForm : public QWidget
* \param value The new value of the attribute.
* \deprecated since 3.0
*/
Q_DECL_DEPRECATED void attributeChanged( const QString &attribute, const QVariant &value );
Q_DECL_DEPRECATED void attributeChanged( const QString &attribute, const QVariant &value ) SIP_DEPRECATED;

/**
* Notifies about changes of attributes
Expand Down

0 comments on commit 5c93666

Please sign in to comment.