Skip to content

Commit 60f311d

Browse files
author
jef
committed
make PyQt4 detection work with CMake 2.6.0 as found in Debian lenny
git-svn-id: http://svn.osgeo.org/qgis/trunk/qgis@13473 c8812cc2-4d05-0410-92ff-de0c093fc19c
1 parent 65e591c commit 60f311d

File tree

5 files changed

+16
-10
lines changed

5 files changed

+16
-10
lines changed

cmake/FindPyQt4.cmake

+9-3
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@
2222
#
2323
# PYQT4_SIP_FLAGS - The SIP flags used to build PyQt.
2424

25-
IF(EXISTS PYQT4_VERSION)
25+
IF(EXISTS PYQT4_VERSION_STR)
2626
# Already in cache, be silent
2727
SET(PYQT4_FOUND TRUE)
28-
ELSE(EXISTS PYQT4_VERSION)
28+
ELSE(EXISTS PYQT4_VERSION_STR)
2929

3030
FIND_FILE(_find_pyqt_py FindPyQt.py PATHS ${CMAKE_MODULE_PATH})
3131

@@ -50,4 +50,10 @@ ELSE(EXISTS PYQT4_VERSION)
5050
ENDIF(PYQT4_FIND_REQUIRED)
5151
ENDIF(PYQT4_FOUND)
5252

53-
ENDIF(EXISTS PYQT4_VERSION)
53+
ENDIF(EXISTS PYQT4_VERSION_STR)
54+
55+
STRING(REGEX REPLACE "^([0-9]*)\\.[0-9]*\\.[0-9]*$" "\\1" PYQT4_MAJOR_VERSION ${PYQT4_VERSION_STR})
56+
STRING(REGEX REPLACE "^[0-9]*\\.([0-9]*)\\.[0-9]*$" "\\1" PYQT4_MINOR_VERSION ${PYQT4_VERSION_STR})
57+
STRING(REGEX REPLACE "^[0-9]*\\.[0-9]*\\.([0-9]*)$" "\\1" PYQT4_PATCH_VERSION ${PYQT4_VERSION_STR})
58+
MATH( EXPR PYQT4_NUM_VERSION "${PYQT4_MAJOR_VERSION}*10000 + ${PYQT4_MINOR_VERSION}*100 + ${PYQT4_PATCH_VERSION}")
59+

debian/changelog

+3-3
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,15 @@ qgis (1.5.0) UNRELEASED; urgency=low
22

33
* new development version after 1.5 branch
44
* adapted Francesco Paolo Lovergine's updates to Debian qgis 1.4 package
5-
* require CMake >2.6 and Qt 4.4 for sid
5+
* require CMake >2.6 and Qt 4.4
66
* remove circular dependencies
77
* integrate new GRASS raster provider and remove dependency to
88
libgdal1-$VERSION-grass
99
* add spatialquery plugin
1010
* include qgis.g.browser in grass plugin
11-
* drop symbol tracking, C++ ABIs change too frequently
11+
* drop symbol tracking as C++ ABIs change too frequently
1212

13-
-- Jürgen E. Fischer <jef@norbit.de> Sat, 08 May 2010 13:26:13 +0200
13+
-- Jürgen E. Fischer <jef@norbit.de> Thu, 13 May 2010 10:54:06 +0200
1414

1515
qgis (1.4.0) UNRELEASED; urgency=low
1616

debian/control

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ Section: science
33
Priority: extra
44
Maintainer: Quantum GIS developers <qgis-developer@lists.osgeo.org>
55
Build-Depends: debhelper (>= 7), libgdal1-dev, libpq-dev,
6-
libgeos-dev (>= 3.0.0), grass-dev, libsqlite3-dev, libgsl0-dev, libproj-dev, libexpat1-dev,
6+
libgeos-dev (>= 3.0.0), grass-dev, libsqlite3-dev, libgsl0-dev, proj (< 4.7.0) | libproj-dev (>= 4.7.0), libexpat1-dev,
77
flex, bison, python-dev, cmake (>= 2.6), python-sip4 (>= 4.5.0), python-central (>=0.5), python,
88
sharutils, sip4 (>= 4.5), libqt4-core (>=4.4.0), libqt4-dev (>=4.4.0), libqt4-gui (>=4.4.0),
99
libqt4-sql (>=4.4.0), python-qt4 (>=4.1.0), python-qt4-dev (>=4.1.0),

python/CMakeLists.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@ IF(MSVC)
3535
ADD_DEFINITIONS(-DNOMINMAX)
3636
ENDIF(MSVC)
3737

38-
IF(${PYQT4_VERSION_STR} VERSION_LESS "4.6.0")
38+
IF(${PYQT4_NUM_VERSION} LESS 40600)
3939
SET(SIP_DISABLE_FEATURES ${SIP_DISABLE_FEATURES} PROXY_FACTORY)
40-
ENDIF(${PYQT4_VERSION_STR} VERSION_LESS "4.6.0")
40+
ENDIF(${PYQT4_NUM_VERSION} LESS 40600)
4141

4242
# core module
4343
FILE(GLOB sip_files_core core/*.sip)

src/core/symbology-ng/qgsmarkersymbollayerv2.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -342,7 +342,7 @@ void QgsSimpleMarkerSymbolLayerV2::renderPoint( const QPointF& point, QgsSymbolV
342342
{
343343
QMatrix transform;
344344

345-
bool hasDataDefinedRotation = context.renderHints() & QgsSymbolV2::DataDefinedRotation;
345+
// bool hasDataDefinedRotation = context.renderHints() & QgsSymbolV2::DataDefinedRotation;
346346
bool hasDataDefinedSize = context.renderHints() & QgsSymbolV2::DataDefinedSizeScale;
347347

348348
// move to the desired position

0 commit comments

Comments
 (0)