Remove last use of QgsSizeScaleWidget

qgis · Feb 14, 2017 · 613ef634a5cac8d7f43e7e70c1dec703a9435238 · 613ef63
1 parent 8567719
commit 613ef634a5cac8d7f43e7e70c1dec703a9435238
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 12 deletions.
diff --git a/src/gui/symbology-ng/qgsrendererwidget.cpp b/src/gui/symbology-ng/qgsrendererwidget.cpp
@@ -292,14 +292,6 @@ QgsDataDefinedValueDialog::QgsDataDefinedValueDialog( const QList<QgsSymbol*>& s
 void QgsDataDefinedValueDialog::setContext( const QgsSymbolWidgetContext& context )
 {
   mContext = context;
-#if 0
-  Q_FOREACH ( QgsPropertyOverrideButton* ddButton, findChildren<QgsPropertyOverrideButton*>() )
-  {
-
-    if ( ddButton->assistant() )
-      ddButton->assistant()->setMapCanvas( context.mapCanvas() );
-  }
-#endif
 }
 
 QgsSymbolWidgetContext QgsDataDefinedValueDialog::context() const

diff --git a/src/gui/symbology-ng/qgsrendererwidget.h b/src/gui/symbology-ng/qgsrendererwidget.h
@@ -137,7 +137,6 @@ class QgsField;
 class QgsFields;
 
 #include "ui_widget_set_dd_value.h"
-#include "qgssizescalewidget.h"
 #include "qgis_gui.h"
 
 /** \ingroup gui
@@ -212,10 +211,11 @@ class GUI_EXPORT QgsDataDefinedSizeDialog : public QgsDataDefinedValueDialog
         : QgsDataDefinedValueDialog( symbolList, layer, tr( "Size" ) )
     {
       init( QgsSymbolLayer::PropertySize );
-#if 0
       if ( !symbolList.isEmpty() && symbolList.at( 0 ) && vectorLayer() )
-        mDDBtn->setAssistant( tr( "Size Assistant..." ), new QgsSizeScaleWidget( vectorLayer(), static_cast<const QgsMarkerSymbol*>( symbolList.at( 0 ) ) ) );
-#endif
+      {
+        mAssistantSymbol.reset( static_cast<const QgsMarkerSymbol*>( symbolList.at( 0 ) )->clone() );
+        mDDBtn->setSymbol( mAssistantSymbol );
+      }
     }
 
   protected:
@@ -224,6 +224,10 @@ class GUI_EXPORT QgsDataDefinedSizeDialog : public QgsDataDefinedValueDialog
     double value( const QgsSymbol * symbol ) const override { return static_cast<const QgsMarkerSymbol*>( symbol )->size(); }
 
     void setDataDefined( QgsSymbol* symbol, const QgsProperty& dd ) override;
+
+  private:
+
+    std::shared_ptr< QgsMarkerSymbol > mAssistantSymbol;
 };
 
 /** \ingroup gui