-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Disable QgsTaskManager::waitForFinished test by default
The test intermittently fails on Travis builds, likely due to the platform's inconsistent availability to multiple threads.
- Loading branch information
1 parent
176b7ca
commit 632a2be
Showing
1 changed file
with
13 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
632a2be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is actually a race condition somewhere, that I couldn't pin down yet. I just hope it's in the test and not the
waitForFinished()
code.632a2be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I reenable? I just know that many other tests which rely on multiple threads are flaky on Travis. e.g. there's others in the task manager test suite which i've had to disable, and https://github.com/qgis/QGIS/blob/master/tests/src/python/test_qgslocator.py
None of these I can get to fail locally, despite everything I throw at it. Same with the waitForFinished test.
632a2be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would only re-enable once additional debug output has been added to investigate the issue.
I don't have any lead yet. But I have a bad feeling with putting them aside as "travis issues" and fear that deadlocks sit waiting somewhere to surface when they are least expected...
632a2be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me too! But it was failing quite a lot, and was at the level where we've previously disabled whole tests. I'd rather ifdef out a single test then the whole set of task manager tests....
632a2be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you write a note on the mailing list? :P
Seriously, I was just about to disable it myself