[bugfix] Bookmrks fix crash on exit when docked

Order of destruction does matter

Fixes #17673

Author: elpaso

src/app/qgsbookmarks.cpp

@@ -107,7 +107,7 @@ QgsBookmarks::QgsBookmarks( QWidget *parent )
   mProjectModel = new QgsProjectBookmarksTableModel( this );
   mMergedModel = new QgsMergedBookmarksTableModel( *mQgisModel, *mProjectModel, lstBookmarks, this );
 
-  mProxyModel = new QgsBookmarksProxyModel( this );
+  mProxyModel = new QgsBookmarksProxyModel( );
   mProxyModel->setSourceModel( mMergedModel );
   mProxyModel->setSortCaseSensitivity( Qt::CaseInsensitive );
 
@@ -136,6 +136,7 @@ QgsBookmarks::QgsBookmarks( QWidget *parent )
 QgsBookmarks::~QgsBookmarks()
 {
   delete mQgisModel;
+  delete mProxyModel;
   QSqlDatabase::removeDatabase( QStringLiteral( "bookmarks" ) );
   saveWindowLocation();
 }