backport: fix invalid list index in identify results causing wrong result or segfault accessing actions from context menu

Author: brushtyler

src/app/qgsidentifyresults.cpp

@@ -457,6 +457,8 @@ void QgsIdentifyResults::contextMenuEvent( QContextMenuEvent* event )
   {
     mActionPopup->addSeparator();
 
+    int featIdx = featItem->data( 0, Qt::UserRole + 1 ).toInt();
+
     // The assumption is made that an instance of QgsIdentifyResults is
     // created for each new Identify Results dialog box, and that the
     // contents of the popup menu doesn't change during the time that
@@ -468,8 +470,7 @@ void QgsIdentifyResults::contextMenuEvent( QContextMenuEvent* event )
       if ( !action.runable() )
         continue;
 
-      int idx = featItem->data( 0, Qt::UserRole + 1 ).toInt();
-      QgsFeatureAction *a = new QgsFeatureAction( action.name(), mFeatures[ idx ], vlayer, i, idx, this );
+      QgsFeatureAction *a = new QgsFeatureAction( action.name(), mFeatures[ featIdx ], vlayer, i, idx, this );
       mActionPopup->addAction( QgisApp::getThemeIcon( "/mAction.png" ), action.name(), a, SLOT( execute() ) );
     }
   }