Skip to content
Permalink
Browse files

use 443 (HTTPS) port when testing help URLs

  • Loading branch information
alexbruy committed Dec 11, 2017
1 parent 1c6ba55 commit 678758c9baf6db386aff205301c037c67b5247e9
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/gui/qgshelp.cpp
@@ -152,7 +152,7 @@ bool QgsHelp::urlExists( const QString &url )
socket.setProxy( proxy );
}

socket.connectToHost( helpUrl.host(), 80 );
socket.connectToHost( helpUrl.host(), 443 );
if ( socket.waitForConnected() )
{
socket.write( "HEAD " + helpUrl.path().toUtf8() + " HTTP/1.1\r\n"

1 comment on commit 678758c

@rduivenvoorde

This comment has been minimized.

Copy link
Contributor

@rduivenvoorde rduivenvoorde commented on 678758c Dec 12, 2017

@alexbruy I know this was one of my own suggestions, but... this does not work.
you will never open the right page.

Apparently connecting to a 443 socket without any ssl stuff just returns a bad request:

"<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>400 Bad Request</title>
</hea..."

So maybe it is better to keep the http url and port 80, then redirection should do the work
We could use the httpS url and port 80 too, but that is a little unclear.

OR forget this whole test, and do the 'nothing found' magic somewhere in the website.

I was thinking about pointing to the search page of the (english?) version:
https://docs.qgis.org/testing/en/search.html

Please sign in to comment.
You can’t perform that action at this time.