Merge pull request #2510 from SebDieBln/FixDeleteCategories

m-kuhn · m-kuhn · commit 6aabb8561b48 · 2015-11-29T16:25:22.000+01:00
Fix a bug when deleting style categories (fixes #12043)
diff --git a/src/gui/symbology-ng/qgscategorizedsymbolrendererv2widget.cpp b/src/gui/symbology-ng/qgscategorizedsymbolrendererv2widget.cpp
@@ -309,6 +309,7 @@ bool QgsCategorizedSymbolRendererV2Model::dropMimeData( const QMimeData *data, Q
 
 void QgsCategorizedSymbolRendererV2Model::deleteRows( QList<int> rows )
 {
+  qSort( rows ); // list might be unsorted, depending on how the user selected the rows
   for ( int i = rows.size() - 1; i >= 0; i-- )
   {
     beginRemoveRows( QModelIndex(), rows[i], rows[i] );

Original file line number	Diff line number	Diff line change
`@@ -309,6 +309,7 @@ bool QgsCategorizedSymbolRendererV2Model::dropMimeData( const QMimeData *data, Q`
`309`	`309`
`310`	`310`	`void QgsCategorizedSymbolRendererV2Model::deleteRows( QList<int> rows )`
`311`	`311`	`{`
	`312`	`+ qSort( rows ); // list might be unsorted, depending on how the user selected the rows`
`312`	`313`	`for ( int i = rows.size() - 1; i >= 0; i-- )`
`313`	`314`	`{`
`314`	`315`	`beginRemoveRows( QModelIndex(), rows[i], rows[i] );`