Skip to content
Permalink
Browse files

Fix clang-tidy redundant .get() calls

  • Loading branch information
nyalldawson committed Sep 11, 2017
1 parent f2875a9 commit 6ca50a023ea5c54661ff0855ab15568bed40ee19
@@ -290,7 +290,7 @@ bool QgsExpression::needsGeometry() const

void QgsExpression::initGeomCalculator()
{
if ( d->mCalc.get() )
if ( d->mCalc )
return;

// Use planimetric as default
@@ -795,6 +795,6 @@ void QgsDataDefinedSizeLegendNode::cacheImage() const
context.reset( new QgsRenderContext );
context->setScaleFactor( 96 / 25.4 );
}
mImage = mSettings->collapsedLegendImage( *context.get() );
mImage = mSettings->collapsedLegendImage( *context );
}
}
@@ -1560,7 +1560,7 @@ QString QgsFilledMarkerSymbolLayer::layerType() const

void QgsFilledMarkerSymbolLayer::startRender( QgsSymbolRenderContext &context )
{
if ( mFill.get() )
if ( mFill )
{
mFill->startRender( context.renderContext(), context.fields() );
}
@@ -1570,7 +1570,7 @@ void QgsFilledMarkerSymbolLayer::startRender( QgsSymbolRenderContext &context )

void QgsFilledMarkerSymbolLayer::stopRender( QgsSymbolRenderContext &context )
{
if ( mFill.get() )
if ( mFill )
{
mFill->stopRender( context.renderContext() );
}
@@ -68,7 +68,7 @@ void QgsNullSymbolRenderer::startRender( QgsRenderContext &context, const QgsFie

void QgsNullSymbolRenderer::stopRender( QgsRenderContext &context )
{
if ( mSymbol.get() )
if ( mSymbol )
{
mSymbol->stopRender( context );
}
@@ -30,7 +30,7 @@ QgsGeoPackageRasterWriterTask::QgsGeoPackageRasterWriterTask( const QgsMimeDataU
void QgsGeoPackageRasterWriterTask::cancel()
{
mError = QgsGeoPackageRasterWriter::WriterError::ErrUserCanceled;
mFeedback.get()->cancel();
mFeedback->cancel();
}

bool QgsGeoPackageRasterWriterTask::run()

0 comments on commit 6ca50a0

Please sign in to comment.
You can’t perform that action at this time.