Skip to content

Commit 731c1b8

Browse files
author
jef
committed
indentation update
git-svn-id: http://svn.osgeo.org/qgis/trunk/qgis@10872 c8812cc2-4d05-0410-92ff-de0c093fc19c
1 parent 25fbf84 commit 731c1b8

File tree

3 files changed

+132
-132
lines changed

3 files changed

+132
-132
lines changed

src/core/composer/qgscomposeritem.cpp

+68-68
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
#define FONT_WORKAROUND_SCALE 10 //scale factor for upscaling fontsize and downscaling painter
3535

3636
QgsComposerItem::QgsComposerItem( QgsComposition* composition, bool manageZValue ): QGraphicsRectItem( 0 ), mComposition( composition ), mBoundingResizeRectangle( 0 ), \
37-
mFrame( true ), mItemPositionLocked(false)
37+
mFrame( true ), mItemPositionLocked( false )
3838
{
3939
setFlag( QGraphicsItem::ItemIsSelectable, true );
4040
setAcceptsHoverEvents( true );
@@ -125,13 +125,13 @@ bool QgsComposerItem::_writeXML( QDomElement& itemElem, QDomDocument& doc ) cons
125125
composerItemElem.setAttribute( "outlineWidth", QString::number( pen().widthF() ) );
126126

127127
//position lock for mouse moves/resizes
128-
if(mItemPositionLocked)
128+
if ( mItemPositionLocked )
129129
{
130-
composerItemElem.setAttribute( "positionLock", "true");
130+
composerItemElem.setAttribute( "positionLock", "true" );
131131
}
132132
else
133133
{
134-
composerItemElem.setAttribute( "positionLock", "false");
134+
composerItemElem.setAttribute( "positionLock", "false" );
135135
}
136136

137137

@@ -177,14 +177,14 @@ bool QgsComposerItem::_readXML( const QDomElement& itemElem, const QDomDocument&
177177
}
178178

179179
//position lock for mouse moves/resizes
180-
QString positionLock = itemElem.attribute("positionLock");
181-
if(positionLock.compare("true", Qt::CaseInsensitive) == 0)
180+
QString positionLock = itemElem.attribute( "positionLock" );
181+
if ( positionLock.compare( "true", Qt::CaseInsensitive ) == 0 )
182182
{
183-
mItemPositionLocked = true;
183+
mItemPositionLocked = true;
184184
}
185185
else
186186
{
187-
mItemPositionLocked = false;
187+
mItemPositionLocked = false;
188188
}
189189

190190
//position
@@ -246,10 +246,10 @@ bool QgsComposerItem::_readXML( const QDomElement& itemElem, const QDomDocument&
246246

247247
void QgsComposerItem::mouseMoveEvent( QGraphicsSceneMouseEvent * event )
248248
{
249-
if(mItemPositionLocked)
250-
{
251-
return;
252-
}
249+
if ( mItemPositionLocked )
250+
{
251+
return;
252+
}
253253

254254
if ( mBoundingResizeRectangle )
255255
{
@@ -263,10 +263,10 @@ void QgsComposerItem::mouseMoveEvent( QGraphicsSceneMouseEvent * event )
263263

264264
void QgsComposerItem::mousePressEvent( QGraphicsSceneMouseEvent * event )
265265
{
266-
if(mItemPositionLocked)
267-
{
268-
return;
269-
}
266+
if ( mItemPositionLocked )
267+
{
268+
return;
269+
}
270270

271271
//set current position and type of mouse move action
272272
mMouseMoveStartPos = event->lastScenePos();
@@ -297,10 +297,10 @@ void QgsComposerItem::mousePressEvent( QGraphicsSceneMouseEvent * event )
297297
void QgsComposerItem::mouseReleaseEvent( QGraphicsSceneMouseEvent * event )
298298
{
299299

300-
if(mItemPositionLocked)
301-
{
302-
return;
303-
}
300+
if ( mItemPositionLocked )
301+
{
302+
return;
303+
}
304304

305305
//delete frame rectangle
306306
if ( mBoundingResizeRectangle )
@@ -331,9 +331,9 @@ Qt::CursorShape QgsComposerItem::cursorForPosition( const QPointF& itemCoordPos
331331
{
332332
QgsComposerItem::MouseMoveAction mouseAction = mouseMoveActionForPosition( itemCoordPos );
333333

334-
if( mouseAction == QgsComposerItem::NoAction)
334+
if ( mouseAction == QgsComposerItem::NoAction )
335335
{
336-
return Qt::ForbiddenCursor;
336+
return Qt::ForbiddenCursor;
337337
}
338338
if ( mouseAction == QgsComposerItem::MoveItem )
339339
{
@@ -361,9 +361,9 @@ QgsComposerItem::MouseMoveAction QgsComposerItem::mouseMoveActionForPosition( co
361361
{
362362

363363
//no action at all if item position is locked for mouse
364-
if(mItemPositionLocked)
364+
if ( mItemPositionLocked )
365365
{
366-
return QgsComposerItem::NoAction;
366+
return QgsComposerItem::NoAction;
367367
}
368368

369369
bool nearLeftBorder = false;
@@ -434,7 +434,7 @@ void QgsComposerItem::changeItemRectangle( const QPointF& currentPosition, const
434434
}
435435

436436
//test if change item is a composer item. If so, prefer call to setSceneRect() instead of setTransform() and setRect()
437-
QgsComposerItem* changeComposerItem = dynamic_cast<QgsComposerItem*>(changeItem);
437+
QgsComposerItem* changeComposerItem = dynamic_cast<QgsComposerItem*>( changeItem );
438438

439439
double mx = 0.0, my = 0.0, rx = 0.0, ry = 0.0;
440440
QPointF snappedPosition = mComposition->snapPointToGrid( currentPosition );
@@ -504,22 +504,22 @@ void QgsComposerItem::changeItemRectangle( const QPointF& currentPosition, const
504504
double moveRectX = snappedLeftPoint.x() - originalItem->transform().dx();
505505
double moveRectY = snappedLeftPoint.y() - originalItem->transform().dy();
506506

507-
if(!changeComposerItem)
507+
if ( !changeComposerItem )
508508
{
509509
QTransform moveTransform;
510510
moveTransform.translate( originalItem->transform().dx() + moveRectX, originalItem->transform().dy() + moveRectY );
511511
changeItem->setTransform( moveTransform );
512512
}
513513
else //for composer items, we prefer setSceneRect as subclasses can implement custom behaviour (e.g. item group)
514514
{
515-
changeComposerItem->setSceneRect(QRectF(originalItem->transform().dx() + moveRectX, \
516-
originalItem->transform().dy() + moveRectY, \
517-
originalItem->rect().width(), originalItem->rect().height()));
515+
changeComposerItem->setSceneRect( QRectF( originalItem->transform().dx() + moveRectX, \
516+
originalItem->transform().dy() + moveRectY, \
517+
originalItem->rect().width(), originalItem->rect().height() ) );
518518
}
519519
return;
520520
}
521521

522-
if(!changeComposerItem)
522+
if ( !changeComposerItem )
523523
{
524524
QTransform itemTransform;
525525
itemTransform.translate( originalItem->transform().dx() + mx, originalItem->transform().dy() + my );
@@ -529,8 +529,8 @@ void QgsComposerItem::changeItemRectangle( const QPointF& currentPosition, const
529529
}
530530
else //for composer items, we prefer setSceneRect as subclasses can implement custom behaviour (e.g. item group)
531531
{
532-
changeComposerItem->setSceneRect( QRectF(originalItem->transform().dx() + mx, originalItem->transform().dy() + my, \
533-
originalItem->rect().width() + rx, originalItem->rect().height() + ry) );
532+
changeComposerItem->setSceneRect( QRectF( originalItem->transform().dx() + mx, originalItem->transform().dy() + my, \
533+
originalItem->rect().width() + rx, originalItem->rect().height() + ry ) );
534534
}
535535
}
536536

@@ -548,29 +548,29 @@ void QgsComposerItem::drawSelectionBoxes( QPainter* p )
548548
double rectHandlerSize = rectHandlerBorderTolerance();
549549
double sizeLockSymbol = lockSymbolSize();
550550

551-
if(mItemPositionLocked)
551+
if ( mItemPositionLocked )
552552
{
553-
//draw lock symbol at upper left edge. Use QImage to be independant of the graphic system
554-
QString lockIconPath = QgsApplication::activeThemePath() + "/mIconLock.png";
555-
if(!QFile::exists(lockIconPath))
556-
{
557-
lockIconPath = QgsApplication::defaultThemePath() + "/mIconLock.png";
558-
}
559-
560-
QImage lockImage(lockIconPath);
561-
if(!lockImage.isNull())
562-
{
563-
p->drawImage(QRectF(0, 0, sizeLockSymbol, sizeLockSymbol), lockImage, QRectF(0, 0, lockImage.width(), lockImage.height()));
564-
}
553+
//draw lock symbol at upper left edge. Use QImage to be independant of the graphic system
554+
QString lockIconPath = QgsApplication::activeThemePath() + "/mIconLock.png";
555+
if ( !QFile::exists( lockIconPath ) )
556+
{
557+
lockIconPath = QgsApplication::defaultThemePath() + "/mIconLock.png";
558+
}
559+
560+
QImage lockImage( lockIconPath );
561+
if ( !lockImage.isNull() )
562+
{
563+
p->drawImage( QRectF( 0, 0, sizeLockSymbol, sizeLockSymbol ), lockImage, QRectF( 0, 0, lockImage.width(), lockImage.height() ) );
564+
}
565565
}
566566
else //draw blue squares
567567
{
568-
p->setPen( QPen( QColor( 0, 0, 255 ) ) );
569-
p->setBrush( QBrush( QColor( 0, 0, 255 ) ) );
570-
p->drawRect( QRectF( 0, 0, rectHandlerSize, rectHandlerSize ) );
571-
p->drawRect( QRectF( rect().width() - rectHandlerSize, 0, rectHandlerSize, rectHandlerSize ) );
572-
p->drawRect( QRectF( rect().width() - rectHandlerSize, rect().height() - rectHandlerSize, rectHandlerSize, rectHandlerSize ) );
573-
p->drawRect( QRectF( 0, rect().height() - rectHandlerSize, rectHandlerSize, rectHandlerSize ) );
568+
p->setPen( QPen( QColor( 0, 0, 255 ) ) );
569+
p->setBrush( QBrush( QColor( 0, 0, 255 ) ) );
570+
p->drawRect( QRectF( 0, 0, rectHandlerSize, rectHandlerSize ) );
571+
p->drawRect( QRectF( rect().width() - rectHandlerSize, 0, rectHandlerSize, rectHandlerSize ) );
572+
p->drawRect( QRectF( rect().width() - rectHandlerSize, rect().height() - rectHandlerSize, rectHandlerSize, rectHandlerSize ) );
573+
p->drawRect( QRectF( 0, rect().height() - rectHandlerSize, rectHandlerSize, rectHandlerSize ) );
574574
}
575575
}
576576
}
@@ -749,38 +749,38 @@ double QgsComposerItem::horizontalViewScaleFactor() const
749749

750750
double QgsComposerItem::rectHandlerBorderTolerance() const
751751
{
752-
//size of symbol boxes depends on zoom level in composer view
753-
double viewScaleFactor = horizontalViewScaleFactor();
754-
double rectHandlerSize = 10.0 / viewScaleFactor;
752+
//size of symbol boxes depends on zoom level in composer view
753+
double viewScaleFactor = horizontalViewScaleFactor();
754+
double rectHandlerSize = 10.0 / viewScaleFactor;
755755

756-
//make sure the boxes don't get too large
757-
if(rectHandlerSize > (rect().width() / 3))
758-
{
759-
rectHandlerSize = rect().width() / 3;
760-
}
761-
if(rectHandlerSize > (rect().height() / 3))
762-
{
763-
rectHandlerSize = rect().height() / 3;
764-
}
765-
return rectHandlerSize;
756+
//make sure the boxes don't get too large
757+
if ( rectHandlerSize > ( rect().width() / 3 ) )
758+
{
759+
rectHandlerSize = rect().width() / 3;
760+
}
761+
if ( rectHandlerSize > ( rect().height() / 3 ) )
762+
{
763+
rectHandlerSize = rect().height() / 3;
764+
}
765+
return rectHandlerSize;
766766
}
767767

768768
double QgsComposerItem::lockSymbolSize() const
769769
{
770770
double lockSymbolSize = 20.0 / horizontalViewScaleFactor();
771771

772-
if(lockSymbolSize > (rect().width() / 3))
772+
if ( lockSymbolSize > ( rect().width() / 3 ) )
773773
{
774774
lockSymbolSize = rect().width() / 3;
775775
}
776-
if(lockSymbolSize > (rect().height() / 3))
776+
if ( lockSymbolSize > ( rect().height() / 3 ) )
777777
{
778778
lockSymbolSize = rect().height() / 3;
779779
}
780780
return lockSymbolSize;
781781
}
782782

783-
void QgsComposerItem::updateCursor(const QPointF& itemPos)
783+
void QgsComposerItem::updateCursor( const QPointF& itemPos )
784784
{
785-
setCursor( cursorForPosition(itemPos) );
785+
setCursor( cursorForPosition( itemPos ) );
786786
}

src/gui/qgscomposerview.cpp

+48-48
Original file line numberDiff line numberDiff line change
@@ -46,19 +46,19 @@ void QgsComposerView::mousePressEvent( QMouseEvent* e )
4646
QPointF snappedScenePoint = composition()->snapPointToGrid( scenePoint );
4747

4848
//lock/unlock position of item with right click
49-
if(e->button() == Qt::RightButton)
49+
if ( e->button() == Qt::RightButton )
5050
{
51-
QgsComposerItem* selectedItem = composition()->composerItemAt( scenePoint );
52-
if(selectedItem)
53-
{
54-
bool lock = selectedItem->positionLock() ? false : true;
55-
selectedItem->setPositionLock(lock);
56-
selectedItem->update();
57-
//make sure the new cursor is correct
58-
QPointF itemPoint = selectedItem->mapFromScene( scenePoint );
59-
selectedItem->updateCursor(itemPoint);
60-
}
61-
return;
51+
QgsComposerItem* selectedItem = composition()->composerItemAt( scenePoint );
52+
if ( selectedItem )
53+
{
54+
bool lock = selectedItem->positionLock() ? false : true;
55+
selectedItem->setPositionLock( lock );
56+
selectedItem->update();
57+
//make sure the new cursor is correct
58+
QPointF itemPoint = selectedItem->mapFromScene( scenePoint );
59+
selectedItem->updateCursor( itemPoint );
60+
}
61+
return;
6262
}
6363

6464
switch ( mCurrentTool )
@@ -101,7 +101,7 @@ void QgsComposerView::mousePressEvent( QMouseEvent* e )
101101
{
102102
QTransform t;
103103
mRubberBandItem = new QGraphicsRectItem( 0, 0, 0, 0 );
104-
mRubberBandStartPos = QPointF(snappedScenePoint.x(), snappedScenePoint.y());
104+
mRubberBandStartPos = QPointF( snappedScenePoint.x(), snappedScenePoint.y() );
105105
t.translate( snappedScenePoint.x(), snappedScenePoint.y() );
106106
mRubberBandItem->setTransform( t );
107107
mRubberBandItem->setZValue( 100 );
@@ -236,44 +236,44 @@ void QgsComposerView::mouseMoveEvent( QMouseEvent* e )
236236

237237
case AddMap:
238238
//adjust rubber band item
239+
{
240+
double x = 0;
241+
double y = 0;
242+
double width = 0;
243+
double height = 0;
244+
245+
double dx = scenePoint.x() - mRubberBandStartPos.x();
246+
double dy = scenePoint.y() - mRubberBandStartPos.y();
247+
248+
if ( dx < 0 )
249+
{
250+
x = scenePoint.x();
251+
width = -dx;
252+
}
253+
else
239254
{
240-
double x = 0;
241-
double y = 0;
242-
double width = 0;
243-
double height = 0;
244-
245-
double dx = scenePoint.x() - mRubberBandStartPos.x();
246-
double dy = scenePoint.y() - mRubberBandStartPos.y();
247-
248-
if(dx < 0)
249-
{
250-
x = scenePoint.x();
251-
width = -dx;
252-
}
253-
else
254-
{
255-
x = mRubberBandStartPos.x();
256-
width = dx;
257-
}
258-
259-
if(dy < 0)
260-
{
261-
y = scenePoint.y();
262-
height = -dy;
263-
}
264-
else
265-
{
266-
y = mRubberBandStartPos.y();
267-
height = dy;
268-
}
269-
270-
mRubberBandItem->setRect( 0, 0, width, height );
271-
QTransform t;
272-
t.translate(x, y);
273-
mRubberBandItem->setTransform(t);
274-
break;
255+
x = mRubberBandStartPos.x();
256+
width = dx;
275257
}
276258

259+
if ( dy < 0 )
260+
{
261+
y = scenePoint.y();
262+
height = -dy;
263+
}
264+
else
265+
{
266+
y = mRubberBandStartPos.y();
267+
height = dy;
268+
}
269+
270+
mRubberBandItem->setRect( 0, 0, width, height );
271+
QTransform t;
272+
t.translate( x, y );
273+
mRubberBandItem->setTransform( t );
274+
break;
275+
}
276+
277277
case MoveItemContent:
278278
{
279279
//update map preview if composer map

0 commit comments

Comments
 (0)