Merge pull request #3663 from nyalldawson/clazy3

Clazy qt5 optimisations - round 2

python/analysis/vector/qgszonalstatistics.sip

@@ -31,7 +31,7 @@ class QgsZonalStatistics
     typedef QFlags<QgsZonalStatistics::Statistic> Statistics;
 
     QgsZonalStatistics( QgsVectorLayer* polygonLayer, const QString& rasterFile, const QString& attributePrefix = "", int rasterBand = 1,
-                        const QgsZonalStatistics::Statistics& stats = QgsZonalStatistics::Statistics( QgsZonalStatistics::Count | QgsZonalStatistics::Sum | QgsZonalStatistics::Mean) );
+                        QgsZonalStatistics::Statistics stats = QgsZonalStatistics::Statistics( QgsZonalStatistics::Count | QgsZonalStatistics::Sum | QgsZonalStatistics::Mean) );
 
     /** Starts the calculation
       @return 0 in case of success*/

python/core/auth/qgsauthmethod.sip

@@ -105,7 +105,7 @@ class QgsAuthMethod : QObject
     void setVersion( int version );
 
     /** Set the support expansions (points in providers where the authentication is injected) of the auth method */
-    void setExpansions( const QgsAuthMethod::Expansions& expansions );
+    void setExpansions( QgsAuthMethod::Expansions expansions );
     /** Set list of data providers this auth method supports */
     void setDataProviders( const QStringList& dataproviders );
 };

python/core/composer/qgscomposermapgrid.sip

@@ -684,7 +684,7 @@ class QgsComposerMapGrid : QgsComposerMapItem
      * @see frameSideFlags
      * @see testFrameSideFlag
      */
-    void setFrameSideFlags( const FrameSideFlags& flags );
+    void setFrameSideFlags( FrameSideFlags flags );
 
     /** Sets whether the grid frame is drawn for a certain side of the map item.
      * @param flag flag for grid frame side

python/core/composer/qgscomposernodesitem.sip

@@ -5,8 +5,8 @@ class QgsComposerNodesItem: QgsComposerItem
 %End
   public:
 
-    QgsComposerNodesItem( QString mTagName, QgsComposition* c );
-    QgsComposerNodesItem( QString mTagName, QPolygonF polygon, QgsComposition* c );
+    QgsComposerNodesItem( const QString& mTagName, QgsComposition* c );
+    QgsComposerNodesItem( const QString& mTagName, const QPolygonF& polygon, QgsComposition* c );
     ~QgsComposerNodesItem();
 
     /** Add a node in current shape.
@@ -16,7 +16,7 @@ class QgsComposerNodesItem: QgsComposerItem
      * true. Typically, if this flag is true, the new node has to be nearest
      * than radius to the shape to be added.
      */
-    bool addNode( const QPointF &pt, const bool checkArea = true, const double radius = 10 );
+    bool addNode( QPointF pt, const bool checkArea = true, const double radius = 10 );
 
     /** Set a tag to indicate if we want to draw or not the shape's nodes.
      * @param display
@@ -27,7 +27,7 @@ class QgsComposerNodesItem: QgsComposerItem
      * @param index the index of the node to move
      * @param node is the new position in scene coordinate
      */
-    bool moveNode( const int index, const QPointF &node );
+    bool moveNode( const int index, QPointF node );
 
     /** \brief Reimplementation of QCanvasItem::paint - draw on canvas */
     void paint( QPainter* painter, const QStyleOptionGraphicsItem* itemStyle, QWidget* pWidget );
@@ -85,7 +85,7 @@ class QgsComposerNodesItem: QgsComposerItem
   protected:
 
     /** Method called in addNode. */
-    virtual bool _addNode( const int nodeIndex, const QPointF &newPoint, const double radius ) = 0;
+    virtual bool _addNode( const int nodeIndex, QPointF newPoint, const double radius ) = 0;
 
     /** Method called in removeNode. */
     virtual bool _removeNode( const int nodeIndex ) = 0;
@@ -104,7 +104,7 @@ class QgsComposerNodesItem: QgsComposerItem
     void rescaleToFitBoundingBox();
 
     /** Compute an euclidian distance between 2 nodes. */
-    double computeDistance(const QPointF &pt1, const QPointF &pt2) const;
+    double computeDistance( QPointF pt1, QPointF pt2) const;
 
     /** Update the current scene rectangle for this item. */
     void updateSceneRect();

python/core/composer/qgscomposerpolygon.sip

@@ -6,7 +6,7 @@ class QgsComposerPolygon: QgsComposerNodesItem
   public:
 
     QgsComposerPolygon( QgsComposition* c );
-    QgsComposerPolygon( QPolygonF polygon, QgsComposition* c );
+    QgsComposerPolygon( const QPolygonF& polygon, QgsComposition* c );
     ~QgsComposerPolygon();
 
     /** Overridden to return shape name */
@@ -23,7 +23,7 @@ class QgsComposerPolygon: QgsComposerNodesItem
 
   protected:
 
-    bool _addNode( const int indexPoint, const QPointF &newPoint, const double radius );
+    bool _addNode( const int indexPoint, QPointF newPoint, const double radius );
 
     bool _removeNode( const int indexPoint );
 

python/core/composer/qgscomposerpolyline.sip

@@ -6,7 +6,7 @@ class QgsComposerPolyline: QgsComposerNodesItem
   public:
 
     QgsComposerPolyline( QgsComposition* c );
-    QgsComposerPolyline( QPolygonF polyline, QgsComposition* c );
+    QgsComposerPolyline( const QPolygonF& polyline, QgsComposition* c );
     ~QgsComposerPolyline();
 
     /** Overridden to return shape name */
@@ -23,7 +23,7 @@ class QgsComposerPolyline: QgsComposerNodesItem
 
   protected:
 
-    bool _addNode( const int indexPoint, const QPointF &newPoint, const double radius );
+    bool _addNode( const int indexPoint, QPointF newPoint, const double radius );
 
     bool _removeNode( const int indexPoint );
 

python/core/dxf/qgsdxfexport.sip

@@ -301,6 +301,6 @@ class QgsDxfExport
      * @param fid id of feature
      * @param layer dxf layer of feature
      */
-    void registerDxfLayer( QString layerId, QgsFeatureId fid, QString layer );
+    void registerDxfLayer( const QString& layerId, QgsFeatureId fid, const QString& layer );
 
 };

python/core/layertree/qgslayertreemodel.sip

@@ -65,7 +65,7 @@ class QgsLayerTreeModel : QAbstractItemModel
     typedef QFlags<QgsLayerTreeModel::Flag> Flags;
 
     //! Set OR-ed combination of model flags
-    void setFlags( const Flags& f );
+    void setFlags( Flags f );
     //! Enable or disable a model flag
     void setFlag( Flag f, bool on = true );
     //! Return OR-ed combination of model flags

python/core/qgsattributetableconfig.sip

@@ -107,7 +107,7 @@ class QgsAttributeTableConfig
     /**
      * Set the style of the action widget
      */
-    void setActionWidgetStyle( const ActionWidgetStyle& actionWidgetStyle );
+    void setActionWidgetStyle( ActionWidgetStyle actionWidgetStyle );
 
     /**
      * Serialize to XML on layer save
@@ -165,5 +165,5 @@ class QgsAttributeTableConfig
      * Set the sort order
      * @note Added in 2.16
      */
-    void setSortOrder( const Qt::SortOrder& sortOrder );
+    void setSortOrder( Qt::SortOrder sortOrder );
 };

python/core/qgsdataitem.sip

@@ -160,12 +160,12 @@ class QgsDataItem : QObject
     typedef QFlags<QgsDataItem::Capability> Capabilities;
 
     // This will _write_ selected crs in data source
-    virtual bool setCrs( QgsCoordinateReferenceSystem crs );
+    virtual bool setCrs( const QgsCoordinateReferenceSystem& crs );
 
     // ### QGIS 3 - rename to capabilities()
     virtual Capabilities capabilities2() const;
 
-    virtual void setCapabilities( const Capabilities& capabilities );
+    virtual void setCapabilities( Capabilities capabilities );
 
     // static methods
 
@@ -208,7 +208,7 @@ class QgsDataItem : QObject
 
   protected:
     virtual void populate( const QVector<QgsDataItem*>& children );
-    virtual void refresh( QVector<QgsDataItem*> children );
+    virtual void refresh( const QVector<QgsDataItem*>& children );
     /** The item is scheduled to be deleted. E.g. if deleteLater() is called when
      * item is in Populating state (createChildren() running in another thread),
      * the deferredDelete() returns true and item will be deleted once Populating finished.
@@ -378,7 +378,7 @@ class QgsDirectoryItem : QgsDataCollectionItem
     // static QVector<QLibrary*> mLibraries;
 
     /** Check if the given path is hidden from the browser model */
-    static bool hiddenPath( QString path );
+    static bool hiddenPath( const QString& path );
 
   public slots:
     virtual void childrenCreated();
@@ -482,7 +482,7 @@ class QgsZipItem : QgsDataCollectionItem
 
     static QString vsiPrefix( const QString& uri );
 
-    static QgsDataItem* itemFromPath( QgsDataItem* parent, QString path, QString name ) /Factory/;
+    static QgsDataItem* itemFromPath( QgsDataItem* parent, const QString& path, const QString& name ) /Factory/;
     //! @note available in python as itemFromFilePath
     static QgsDataItem* itemFromPath( QgsDataItem* parent, const QString& filePath, const QString& name, const QString& path ) /Factory,PyName=itemFromFilePath/;
 

python/core/qgsdatetimestatisticalsummary.sip

@@ -34,7 +34,7 @@ class QgsDateTimeStatisticalSummary
     /** Constructor for QgsDateTimeStatisticalSummary
      * @param stats flags for statistics to calculate
      */
-    QgsDateTimeStatisticalSummary( const QgsDateTimeStatisticalSummary::Statistics& stats = All );
+    QgsDateTimeStatisticalSummary( QgsDateTimeStatisticalSummary::Statistics stats = All );
 
     /** Returns flags which specify which statistics will be calculated. Some statistics
      * are always calculated (eg count).
@@ -47,7 +47,7 @@ class QgsDateTimeStatisticalSummary
      * @param stats flags for statistics to calculate
      * @see statistics
      */
-    void setStatistics( const Statistics& stats );
+    void setStatistics( Statistics stats );
 
     /** Resets the calculated values
      */

python/core/qgsinterval.sip

@@ -124,7 +124,7 @@ class QgsInterval
      */
     void setValid( bool valid );
 
-    bool operator==( const QgsInterval& other ) const;
+    bool operator==( QgsInterval other ) const;
 
     /** Converts a string to an interval
      * @param string string to parse

python/core/qgsmaplayerdependency.sip

@@ -19,7 +19,7 @@ class QgsMapLayerDependency
   };
 
   //! Standard constructor
-  QgsMapLayerDependency( QString layerId, Type type = DataDependency, Origin origin = FromUser );
+  QgsMapLayerDependency( const QString& layerId, Type type = DataDependency, Origin origin = FromUser );
 
   //! Return the dependency type
   Type type() const;

python/core/qgsmaplayerproxymodel.sip

@@ -41,7 +41,7 @@ class QgsMapLayerProxyModel : QSortFilterProxyModel
      * @param filters are Filter flags
      * @note added in 2.3
      */
-    QgsMapLayerProxyModel* setFilters( const Filters& filters );
+    QgsMapLayerProxyModel* setFilters( Filters filters );
     const Filters& filters() const;
 
     //! offer the possibility to except some layers to be listed

python/core/qgsmaprenderercustompainterjob.sip

@@ -38,7 +38,7 @@ class QgsMapRendererCustomPainterJob : QgsMapRendererJob
      * Ideally the "wait for finished" method should not be used at all. The code triggering
      * rendering should not need to actively wait for rendering to finish.
      */
-    void waitForFinishedWithEventLoop( const QEventLoop::ProcessEventsFlags& flags = QEventLoop::AllEvents );
+    void waitForFinishedWithEventLoop( QEventLoop::ProcessEventsFlags flags = QEventLoop::AllEvents );
 
     /**
      * Render the map synchronously in this thread. The function does not return until the map

python/core/qgsmapsettings.sip

@@ -122,7 +122,7 @@ class QgsMapSettings
     typedef QFlags<QgsMapSettings::Flag> Flags;
 
     //! Set combination of flags that will be used for rendering
-    void setFlags( const Flags& flags );
+    void setFlags( Flags flags );
     //! Enable or disable a particular flag (other flags are not affected)
     void setFlag( Flag flag, bool on = true );
     //! Return combination of flags used for rendering

python/core/qgsproject.sip

@@ -336,7 +336,7 @@ class QgsProject : QObject
     /**
      * Set a list of layers which should not be taken into account on map identification
      */
-    void setNonIdentifiableLayers( QList<QgsMapLayer*> layers );
+    void setNonIdentifiableLayers( const QList<QgsMapLayer*>& layers );
 
     /**
      * Set a list of layers which should not be taken into account on map identification

python/core/qgsrendercontext.sip

@@ -30,7 +30,7 @@ class QgsRenderContext
     /** Set combination of flags that will be used for rendering.
      * @note added in QGIS 2.14
      */
-    void setFlags( const QgsRenderContext::Flags& flags );
+    void setFlags( QgsRenderContext::Flags flags );
 
     /** Enable or disable a particular flag (other flags are not affected)
      * @note added in QGIS 2.14

python/core/qgssnappingconfig.sip

@@ -176,7 +176,7 @@ class QgsSnappingConfig
     QgsSnappingConfig::IndividualLayerSettings individualLayerSettings( QgsVectorLayer* vl ) const;
 
     //! set individual layer snappings settings (applied if mode is AdvancedConfiguration)
-    void setIndividualLayerSettings( QgsVectorLayer* vl, QgsSnappingConfig::IndividualLayerSettings individualLayerSettings );
+    void setIndividualLayerSettings( QgsVectorLayer* vl, const QgsSnappingConfig::IndividualLayerSettings& individualLayerSettings );
 
     /**
      * Compare this configuration to other.

python/core/qgssqlstatement.sip

@@ -113,7 +113,7 @@ class QgsSQLStatement
      * otherwise the original string.
      * @see quotedString(), quotedIdentifier()
      */
-    static QString quotedIdentifierIfNeeded( QString name );
+    static QString quotedIdentifierIfNeeded( const QString& name );
 
     /** Remove double quotes from an identifier.
      * @see quotedIdentifier()
@@ -340,7 +340,7 @@ class QgsSQLStatement
     class NodeFunction : QgsSQLStatement::Node
     {
       public:
-        NodeFunction( QString name, QgsSQLStatement::NodeList* args /Transfer/ );
+        NodeFunction( const QString name, QgsSQLStatement::NodeList* args /Transfer/ );
         ~NodeFunction();
 
         /** Return function name */
@@ -474,7 +474,7 @@ class QgsSQLStatement
     {
       public:
         NodeJoin( QgsSQLStatement::NodeTableDef* tabledef /Transfer/, QgsSQLStatement::Node* onExpr /Transfer/, QgsSQLStatement::JoinType type );
-        NodeJoin( QgsSQLStatement::NodeTableDef* tabledef /Transfer/, QList<QString> usingColumns, QgsSQLStatement::JoinType type );
+        NodeJoin( QgsSQLStatement::NodeTableDef* tabledef /Transfer/, const QList<QString>& usingColumns, QgsSQLStatement::JoinType type );
 
         /** Table definition */
         QgsSQLStatement::NodeTableDef* tableDef() const;
@@ -525,13 +525,13 @@ class QgsSQLStatement
         NodeSelect( QList<QgsSQLStatement::NodeTableDef*> tableList /Transfer/, QList<QgsSQLStatement::NodeSelectedColumn*> columns /Transfer/, bool distinct );
 
         /** Set joins */
-        void setJoins( QList<QgsSQLStatement::NodeJoin*> joins /Transfer/ );
+        void setJoins( const QList<QgsSQLStatement::NodeJoin*>& joins /Transfer/ );
         /** Append a join */
         void appendJoin( QgsSQLStatement::NodeJoin* join /Transfer/ );
         /** Set where clause */
         void setWhere( QgsSQLStatement::Node* where /Transfer/ );
         /** Set order by columns */
-        void setOrderBy( QList<QgsSQLStatement::NodeColumnSorted*> orderBy /Transfer/ );
+        void setOrderBy( const QList<QgsSQLStatement::NodeColumnSorted*>& orderBy /Transfer/ );
 
         /** Return the list of tables */
         QList<QgsSQLStatement::NodeTableDef*> tables() const;

python/core/qgsstatisticalsummary.sip

@@ -44,7 +44,7 @@ class QgsStatisticalSummary
     /** Constructor for QgsStatisticalSummary
      * @param stats flags for statistics to calculate
      */
-    QgsStatisticalSummary( const QgsStatisticalSummary::Statistics& stats = QgsStatisticalSummary::All );
+    QgsStatisticalSummary( QgsStatisticalSummary::Statistics stats = QgsStatisticalSummary::All );
 
     virtual ~QgsStatisticalSummary();
 
@@ -59,7 +59,7 @@ class QgsStatisticalSummary
      * @param stats flags for statistics to calculate
      * @see statistics
      */
-    void setStatistics( const QgsStatisticalSummary::Statistics& stats );
+    void setStatistics( QgsStatisticalSummary::Statistics stats );
 
     /** Resets the calculated values
      */

python/core/qgsstringstatisticalsummary.sip

@@ -38,7 +38,7 @@ class QgsStringStatisticalSummary
     /** Constructor for QgsStringStatistics
      * @param stats flags for statistics to calculate
      */
-    QgsStringStatisticalSummary( const QgsStringStatisticalSummary::Statistics& stats = All );
+    QgsStringStatisticalSummary( QgsStringStatisticalSummary::Statistics stats = All );
 
     /** Returns flags which specify which statistics will be calculated. Some statistics
      * are always calculated (eg count).
@@ -51,7 +51,7 @@ class QgsStringStatisticalSummary
      * @param stats flags for statistics to calculate
      * @see statistics
      */
-    void setStatistics( const Statistics& stats );
+    void setStatistics( Statistics stats );
 
     /** Resets the calculated values
      */

python/core/qgsvectorfilewriter.sip

@@ -208,7 +208,7 @@ class QgsVectorFileWriter
                                             QgsWkbTypes::Type overrideGeometryType = QgsWkbTypes::Unknown,
                                             bool forceMulti = false,
                                             bool includeZ = false,
-                                            QgsAttributeList attributes = QgsAttributeList(),
+                                            const QgsAttributeList& attributes = QgsAttributeList(),
                                             FieldValueConverter* fieldValueConverter = nullptr
                                           );
 
@@ -253,7 +253,7 @@ class QgsVectorFileWriter
                                             QgsWkbTypes::Type overrideGeometryType = QgsWkbTypes::Unknown,
                                             bool forceMulti = false,
                                             bool includeZ = false,
-                                            QgsAttributeList attributes = QgsAttributeList(),
+                                            const QgsAttributeList& attributes = QgsAttributeList(),
                                             FieldValueConverter* fieldValueConverter = nullptr
                                           );
 

python/core/qgsvectorlayer.sip

@@ -547,7 +547,7 @@ class QgsVectorLayer : QgsMapLayer
      * @see   deselect(QgsFeatureId)
      * @see selectByExpression()
      */
-    void modifySelection( QgsFeatureIds selectIds, QgsFeatureIds deselectIds );
+    void modifySelection( const QgsFeatureIds& selectIds, const QgsFeatureIds& deselectIds );
 
     /** Select not selected features and deselect selected ones */
     void invertSelection();
@@ -728,7 +728,7 @@ class QgsVectorLayer : QgsMapLayer
      */
     bool writeStyle( QDomNode& node, QDomDocument& doc, QString& errorMessage ) const;
 
-    bool writeSld( QDomNode& node, QDomDocument& doc, QString& errorMessage, QgsStringMap& props ) const;
+    bool writeSld( QDomNode& node, QDomDocument& doc, QString& errorMessage, const QgsStringMap& props ) const;
     bool readSld( const QDomNode& node, QString& errorMessage );
 
     /**

python/core/qgsvectorlayereditbuffer.sip

@@ -31,7 +31,7 @@ class QgsVectorLayerEditBuffer : QObject
     virtual bool deleteFeatures( const QgsFeatureIds& fid );
 
     /** Change feature's geometry */
-    virtual bool changeGeometry( QgsFeatureId fid, QgsGeometry geom );
+    virtual bool changeGeometry( QgsFeatureId fid, const QgsGeometry& geom );
 
     /** Changed an attribute value (but does not commit it) */
     virtual bool changeAttributeValue( QgsFeatureId fid, int field, const QVariant &newValue, const QVariant &oldValue = QVariant() );