Skip to content

Commit 7a2e0b6

Browse files
author
dassau
committed
updates and fixes from Volker Froehlich
git-svn-id: http://svn.osgeo.org/qgis/trunk/qgis@14128 c8812cc2-4d05-0410-92ff-de0c093fc19c
1 parent 992c102 commit 7a2e0b6

File tree

1 file changed

+11
-10
lines changed

1 file changed

+11
-10
lines changed

doc/CODING.t2t

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ QGIS classes that are generated from Qt Designer (ui) files should have a
110110
//Base// suffix. This identifies the class as a generated base class.
111111
```
112112
Examples:
113-
QgsPluginMangerBase
113+
QgsPluginManagerBase
114114
QgsUserOptionsBase
115115
```
116116
=== Dialogs ===
@@ -276,10 +276,11 @@ once, consider consolidating the code into a single function.
276276
```
277277

278278
This will:
279-
* allow changes to be made in one location instead of in multiple places
280-
* help prevent code bloat
281-
* make it more difficult for multiple copies to evolve differences over time,
282-
thus making it harder to understand and maintain for others
279+
- allow changes to be made in one location instead of in multiple places
280+
- help prevent code bloat
281+
- make it more difficult for multiple copies to evolve differences over time,
282+
thus making it harder to understand and maintain for others
283+
-
283284

284285
=== Prefer Having Constants First in Predicates ===
285286

@@ -558,7 +559,7 @@ a ticket in trac (https://trac.osgeo.org/qgis/) first and then attach you
558559
This makes it easier for us to apply the patches since we don't need to
559560
navigate to a specific place in the source tree to apply the patch. Also when I
560561
receive patches I usually evaluate them using kompare, and having the patch
561-
from the top level dir makes this much easier. Below is an example of you you
562+
from the top level dir makes this much easier. Below is an example of how you
562563
can include multiple changed files into your patch from the top level
563564
directory:
564565

@@ -583,10 +584,10 @@ svn diff > bug7887fix.diff
583584

584585
QGIS developers are busy folk. We do scan the incoming patches on bug reports
585586
but sometimes we miss things. Don't be offended or alarmed. Try to identify a
586-
developer to help you - using the ["Project Organigram"] and contact them
587+
developer to help you - using the [Project Organigram http://www.qgis.org/wiki/Project_Organigram] and contact them
587588
asking them if they can look at your patch. If you don't get any response, you
588589
can escalate your query to one of the Project Steering Committee members
589-
(contact details also available on the ["Project Organigram"]).
590+
(contact details also available on the Project Organigram).
590591

591592
=== Due Diligence ===
592593

@@ -601,13 +602,13 @@ under the GPL.
601602

602603
Write access to QGIS source tree is by invitation. Typically when a person
603604
submits several (there is no fixed number here) substantial patches that
604-
demonstrate basic competance and understanding of C++ and QGIS coding
605+
demonstrate basic competence and understanding of C++ and QGIS coding
605606
conventions, one of the PSC members or other existing developers can nominate
606607
that person to the PSC for granting of write access. The nominator should give
607608
a basic promotional paragraph of why they think that person should gain write
608609
access. In some cases we will grant write access to non C++ developers e.g. for
609610
translators and documentors. In these cases, the person should still have
610-
demonstrated ability to submit patches and should ideally have submtted several
611+
demonstrated ability to submit patches and should ideally have submitted several
611612
substantial patches that demonstrate their understanding of modifying the code
612613
base without breaking things, etc.
613614

0 commit comments

Comments
 (0)