Skip to content

Commit 7a2ff54

Browse files
committed
Added SIP version test to delimited text test script
1 parent 9eacb74 commit 7a2ff54

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

tests/src/python/test_qgsdelimitedtextprovider.py

+10-1
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,14 @@
5858
unittest
5959
#expectedFailure
6060
)
61+
62+
import sip
63+
6164
QGISAPP, CANVAS, IFACE, PARENT = getQgisTestApp()
6265

6366

67+
sipversion=str(sip.getapi('QVariant'))
68+
sipwanted='2'
6469
geomkey = "#geometry"
6570
fidkey = "#fid"
6671
tolerance = 0.000001 # Tolerance for coordinate comparisons in checkWktEqual
@@ -115,7 +120,7 @@ def layerData( layer, request={}, offset=0 ):
115120
for field in f.fields():
116121
fields.append(str(field.name()))
117122
fieldTypes.append(str(field.typeName()))
118-
fielddata = dict ( (name, unicode(f[name].toString()) ) for name in fields )
123+
fielddata = dict ( (name, unicode(f[name]) ) for name in fields )
119124
g = f.geometry()
120125
if g:
121126
fielddata[geomkey] = str(g.exportToWkt());
@@ -256,6 +261,9 @@ def recordDifference( record1, record2 ):
256261
return ''
257262

258263
def runTest( file, requests, **params ):
264+
# No point doing test if haven't got the right SIP vesion
265+
if sipversion != sipwanted:
266+
return
259267
testname=inspect.stack()[1][3];
260268
verbose = not rebuildTests
261269
if verbose:
@@ -327,6 +335,7 @@ def test_001_provider_defined( self ):
327335
registry=QgsProviderRegistry.instance()
328336
metadata = registry.providerMetadata('delimitedtext')
329337
assert metadata != None, "Delimited text provider is not installed"
338+
assert sipversion==sipwanted,"SIP version "+sipversion+" - require version "+sipwanted+" for delimited text tests"
330339

331340
def test_002_load_csv_file(self):
332341
# CSV file parsing

0 commit comments

Comments
 (0)