Skip to content
Permalink
Browse files

Remove more debug noise

  • Loading branch information
m-kuhn committed Jun 12, 2016
1 parent c63b910 commit 7b3e66728296806389286b57d989edfa7f84af0f
Showing with 0 additions and 287 deletions.
  1. +0 −1 src/app/composer/qgscomposer.cpp
  2. +0 −1 src/app/qgscustomprojectiondialog.cpp
  3. +0 −5 src/app/qgshandlebadlayers.cpp
  4. +0 −7 src/app/qgslabeldialog.cpp
  5. +0 −1 src/app/qgsmaptoollabel.cpp
  6. +0 −1 src/app/qgsmaptoolmovefeature.cpp
  7. +0 −1 src/app/qgsrasterlayerproperties.cpp
  8. +0 −1 src/core/composer/qgscomposeritem.cpp
  9. +0 −1 src/core/gps/qgsgpsdconnection.cpp
  10. +0 −1 src/core/gps/qgsqtlocationconnection.cpp
  11. +0 −1 src/core/qgscoordinatereferencesystem.cpp
  12. +0 −2 src/core/qgshttptransaction.cpp
  13. +0 −1 src/core/qgsprojectfiletransform.cpp
  14. +0 −1 src/core/qgsvectorlayer.cpp
  15. +0 −1 src/gui/auth/qgsauthimportidentitydialog.cpp
  16. +0 −1 src/gui/qgsnewnamedialog.cpp
  17. +0 −4 src/gui/qgsowssourceselect.cpp
  18. +0 −2 src/gui/qgssearchquerybuilder.cpp
  19. +0 −2 src/gui/raster/qgsrasterhistogramwidget.cpp
  20. +0 −1 src/gui/raster/qgsrastertransparencywidget.cpp
  21. +0 −6 src/plugins/grass/qgsgrasseditrenderer.cpp
  22. +0 −26 src/plugins/grass/qgsgrassmapcalc.cpp
  23. +0 −14 src/plugins/grass/qgsgrassmoduleinput.cpp
  24. +0 −1 src/plugins/grass/qgsgrassmoduleoptions.cpp
  25. +0 −15 src/plugins/grass/qgsgrassmoduleparam.cpp
  26. +0 −28 src/plugins/grass/qgsgrassnewmapset.cpp
  27. +0 −14 src/plugins/grass/qgsgrassplugin.cpp
  28. +0 −8 src/plugins/grass/qgsgrassregion.cpp
  29. +0 −1 src/plugins/grass/qgsgrassshell.cpp
  30. +0 −6 src/plugins/grass/qgsgrasstools.cpp
  31. +0 −2 src/plugins/grass/qgsgrassutils.cpp
  32. +0 −1 src/providers/db2/qgsdb2provider.cpp
  33. +0 −1 src/providers/db2/qgsdb2sourceselect.cpp
  34. +0 −2 src/providers/gdal/qgsgdalprovider.cpp
  35. +0 −1 src/providers/gdal/qgsgdalproviderbase.cpp
  36. +0 −16 src/providers/grass/qgsgrass.cpp
  37. +0 −2 src/providers/grass/qgsgrassfeatureiterator.cpp
  38. +0 −9 src/providers/grass/qgsgrassimport.cpp
  39. +0 −17 src/providers/grass/qgsgrassprovider.cpp
  40. +0 −13 src/providers/grass/qgsgrassprovidermodule.cpp
  41. +0 −4 src/providers/grass/qgsgrassrasterprovider.cpp
  42. +0 −7 src/providers/grass/qgsgrassvectormap.cpp
  43. +0 −6 src/providers/grass/qgsgrassvectormaplayer.cpp
  44. +0 −1 src/providers/mssql/qgsmssqlsourceselect.cpp
  45. +0 −1 src/providers/oracle/qgsoracleprovider.cpp
  46. +0 −1 src/providers/oracle/qgsoraclesourceselect.cpp
  47. +0 −1 src/providers/postgres/qgspgsourceselect.cpp
  48. +0 −2 src/providers/postgres/qgspostgresprovider.cpp
  49. +0 −1 src/providers/wcs/qgswcscapabilities.cpp
  50. +0 −4 src/providers/wcs/qgswcsprovider.cpp
  51. +0 −8 src/providers/wcs/qgswcssourceselect.cpp
  52. +0 −1 src/providers/wfs/qgswfsrequest.cpp
  53. +0 −18 src/providers/wms/qgswmscapabilities.cpp
  54. +0 −6 src/providers/wms/qgswmsprovider.cpp
  55. +0 −1 src/server/qgshostedrdsbuilder.cpp
  56. +0 −2 src/server/qgsremotedatasourcebuilder.cpp
  57. +0 −4 tests/bench/qgsbench.cpp
@@ -473,7 +473,6 @@ QgsComposer::QgsComposer( QgisApp *qgis, const QString& title )
mWindowAction = new QAction( windowTitle(), this );
connect( mWindowAction, SIGNAL( triggered() ), this, SLOT( activate() ) );

QgsDebugMsg( "entered." );

setMouseTracking( true );
mViewFrame->setMouseTracking( true );
@@ -448,7 +448,6 @@ void QgsCustomProjectionDialog::on_buttonBox_accepted()

void QgsCustomProjectionDialog::on_pbnCalculate_clicked()
{
QgsDebugMsg( "entered." );


//
@@ -157,7 +157,6 @@ QgsHandleBadLayers::~QgsHandleBadLayers()

void QgsHandleBadLayers::selectionChanged()
{
QgsDebugMsg( "entered." );

mRows.clear();

@@ -250,7 +249,6 @@ void QgsHandleBadLayers::setFilename( int row, const QString& filename )

void QgsHandleBadLayers::browseClicked()
{
QgsDebugMsg( "entered." );

if ( mRows.size() == 1 )
{
@@ -362,7 +360,6 @@ void QgsHandleBadLayers::editAuthCfg()

void QgsHandleBadLayers::apply()
{
QgsDebugMsg( "entered." );
for ( int i = 0; i < mLayerList->rowCount(); i++ )
{
int idx = mLayerList->item( i, 0 )->data( Qt::UserRole ).toInt();
@@ -385,7 +382,6 @@ void QgsHandleBadLayers::apply()

void QgsHandleBadLayers::accept()
{
QgsDebugMsg( "entered." );
apply();

if ( mLayerList->rowCount() > 0 &&
@@ -405,7 +401,6 @@ void QgsHandleBadLayers::accept()

void QgsHandleBadLayers::rejected()
{
QgsDebugMsg( "entered." );

if ( mLayerList->rowCount() > 0 &&
QMessageBox::warning( this,
@@ -36,7 +36,6 @@ QgsLabelDialog::QgsLabelDialog( QgsLabel *label, QWidget *parent )
, mFont( "Helvetica" )
{
setupUi( this );
QgsDebugMsg( "entering." );

Q_ASSERT( label );

@@ -53,7 +52,6 @@ QgsLabelDialog::QgsLabelDialog( QgsLabel *label, QWidget *parent )

void QgsLabelDialog::init()
{
QgsDebugMsg( "entering." );

QgsLabelAttributes * myLabelAttributes = mLabel->labelAttributes();
//populate a string list with all the field names which will be used to set up the
@@ -274,7 +272,6 @@ void QgsLabelDialog::init()

void QgsLabelDialog::changeFont()
{
QgsDebugMsg( "entering." );

qreal fontSize = mFont.pointSizeF();
bool resultFlag;
@@ -293,7 +290,6 @@ void QgsLabelDialog::changeFont()

void QgsLabelDialog::changeFontColor()
{
QgsDebugMsg( "entering." );

QColor color = QColorDialog::getColor( mFontColor );
if ( !color.isValid() )
@@ -307,7 +303,6 @@ void QgsLabelDialog::changeFontColor()

void QgsLabelDialog::changeBufferColor()
{
QgsDebugMsg( "entering." );

QColor color = QColorDialog::getColor( mBufferColor );
if ( !color.isValid() )
@@ -328,12 +323,10 @@ int QgsLabelDialog::itemNoForField( const QString& theFieldName, const QStringLi

QgsLabelDialog::~QgsLabelDialog()
{
QgsDebugMsg( "entering." );
}

void QgsLabelDialog::apply()
{
QgsDebugMsg( "entering." );

//set the label props that are NOT bound to a field in the attributes tbl
//All of these are set in the labelAttributes member of the layer
@@ -620,7 +620,6 @@ bool QgsMapToolLabel::layerCanPin( QgsVectorLayer* vlayer, int& xCol, int& yCol

bool QgsMapToolLabel::labelCanShowHide( QgsVectorLayer* vlayer, int& showCol ) const
{
//QgsDebugMsg( "entered" );
if ( !vlayer || !vlayer->isEditable() )
{
return false;
@@ -142,7 +142,6 @@ void QgsMapToolMoveFeature::canvasPressEvent( QgsMapMouseEvent* e )

void QgsMapToolMoveFeature::canvasReleaseEvent( QgsMapMouseEvent* e )
{
//QgsDebugMsg("entering.");
if ( !mRubberBand )
{
return;
@@ -483,7 +483,6 @@ void QgsRasterLayerProperties::setupTransparencyTable( int nBands )

void QgsRasterLayerProperties::populateTransparencyTable( QgsRasterRenderer* renderer )
{
QgsDebugMsg( "entering." );
if ( !mRasterLayer )
{
return;
@@ -154,7 +154,6 @@ QgsComposerItem::~QgsComposerItem()

void QgsComposerItem::setSelected( bool s )
{
QgsDebugMsg( "entered." );
QGraphicsRectItem::setSelected( s );
//inform model that id data has changed
if ( mComposition )
@@ -34,7 +34,6 @@ QgsGpsdConnection::QgsGpsdConnection( const QString& host, qint16 port, const QS
QgsGpsdConnection::~QgsGpsdConnection()
{
//connection will be closed by base class
QgsDebugMsg( "entered." );
}

void QgsGpsdConnection::connected()
@@ -37,7 +37,6 @@ QgsQtLocationConnection::QgsQtLocationConnection(): QgsGPSConnection( new QLocal
QgsQtLocationConnection::~QgsQtLocationConnection()
{
//connection will be closed by base class
QgsDebugMsg( "entered." );
}

//Needed to make connection detectable (half HACK)
@@ -996,7 +996,6 @@ void QgsCoordinateReferenceSystem::setMapUnits()
*/
long QgsCoordinateReferenceSystem::findMatchingProj()
{
QgsDebugMsg( "entered." );
if ( d->mEllipsoidAcronym.isNull() || d->mProjectionAcronym.isNull()
|| !d->mIsValid )
{
@@ -392,7 +392,6 @@ void QgsHttpTransaction::dataFinished( int id, bool error )
void QgsHttpTransaction::transactionFinished( bool error )
{
#ifdef QGISDEBUG
QgsDebugMsg( "entered." );

#if 0
// The signal that this slot is connected to, QHttp::requestFinished,
@@ -489,7 +488,6 @@ void QgsHttpTransaction::dataStateChanged( int state )

void QgsHttpTransaction::networkTimedOut()
{
QgsDebugMsg( "entering." );

mError = tr( "Network timed out after %n second(s) of inactivity.\n"
"This may be a problem in your network connection or at the WMS server.", "inactivity timeout", mNetworkTimeoutMsec / 1000 );
@@ -204,7 +204,6 @@ void QgsProjectFileTransform::transform081to090()

void QgsProjectFileTransform::transform091to0100()
{
QgsDebugMsg( "entering" );
if ( ! mDom.isNull() )
{
// Insert transforms here!
@@ -175,7 +175,6 @@ QgsVectorLayer::QgsVectorLayer( const QString& vectorLayerPath,

QgsVectorLayer::~QgsVectorLayer()
{
QgsDebugMsg( "entered." );

emit layerDeleted();

@@ -139,7 +139,6 @@ void QgsAuthImportIdentityDialog::validateIdentity()

bool QgsAuthImportIdentityDialog::validateBundle()
{
QgsDebugMsg( "entered" );

// clear out any previously set bundle
QSslCertificate emptycert;
@@ -111,7 +111,6 @@ QString QgsNewNameDialog::highlightText( const QString& text )

void QgsNewNameDialog::nameChanged()
{
QgsDebugMsg( "entered" );

QString namesString = tr( "Full names" ) + ": ";
if ( !mExtensions.isEmpty() )
@@ -139,7 +139,6 @@ void QgsOWSSourceSelect::clearFormats()

void QgsOWSSourceSelect::populateFormats()
{
QgsDebugMsg( "entered" );

// A server may offer more similar formats, which are mapped
// to the same GDAL format, e.g. GeoTIFF and TIFF
@@ -225,7 +224,6 @@ void QgsOWSSourceSelect::populateFormats()

void QgsOWSSourceSelect::populateTimes()
{
QgsDebugMsg( "entered" );
mTimeComboBox->clear();
mTimeComboBox->insertItems( 0, selectedLayersTimes() );
mTimeComboBox->setEnabled( !selectedLayersTimes().isEmpty() );
@@ -345,7 +343,6 @@ void QgsOWSSourceSelect::populateLayerList()

void QgsOWSSourceSelect::on_mConnectButton_clicked()
{
QgsDebugMsg( "entered" );

mLayersTreeWidget->clear();
clearFormats();
@@ -367,7 +364,6 @@ void QgsOWSSourceSelect::on_mConnectButton_clicked()

void QgsOWSSourceSelect::addClicked()
{
QgsDebugMsg( "entered" );
}

void QgsOWSSourceSelect::enableLayersForCrs( QTreeWidgetItem * )
@@ -73,7 +73,6 @@ void QgsSearchQueryBuilder::populateFields()
if ( !mLayer )
return;

QgsDebugMsg( "entering." );
const QgsFields& fields = mLayer->fields();
for ( int idx = 0; idx < fields.count(); ++idx )
{
@@ -87,7 +86,6 @@ void QgsSearchQueryBuilder::populateFields()

void QgsSearchQueryBuilder::setupListViews()
{
QgsDebugMsg( "entering." );
//Models
mModelFields = new QStandardItemModel();
mModelValues = new QStandardItemModel();
@@ -283,7 +283,6 @@ void QgsRasterHistogramWidget::on_btnHistoCompute_clicked()

bool QgsRasterHistogramWidget::computeHistogram( bool forceComputeFlag )
{
QgsDebugMsg( "entered." );

//bool myIgnoreOutOfRangeFlag = true;
//bool myThoroughBandScanFlag = false;
@@ -340,7 +339,6 @@ void QgsRasterHistogramWidget::refreshHistogram()
//
int myBandCountInt = mRasterLayer->bandCount();

QgsDebugMsg( "entered." );

if ( ! computeHistogram( false ) )
{
@@ -494,7 +494,6 @@ void QgsRasterTransparencyWidget::pixelSelected( const QgsPoint & canvasPoint )

void QgsRasterTransparencyWidget::populateTransparencyTable( QgsRasterRenderer *renderer )
{
QgsDebugMsg( "entering." );
if ( !mRasterLayer )
{
return;
@@ -204,7 +204,6 @@ QString QgsGrassEditRenderer::dump() const

QDomElement QgsGrassEditRenderer::save( QDomDocument& doc )
{
QgsDebugMsg( "entered" );
QDomElement rendererElem = doc.createElement( RENDERER_TAG_NAME );
rendererElem.setAttribute( "type", "grassEdit" );

@@ -222,7 +221,6 @@ QDomElement QgsGrassEditRenderer::save( QDomDocument& doc )

QgsFeatureRendererV2* QgsGrassEditRenderer::create( QDomElement& element )
{
QgsDebugMsg( "entered" );
QgsGrassEditRenderer *renderer = new QgsGrassEditRenderer();

QDomElement childElem = element.firstChildElement();
@@ -260,7 +258,6 @@ QgsFeatureRendererV2* QgsGrassEditRenderer::create( QDomElement& element )

QgsRendererV2Widget* QgsGrassEditRendererWidget::create( QgsVectorLayer* layer, QgsStyleV2* style, QgsFeatureRendererV2* renderer )
{
QgsDebugMsg( "entered" );
return new QgsGrassEditRendererWidget( layer, style, renderer );
}

@@ -270,7 +267,6 @@ QgsGrassEditRendererWidget::QgsGrassEditRendererWidget( QgsVectorLayer* layer, Q
, mLineRendererWidget( 0 )
, mPointRendererWidget( 0 )
{
QgsDebugMsg( "entered" );
mRenderer = dynamic_cast<QgsGrassEditRenderer*>( renderer->clone() );
if ( !mRenderer )
{
@@ -288,13 +284,11 @@ QgsGrassEditRendererWidget::QgsGrassEditRendererWidget( QgsVectorLayer* layer, Q

QgsGrassEditRendererWidget::~QgsGrassEditRendererWidget()
{
QgsDebugMsg( "entered" );
delete mRenderer;
}

QgsFeatureRendererV2* QgsGrassEditRendererWidget::renderer()
{
QgsDebugMsg( "entered" );
mRenderer->setLineRenderer( mLineRendererWidget->renderer()->clone() );
mRenderer->setMarkerRenderer( mPointRendererWidget->renderer()->clone() );
return mRenderer;

7 comments on commit 7b3e667

@luipir

This comment has been minimized.

Copy link
Contributor

@luipir luipir replied Jun 12, 2016

would make sense to use QgsDebugMsgLevel setting at higer level (3) instead of removing thhem or just removing that are redoundats with other QgsDebugMsg in the same routine?

@m-kuhn

This comment has been minimized.

Copy link
Member Author

@m-kuhn m-kuhn replied Jun 12, 2016

are you worried about some of them in particular?

@luipir

This comment has been minimized.

Copy link
Contributor

@luipir luipir replied Jun 12, 2016

that that have no other debug message inside

@m-kuhn

This comment has been minimized.

Copy link
Member Author

@m-kuhn m-kuhn replied Jun 12, 2016

@luipir

This comment has been minimized.

Copy link
Contributor

@luipir luipir replied Jun 12, 2016

I can't and I don't want to convince you, first debug session for me is reading log... expecially when I've to compare different running session. My practice is have different debug level messages... enterig/exiting are the messages sent in the higher level.
Nothing that can't be done using breackpoints, but many time it's useful to rise the debug level to people that are not able at all to manage a debugger.

@m-kuhn

This comment has been minimized.

Copy link
Member Author

@m-kuhn m-kuhn replied Jun 13, 2016

Please do convince me @luipir . If you say it's useful, I have no problems with reverting this. I completely agree to your point concerning debug level (which is really poorly used in QGIS at the moment). Maybe we should make it mandatory to specify a debug level in QgsDebugMsg so devs are forced to consider the debug level.

My feeling concerning these particular messages was that they don't really offer any additional benefit apart from the general flow of code. And since they are only used sporadically chances that they are misleading because they are missing in the part which you are debugging are just as high as chances that they are useful. But it's just a feeling, no strong opinion.

@luipir

This comment has been minimized.

Copy link
Contributor

@luipir luipir replied Jun 13, 2016

me too, I've no strong opinion pro/cons... btw would be useful to add debugLevel as constraint, IMHO would be a constraint also the visualization of general flow of code that is useful to understand and inspect/study the code.

Please sign in to comment.
You can’t perform that action at this time.