remove need for factory for system of measurement

qgis · Jun 28, 2018 · 7bfcaf4db9486f82d1ff37b2d5ba7c1f96d642d9 · 7bfcaf4
1 parent 00cd4b3
commit 7bfcaf4db9486f82d1ff37b2d5ba7c1f96d642d9
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 27 deletions.
diff --git a/python/core/auto_additions/qgsunittypes.py b/python/core/auto_additions/qgsunittypes.py
@@ -1,4 +1,5 @@
 # The following has been generated automatically from src/core/qgsunittypes.h
+QgsUnitTypes.SystemOfMeasurement.baseClass = QgsUnitTypes
 QgsUnitTypes.DistanceUnit.baseClass = QgsUnitTypes
 QgsUnitTypes.AreaUnit.baseClass = QgsUnitTypes
 QgsUnitTypes.AngleUnit.baseClass = QgsUnitTypes

diff --git a/src/core/qgsunittypes.h b/src/core/qgsunittypes.h
@@ -47,6 +47,7 @@ class CORE_EXPORT QgsUnitTypes
       ImperialSystem, //!< British Imperial
       USCSSystem //!< United States customary system
     };
+    Q_ENUM( SystemOfMeasurement )
 
     //! Units of distance
     enum DistanceUnit

diff --git a/src/quickgui/plugin/qgsquickplugin.cpp b/src/quickgui/plugin/qgsquickplugin.cpp
@@ -66,6 +66,8 @@ void QgsQuickPlugin::registerTypes( const char *uri )
   qRegisterMetaType< QgsCoordinateFormatter::FormatFlags >( "QgsCoordinateFormatter::FormatFlags" );
   qRegisterMetaType< QgsCoordinateFormatter::Format >( "QgsCoordinateFormatter::Format" );
 
+  qmlRegisterUncreatableType< QgsUnitTypes >( uri, 0, 1, "QgsUnitTypes", "Only enums from QgsUnitTypes can be used" );
+
   qmlRegisterType< QgsProject >( uri, 0, 1, "Project" );
   qmlRegisterType< QgsQuickFeatureHighlight >( uri, 0, 1, "FeatureHighlight" );
   qmlRegisterType< QgsQuickCoordinateTransformer >( uri, 0, 1, "CoordinateTransformer" );

diff --git a/src/quickgui/qgsquickutils.cpp b/src/quickgui/qgsquickutils.cpp
@@ -101,20 +101,6 @@ const QUrl QgsQuickUtils::getThemeIcon( const QString &name ) const
   return QUrl( path );
 }
 
-QgsUnitTypes::SystemOfMeasurement QgsQuickUtils::systemOfMeasurementFactory( const QString &type )
-{
-  if ( type == QStringLiteral( "Metric" ) )
-    return QgsUnitTypes::MetricSystem;
-
-  if ( type == QStringLiteral( "Imperial" ) )
-    return QgsUnitTypes::ImperialSystem;
-
-  if ( type == QStringLiteral( "USCS" ) )
-    return QgsUnitTypes::USCSSystem;
-
-  return QgsUnitTypes::UnknownSystem;
-}
-
 QString QgsQuickUtils::formatPoint(
   const QgsPoint &point,
   QgsCoordinateFormatter::Format format,

diff --git a/src/quickgui/qgsquickutils.h b/src/quickgui/qgsquickutils.h
@@ -136,18 +136,6 @@ class QUICK_EXPORT QgsQuickUtils: public QObject
       */
     Q_INVOKABLE const QUrl getThemeIcon( const QString &name ) const;
 
-    /**
-      * QgsUnitTypes::SystemOfMeasurement factory
-      * for input type parameter:
-      *    "Metric": QgsUnitTypes::MetricSystem
-      *    "Imperial": QgsUnitTypes::ImperialSystem
-      *    "USCS": QgsUnitTypes::USCSSystem
-      *    else: QgsUnitTypes::UnknownSystem
-      *
-      * \since QGIS 3.4
-      */
-    Q_INVOKABLE static QgsUnitTypes::SystemOfMeasurement systemOfMeasurementFactory( const QString &type );
-
     /**
      * \copydoc QgsCoordinateFormatter::format()
      *

diff --git a/tests/src/quickgui/app/main.qml b/tests/src/quickgui/app/main.qml
@@ -94,7 +94,7 @@ ApplicationWindow {
     height: scaleBar.height
     mapSettings: mapCanvas.mapSettings
     preferredWidth: scaleBar.preferredWidth
-    systemOfMeasurement: QgsQuick.Utils.systemOfMeasurementFactory("Imperial")
+    systemOfMeasurement: QgsQuick.QgsUnitTypes.ImperialSystem
     z: 1
   }