Skip to content

Commit 7c3ec07

Browse files
committed
[ui] add missing icons for no labels and no diagram
1 parent a6a77ee commit 7c3ec07

File tree

6 files changed

+152
-7
lines changed

6 files changed

+152
-7
lines changed

images/images.qrc

+3-1
Original file line numberDiff line numberDiff line change
@@ -439,7 +439,8 @@
439439
<file>themes/default/mMessageLog.svg</file>
440440
<file>themes/default/mMessageLogRead.svg</file>
441441
<file>themes/default/north_arrow.png</file>
442-
<file>themes/default/pie-chart.png</file>
442+
<file>themes/default/diagramNone.svg</file>
443+
<file>themes/default/pie-chart.svg</file>
443444
<file>themes/default/plugin.png</file>
444445
<file>themes/default/pluginExperimental.png</file>
445446
<file>themes/default/pluginDeprecated.png</file>
@@ -495,6 +496,7 @@
495496
<file>themes/default/rendererHeatmapSymbol.svg</file>
496497
<file>themes/default/renderer25dSymbol.svg</file>
497498
<file>themes/default/rendererGrassSymbol.svg</file>
499+
<file>themes/default/labelingNone.svg</file>
498500
<file>themes/default/labelingSingle.svg</file>
499501
<file>themes/default/labelingRuleBased.svg</file>
500502
<file>themes/default/labelingObstacle.svg</file>

images/themes/default/diagramNone.svg

+69
Loading
+69
Loading

src/app/qgsdiagramproperties.cpp

+3-2
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,9 @@ QgsDiagramProperties::QgsDiagramProperties( QgsVectorLayer* layer, QWidget* pare
6666
mDiagramOptionsListWidget->setAttribute( Qt::WA_MacShowFocusRect, false );
6767

6868
mDiagramTypeComboBox->blockSignals( true );
69-
mDiagramTypeComboBox->addItem( tr( "No diagrams" ), "None" );
70-
QPixmap pix = QgsApplication::getThemePixmap( "pie-chart" );
69+
QPixmap pix = QgsApplication::getThemePixmap( "diagramNone" );
70+
mDiagramTypeComboBox->addItem( pix, tr( "No diagrams" ), "None" );
71+
pix = QgsApplication::getThemePixmap( "pie-chart" );
7172
mDiagramTypeComboBox->addItem( pix, tr( "Pie chart" ), DIAGRAM_NAME_PIE );
7273
pix = QgsApplication::getThemePixmap( "text" );
7374
mDiagramTypeComboBox->addItem( pix, tr( "Text diagram" ), DIAGRAM_NAME_TEXT );

src/core/symbology-ng/qgsrendererv2registry.cpp

+4-4
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@
2828
QgsRendererV2Registry::QgsRendererV2Registry()
2929
{
3030
// add default renderers
31+
addRenderer( new QgsRendererV2Metadata( "nullSymbol",
32+
QObject::tr( "No Symbols" ),
33+
QgsNullSymbolRenderer::create ) );
34+
3135
addRenderer( new QgsRendererV2Metadata( "singleSymbol",
3236
QObject::tr( "Single Symbol" ),
3337
QgsSingleSymbolRendererV2::create,
@@ -62,10 +66,6 @@ QgsRendererV2Registry::QgsRendererV2Registry()
6266
addRenderer( new QgsRendererV2Metadata( "25dRenderer",
6367
QObject::tr( "2.5 D" ),
6468
Qgs25DRenderer::create ) );
65-
66-
addRenderer( new QgsRendererV2Metadata( "nullSymbol",
67-
QObject::tr( "No Symbols" ),
68-
QgsNullSymbolRenderer::create ) );
6969
}
7070

7171
QgsRendererV2Registry::~QgsRendererV2Registry()

src/ui/qgslabelingwidget.ui

+4
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,10 @@
2525
<property name="text">
2626
<string>No labels</string>
2727
</property>
28+
<property name="icon">
29+
<iconset resource="../../images/images.qrc">
30+
<normaloff>:/images/themes/default/labelingNone.svg</normaloff>:/images/themes/default/labelingNone.svg</iconset>
31+
</property>
2832
</item>
2933
<item>
3034
<property name="text">

0 commit comments

Comments
 (0)