Skip to content

Commit 7cfd284

Browse files
committed
Remove all previously autoconnected slots from public API
These are implementation details only, and should not be part of the stable API. We need the flexibility to change these at any stage without being bound by any API contract.
1 parent 1429f2c commit 7cfd284

22 files changed

+137
-331
lines changed

python/gui/qgserrordialog.sip

-4
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,6 @@ class QgsErrorDialog: QDialog
3131
\param fl widget flags
3232
%End
3333

34-
public slots:
35-
void mDetailPushButton_clicked();
36-
void mDetailCheckBox_stateChanged( int state );
37-
3834
};
3935

4036
/************************************************************************

python/gui/qgsnewvectorlayerdialog.sip

-13
Original file line numberDiff line numberDiff line change
@@ -60,19 +60,6 @@ Returns the file format for storage
6060
.. seealso:: crs()
6161
%End
6262

63-
protected slots:
64-
void mAddAttributeButton_clicked();
65-
void mRemoveAttributeButton_clicked();
66-
void mFileFormatComboBox_currentIndexChanged( int index );
67-
void mTypeBox_currentIndexChanged( int index );
68-
69-
void showHelp();
70-
%Docstring
71-
Open the associated help
72-
%End
73-
void nameChanged( const QString & );
74-
void selectionChanged();
75-
7663
};
7764

7865
/************************************************************************

python/gui/qgsowssourceselect.sip

+3-52
Original file line numberDiff line numberDiff line change
@@ -48,63 +48,15 @@ Constructor
4848
Triggered when the provider's connections need to be refreshed
4949
%End
5050

51-
void mNewButton_clicked();
52-
%Docstring
53-
Opens the create connection dialog to build a new connection
54-
%End
55-
void mEditButton_clicked();
56-
%Docstring
57-
Opens a dialog to edit an existing connection
58-
%End
59-
void mDeleteButton_clicked();
60-
%Docstring
61-
Deletes the selected connection
62-
%End
63-
void mSaveButton_clicked();
64-
%Docstring
65-
Saves connections to the file
66-
%End
67-
void mLoadButton_clicked();
68-
%Docstring
69-
Loads connections from the file
70-
%End
71-
72-
void mConnectButton_clicked();
73-
%Docstring
74-
Connects to the database using the stored connection parameters.
75-
Once connected, available layers are displayed.
76-
%End
77-
78-
void searchFinished();
79-
80-
void mChangeCRSButton_clicked();
81-
%Docstring
82-
Opens the Spatial Reference System dialog.
83-
%End
84-
85-
virtual void mLayersTreeWidget_itemSelectionChanged();
86-
%Docstring
87-
Signaled when a layer selection is changed.
88-
%End
89-
90-
void showStatusMessage( const QString &message );
91-
%Docstring
92-
Set status message to theMessage
93-
%End
94-
51+
protected slots:
9552
void showError( const QString &title, const QString &format, const QString &error );
9653
%Docstring
9754
show whatever error is exposed.
9855
%End
9956

100-
void mConnectionsComboBox_activated( int );
101-
%Docstring
102-
Stores the selected datasource whenerver it is changed
103-
%End
104-
105-
void mAddDefaultButton_clicked();
57+
void showStatusMessage( const QString &message );
10658
%Docstring
107-
Add some default wms servers to the list
59+
Set status message to theMessage
10860
%End
10961

11062
protected:
@@ -245,7 +197,6 @@ Returns currently selected cache load control
245197

246198

247199

248-
249200
};
250201

251202
/************************************************************************

python/gui/qgsquerybuilder.sip

+6-35
Original file line numberDiff line numberDiff line change
@@ -39,34 +39,18 @@ class QgsQueryBuilder : QDialog
3939
virtual void showEvent( QShowEvent *event );
4040

4141

42+
QString sql();
43+
%Docstring
44+
:rtype: str
45+
%End
46+
void setSql( const QString &sqlStatement );
47+
4248
public slots:
4349
virtual void accept();
4450

4551
virtual void reject();
4652

4753
void clear();
48-
void btnEqual_clicked();
49-
void btnLessThan_clicked();
50-
void btnGreaterThan_clicked();
51-
void btnPct_clicked();
52-
void btnIn_clicked();
53-
void btnNotIn_clicked();
54-
void btnLike_clicked();
55-
void btnILike_clicked();
56-
QString sql();
57-
%Docstring
58-
:rtype: str
59-
%End
60-
void setSql( const QString &sqlStatement );
61-
void lstFields_clicked( const QModelIndex &index );
62-
void lstFields_doubleClicked( const QModelIndex &index );
63-
void lstValues_doubleClicked( const QModelIndex &index );
64-
void btnLessEqual_clicked();
65-
void btnGreaterEqual_clicked();
66-
void btnNotEqual_clicked();
67-
void btnAnd_clicked();
68-
void btnNot_clicked();
69-
void btnOr_clicked();
7054

7155
void test();
7256
%Docstring
@@ -76,19 +60,6 @@ class QgsQueryBuilder : QDialog
7660
statement.
7761
%End
7862

79-
void btnGetAllValues_clicked();
80-
%Docstring
81-
Get all distinct values for the field. Values are inserted
82-
into the value list box
83-
%End
84-
85-
void btnSampleValues_clicked();
86-
%Docstring
87-
Get sample distinct values for the selected field. The sample size is
88-
limited to an arbitrary value (currently set to 25). The values
89-
are inserted into the values list box.
90-
%End
91-
9263
void setDatasourceDescription( const QString &uri );
9364

9465
};

python/gui/qgssearchquerybuilder.sip

-38
Original file line numberDiff line numberDiff line change
@@ -39,44 +39,6 @@ change search string shown in text field
3939
%End
4040

4141
public slots:
42-
void btnEqual_clicked();
43-
void on_btnOk_clicked();
44-
void btnLessThan_clicked();
45-
void btnGreaterThan_clicked();
46-
void btnLike_clicked();
47-
void btnILike_clicked();
48-
void btnPct_clicked();
49-
void btnIn_clicked();
50-
void btnNotIn_clicked();
51-
52-
void lstFields_doubleClicked( const QModelIndex &index );
53-
void lstValues_doubleClicked( const QModelIndex &index );
54-
void btnLessEqual_clicked();
55-
void btnGreaterEqual_clicked();
56-
void btnNotEqual_clicked();
57-
void btnAnd_clicked();
58-
void btnNot_clicked();
59-
void btnOr_clicked();
60-
void btnClear_clicked();
61-
62-
void btnTest_clicked();
63-
%Docstring
64-
Test the constructed search string to see if it's correct.
65-
The number of rows that would be returned is displayed in a message box.
66-
%End
67-
68-
void btnGetAllValues_clicked();
69-
%Docstring
70-
Get all distinct values for the field. Values are inserted
71-
into the value list box
72-
%End
73-
74-
void btnSampleValues_clicked();
75-
%Docstring
76-
Get sample distinct values for the selected field. The sample size is
77-
limited to an arbitrary value (currently set to 25). The values
78-
are inserted into the values list box.
79-
%End
8042

8143
void saveQuery();
8244
void loadQuery();

python/gui/raster/qgsrasterhistogramwidget.sip

-4
Original file line numberDiff line numberDiff line change
@@ -60,10 +60,6 @@ Apply a histoActionTriggered() event.
6060
void refreshHistogram();
6161
%Docstring
6262
slot executed when user wishes to refresh raster histogramwidget
63-
%End
64-
void mSaveAsImageButton_clicked();
65-
%Docstring
66-
This slot lets you save the histogram as an image to disk
6763
%End
6864

6965
virtual void apply();

python/gui/symbology/qgsgraduatedsymbolrendererwidget.sip

-2
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,6 @@ Toggle the link between classes boundaries
6060

6161
void rowsMoved();
6262
void modelDataChanged();
63-
void mSizeUnitWidget_changed();
64-
void methodComboBox_currentIndexChanged( int );
6563
void refreshRanges( bool reset = false );
6664

6765
protected:

python/gui/symbology/qgssmartgroupeditordialog.sip

+1-2
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,8 @@ function to create a new ConditionBox and update UI
103103
slot to remove the condition with id int
104104
%End
105105

106-
void buttonBox_accepted();
107-
108106
protected:
107+
109108
};
110109

111110
/************************************************************************

python/gui/symbology/qgsstylemanagerdialog.sip

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ open add color ramp dialog, return color ramp's name if the ramp has been added
3636
void exportItems();
3737
void importItems();
3838

39-
void tabItemType_currentChanged( int );
4039
void populateList();
4140
%Docstring
4241
adds symbols of some type to list
@@ -228,6 +227,7 @@ sets the text of the item with bold font
228227

229228

230229

230+
231231
};
232232

233233
/************************************************************************

0 commit comments

Comments
 (0)