Use .at(0) instead of .left(1), as it avoids string allocation

nyalldawson · nyalldawson · commit 7e9428f6ac1d · 2017-08-29T18:04:30.000+10:00
Thanks to Clazy
diff --git a/src/providers/wfs/qgswfsprovider.cpp b/src/providers/wfs/qgswfsprovider.cpp
@@ -1363,7 +1363,7 @@ bool QgsWFSProvider::readAttributesFromSchema( QDomDocument &schemaDoc,
       geometryAttribute = ref.mid( 4 ); // Strip gml: prefix
       QString propertyType( gmlRefProperty.cap( 1 ) );
       // Set the first character in upper case
-      propertyType = propertyType.left( 1 ).toUpper() + propertyType.mid( 1 );
+      propertyType = propertyType.at( 0 ).toUpper() + propertyType.mid( 1 );
       geomType = geomTypeFromPropertyType( geometryAttribute, propertyType );
     }
     else if ( !name.isEmpty() ) //todo: distinguish between numerical and non-numerical types

Original file line number	Diff line number	Diff line change
`@@ -1363,7 +1363,7 @@ bool QgsWFSProvider::readAttributesFromSchema( QDomDocument &schemaDoc,`
`1363`	`1363`	`geometryAttribute = ref.mid( 4 ); // Strip gml: prefix`
`1364`	`1364`	`QString propertyType( gmlRefProperty.cap( 1 ) );`
`1365`	`1365`	`// Set the first character in upper case`
`1366`		`- propertyType = propertyType.left( 1 ).toUpper() + propertyType.mid( 1 );`
	`1366`	`+ propertyType = propertyType.at( 0 ).toUpper() + propertyType.mid( 1 );`
`1367`	`1367`	`geomType = geomTypeFromPropertyType( geometryAttribute, propertyType );`
`1368`	`1368`	`}`
`1369`	`1369`	`else if ( !name.isEmpty() ) //todo: distinguish between numerical and non-numerical types`