Skip to content

Commit 7e9aeda

Browse files
committed
Some const-correctness for rules
1 parent 7123803 commit 7e9aeda

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

python/core/symbology/qgsrulebasedrenderer.sip.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -351,7 +351,7 @@ Create a rule from an XML definition
351351
:return: A new rule
352352
%End
353353

354-
QgsRuleBasedRenderer::RuleList &children();
354+
const QgsRuleBasedRenderer::RuleList &children();
355355
%Docstring
356356
Return all children rules of this rule
357357

src/core/symbology/qgsrulebasedrenderer.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -374,7 +374,7 @@ class CORE_EXPORT QgsRuleBasedRenderer : public QgsFeatureRenderer
374374
*
375375
* \returns A list of rules
376376
*/
377-
QgsRuleBasedRenderer::RuleList &children() { return mChildren; }
377+
const QgsRuleBasedRenderer::RuleList &children() { return mChildren; }
378378

379379
/**
380380
* Returns all children, grand-children, grand-grand-children, grand-gra... you get it

src/gui/symbology/qgsrulebasedrendererwidget.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -342,10 +342,10 @@ QList<QgsSymbol *> QgsRuleBasedRendererWidget::selectedSymbols()
342342
{
343343
QModelIndex parent = range.parent();
344344
QgsRuleBasedRenderer::Rule *parentRule = mModel->ruleForIndex( parent );
345-
QgsRuleBasedRenderer::RuleList &children = parentRule->children();
345+
const QgsRuleBasedRenderer::RuleList &children = parentRule->children();
346346
for ( int row = range.top(); row <= range.bottom(); row++ )
347347
{
348-
symbolList.append( children[row]->symbol() );
348+
symbolList.append( children.at( row )->symbol() );
349349
}
350350
}
351351

@@ -360,10 +360,10 @@ QgsRuleBasedRenderer::RuleList QgsRuleBasedRendererWidget::selectedRules()
360360
{
361361
QModelIndex parent = range.parent();
362362
QgsRuleBasedRenderer::Rule *parentRule = mModel->ruleForIndex( parent );
363-
QgsRuleBasedRenderer::RuleList &children = parentRule->children();
363+
const QgsRuleBasedRenderer::RuleList &children = parentRule->children();
364364
for ( int row = range.top(); row <= range.bottom(); row++ )
365365
{
366-
rl.append( children[row]->clone() );
366+
rl.append( children.at( row )->clone() );
367367
}
368368
}
369369
return rl;

0 commit comments

Comments
 (0)