Use FastInsert when adding features from processing

Author: nyalldawson

python/plugins/processing/algs/qgis/AddTableField.py

@@ -28,6 +28,7 @@
 from qgis.PyQt.QtCore import QVariant
 from qgis.core import (QgsField,
                        QgsFeature,
+                       QgsFeatureSink,
                        QgsApplication,
                        QgsProcessingUtils,
                        QgsProcessingParameterFeatureSource,
@@ -111,7 +112,7 @@ def processAlgorithm(self, parameters, context, feedback):
             attributes.append(None)
             output_feature.setAttributes(attributes)
 
-            sink.addFeature(output_feature)
+            sink.addFeature(output_feature, QgsFeatureSink.FastInsert)
             feedback.setProgress(int(current * total))
 
         return {self.OUTPUT_LAYER: dest_id}

python/plugins/processing/algs/qgis/Aspect.py

@@ -33,7 +33,8 @@
 from qgis.core import (QgsProcessingParameterRasterLayer,
                        QgsProcessingParameterNumber,
                        QgsProcessingParameterRasterOutput,
-                       QgsProcessingOutputRasterLayer)
+                       QgsProcessingOutputRasterLayer,
+                       QgsFeatureSink)
 from processing.algs.qgis.QgisAlgorithm import QgisAlgorithm
 from processing.core.parameters import ParameterRaster
 from processing.core.parameters import ParameterNumber

python/plugins/processing/algs/qgis/AutoincrementalField.py

@@ -28,6 +28,7 @@
 from qgis.PyQt.QtCore import QVariant
 from qgis.core import (QgsField,
                        QgsFeature,
+                       QgsFeatureSink,
                        QgsApplication,
                        QgsProcessingUtils,
                        QgsProcessingParameterFeatureSource,
@@ -84,7 +85,7 @@ def processAlgorithm(self, parameters, context, feedback):
             attributes.append(current)
             output_feature.setAttributes(attributes)
 
-            sink.addFeature(output_feature)
+            sink.addFeature(output_feature, QgsFeatureSink.FastInsert)
             feedback.setProgress(int(current * total))
 
         return {self.OUTPUT: dest_id}

python/plugins/processing/algs/qgis/BarPlot.py

@@ -30,6 +30,7 @@
 
 
 from qgis.core import (QgsApplication,
+                       QgsFeatureSink,
                        QgsProcessingUtils,
                        QgsProcessingParameterFeatureSource,
                        QgsProcessingParameterField,

python/plugins/processing/algs/qgis/BasicStatistics.py

@@ -32,6 +32,7 @@
 from qgis.PyQt.QtGui import QIcon
 
 from qgis.core import (QgsStatisticalSummary,
+                       QgsFeatureSink,
                        QgsStringStatisticalSummary,
                        QgsDateTimeStatisticalSummary,
                        QgsFeatureRequest,

python/plugins/processing/algs/qgis/Boundary.py

@@ -29,6 +29,7 @@
 
 from qgis.core import (QgsGeometry,
                        QgsWkbTypes,
+                       QgsFeatureSink,
                        QgsProcessingUtils,
                        QgsProcessingParameterDefinition,
                        QgsProcessingParameterFeatureSource,
@@ -101,7 +102,7 @@ def processAlgorithm(self, parameters, context, feedback):
 
                 output_feature.setGeometry(output_geometry)
 
-            sink.addFeature(output_feature)
+            sink.addFeature(output_feature, QgsFeatureSink.FastInsert)
             feedback.setProgress(int(current * total))
 
         return {self.OUTPUT_LAYER: dest_id}

python/plugins/processing/algs/qgis/BoundingBox.py

@@ -29,6 +29,7 @@
 
 from qgis.core import (QgsGeometry,
                        QgsWkbTypes,
+                       QgsFeatureSink,
                        QgsProcessingUtils,
                        QgsProcessingParameterFeatureSource,
                        QgsProcessingParameterFeatureSink,
@@ -93,7 +94,7 @@ def processAlgorithm(self, parameters, context, feedback):
 
                 output_feature.setGeometry(output_geometry)
 
-            sink.addFeature(output_feature)
+            sink.addFeature(output_feature, QgsFeatureSink.FastInsert)
             feedback.setProgress(int(current * total))
 
         return {self.OUTPUT_LAYER: dest_id}

python/plugins/processing/algs/qgis/BoxPlot.py

@@ -29,6 +29,7 @@
 import plotly.graph_objs as go
 
 from qgis.core import (QgsApplication,
+                       QgsFeatureSink,
                        QgsProcessingUtils)
 from processing.core.parameters import ParameterTable
 from processing.core.parameters import ParameterTableField

python/plugins/processing/algs/qgis/Buffer.py

@@ -60,7 +60,7 @@ def buffering(feedback, context, writer, distance, field, useField, layer, disso
         final_geometry = QgsGeometry.unaryUnion(buffered_geometries)
         outFeat.setGeometry(final_geometry)
         outFeat.setAttributes(attrs)
-        writer.addFeature(outFeat)
+        writer.addFeature(outFeat, QgsFeatureSink.FastInsert)
     else:
         # Without dissolve
         for inFeat in features:
@@ -74,7 +74,7 @@ def buffering(feedback, context, writer, distance, field, useField, layer, disso
             outGeom = inGeom.buffer(float(value), segments, endCapStyle, joinStyle, mitreLimit)
             outFeat.setGeometry(outGeom)
             outFeat.setAttributes(attrs)
-            writer.addFeature(outFeat)
+            writer.addFeature(outFeat, QgsFeatureSink.FastInsert)
             current += 1
             feedback.setProgress(int(current * total))
 

python/plugins/processing/algs/qgis/CheckValidity.py

@@ -34,6 +34,7 @@
                        QgsGeometry,
                        QgsFeature,
                        QgsField,
+                       QgsFeatureSink,
                        QgsWkbTypes,
                        QgsProcessingUtils,
                        QgsFields,
@@ -151,7 +152,7 @@ def doCheck(self, method, parameters, context, feedback):
                         errFeat.setGeometry(error_geom)
                         errFeat.setAttributes([error.what()])
                         if error_output_sink:
-                            error_output_sink.addFeature(errFeat)
+                            error_output_sink.addFeature(errFeat, QgsFeatureSink.FastInsert)
                         error_count += 1
 
                         reasons.append(error.what())
@@ -167,12 +168,12 @@ def doCheck(self, method, parameters, context, feedback):
 
             if valid:
                 if valid_output_sink:
-                    valid_output_sink.addFeature(outFeat)
+                    valid_output_sink.addFeature(outFeat, QgsFeatureSink.FastInsert)
                 valid_count += 1
 
             else:
                 if invalid_output_sink:
-                    invalid_output_sink.addFeature(outFeat)
+                    invalid_output_sink.addFeature(outFeat, QgsFeatureSink.FastInsert)
                 invalid_count += 1
 
             feedback.setProgress(int(current * total))