Please sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
QgsVectorFileWriter::createFeature(): remove useless and broken proce…
…ssing of feature id 891e665 changed the historical logic of always assigning the QGIS feature id as a OGR feature id before calling OGR_L_CreateFeature(). But it actually change it in a borken broken way by doing it only when the QGIS feature id was > INT_MAX, and then it assigned the result of the cast of the value to long (which is 32 bit on windows), resulting in a negative value. Just remove all that logic which is useless. This is the root cause for an issue of exporting a subset of a very large layer to XLSX/ODS reported in https://lists.osgeo.org/pipermail/gdal-dev/2022-January/055202.html
- Loading branch information
Showing with 0 additions and 14 deletions.