Skip to content
Permalink
Browse files
"Fix" failing spell check
  • Loading branch information
nyalldawson committed Apr 23, 2017
1 parent bfcf252 commit 82c66f8aa38e4e0e2d213b2040360410cafef30d
Showing with 8 additions and 8 deletions.
  1. +5 −5 src/app/qgisapp.cpp
  2. +2 −2 src/app/qgsmapsavedialog.cpp
  3. +1 −1 src/app/qgsmapsavedialog.h
@@ -5784,20 +5784,20 @@ void QgisApp::updateFilterLegend()
void QgisApp::saveMapAsImage()
{
QList< QgsMapDecoration * > decorations;
QString activeDecorations;
QString currentDecorations;
Q_FOREACH ( QgsDecorationItem *decoration, mDecorationItems )
{
if ( decoration->enabled() )
{
decorations << decoration;
if ( activeDecorations.isEmpty() )
activeDecorations = decoration->name().toLower();
if ( currentDecorations.isEmpty() )
currentDecorations = decoration->name().toLower();
else
activeDecorations += QString( ", %1" ).arg( decoration->name().toLower() );
currentDecorations += QString( ", %1" ).arg( decoration->name().toLower() );
}
}

QgsMapSaveDialog dlg( this, mMapCanvas, activeDecorations );
QgsMapSaveDialog dlg( this, mMapCanvas, currentDecorations );
if ( !dlg.exec() )
return;

@@ -29,7 +29,7 @@

Q_GUI_EXPORT extern int qt_defaultDpiX();

QgsMapSaveDialog::QgsMapSaveDialog( QWidget *parent, QgsMapCanvas *mapCanvas, const QString &activeDecorations )
QgsMapSaveDialog::QgsMapSaveDialog( QWidget *parent, QgsMapCanvas *mapCanvas, const QString &decorations )
: QDialog( parent )
{
setupUi( this );
@@ -48,7 +48,7 @@ QgsMapSaveDialog::QgsMapSaveDialog( QWidget *parent, QgsMapCanvas *mapCanvas, co
mScaleWidget->setMapCanvas( mapCanvas );
mScaleWidget->setShowCurrentScaleButton( true );

mDrawDecorations->setText( QString( "Draw active decorations: %1" ).arg( !activeDecorations.isEmpty() ? activeDecorations : tr( "none" ) ) );
mDrawDecorations->setText( QString( "Draw active decorations: %1" ).arg( !decorations.isEmpty() ? decorations : tr( "none" ) ) );

connect( mResolutionSpinBox, static_cast < void ( QSpinBox::* )( int ) > ( &QSpinBox::valueChanged ), this, &QgsMapSaveDialog::updateDpi );
connect( mExtentGroupBox, &QgsExtentGroupBox::extentChanged, this, &QgsMapSaveDialog::updateExtent );
@@ -39,7 +39,7 @@ class APP_EXPORT QgsMapSaveDialog: public QDialog, private Ui::QgsMapSaveDialog

/** Constructor for QgsMapSaveDialog
*/
QgsMapSaveDialog( QWidget *parent = nullptr, QgsMapCanvas *mapCanvas = nullptr, const QString &activeDecorations = QString() );
QgsMapSaveDialog( QWidget *parent = nullptr, QgsMapCanvas *mapCanvas = nullptr, const QString &decorations = QString() );

//! returns extent rectangle
QgsRectangle extent() const;

3 comments on commit 82c66f8

@nirvn

This comment has been minimized.

Copy link
Contributor

@nirvn nirvn replied Apr 24, 2017

@nyalldawson , @3nids , the proper fix would be to insure that the spell checker handlesCamelCasedWordsProperly :)

@3nids

This comment has been minimized.

Copy link
Member

@3nids 3nids replied Apr 24, 2017

I will have a look

@3nids

This comment has been minimized.

Copy link
Member

@3nids 3nids replied Apr 24, 2017

done in 68e0a62, with a bit of noise in commits, sorry.

Please sign in to comment.