Moved control images one per directory and updated render checker to …

…generate paths and filenames more cleanly. All tests pass for me.
qgis · Apr 13, 2012 · 83b1bf5 · 83b1bf5
1 parent 0180715
commit 83b1bf5
Show file tree

Hide file tree

Showing 25 changed files with 31 additions and 12 deletions.
diff --git a/tests/src/core/qgsrenderchecker.cpp b/tests/src/core/qgsrenderchecker.cpp
@@ -43,6 +43,13 @@ QString QgsRenderChecker::controlImagePath() const
   return myControlImageDir;
 }
 
+void QgsRenderChecker::setControlName(const QString theName)
+{
+  mControlName = theName;
+  mExpectedImageFile = controlImagePath() + theName + QDir::separator() +
+      theName + ".png";
+}
+
 bool QgsRenderChecker::runTest( QString theTestName,
                                 unsigned int theMismatchCount )
 {

diff --git a/tests/src/core/qgsrenderchecker.h b/tests/src/core/qgsrenderchecker.h
@@ -44,7 +44,11 @@ class QgsRenderChecker
   //only records time for actual render part
   int elapsedTime() { return mElapsedTime; };
   void setElapsedTimeTarget(int theTarget) { mElapsedTimeTarget = theTarget; };
-  void setExpectedImage (QString theImageFileName) { mExpectedImageFile = theImageFileName; };
+  /** Base directory name for the control image (with control image path
+    * suffixed) the path to the image will be constructed like this:
+    * controlImagePath + '/' + mControlName + '/' + mControlName + '.png'
+    */
+  void setControlName(const QString theName);
   void setRenderedImage (QString theImageFileName) { mRenderedImageFile = theImageFileName; };
   void setMapRenderer ( QgsMapRenderer *  thepMapRenderer) { mpMapRenderer = thepMapRenderer; };
   /**
@@ -73,6 +77,7 @@ class QgsRenderChecker
 private:
   QString mReport;
   QString mExpectedImageFile;
+  QString mControlName;
   QString mRenderedImageFile; 
   unsigned int mMismatchCount;
   unsigned int mMatchTarget;

diff --git a/tests/src/core/regression992.cpp b/tests/src/core/regression992.cpp
@@ -106,8 +106,7 @@ void Regression992::regression992()
   QVERIFY( mpRasterLayer->isValid() );
   mpMapRenderer->setExtent( mpRasterLayer->extent() );
   QgsRenderChecker myChecker;
-  myChecker.setExpectedImage( myChecker.controlImagePath() +
-                              "expected_rgbwcmyk01_YeGeo.jp2.png" );
+  myChecker.setControlName( "expected_rgbwcmyk01_YeGeo.jp2" );
   myChecker.setMapRenderer( mpMapRenderer );
   // allow up to 300 mismatched pixels
   bool myResultFlag = myChecker.runTest( "regression992", 300 );

diff --git a/tests/src/core/testqgsgeometry.cpp b/tests/src/core/testqgsgeometry.cpp
@@ -314,8 +314,7 @@ bool TestQgsGeometry::renderCheck( QString theTestName, QString theComment )
   QString myFileName = myTmpDir + theTestName + ".png";
   mImage.save( myFileName, "PNG" );
   QgsRenderChecker myChecker;
-  myChecker.setExpectedImage( myChecker.controlImagePath() +
-                              "expected_" + theTestName + ".png" );
+  myChecker.setControlName( "expected_" + theTestName );
   myChecker.setRenderedImage( myFileName );
   bool myResultFlag = myChecker.compareImages( theTestName );
   mReport += myChecker.report();

diff --git a/tests/src/core/testqgsmaprenderer.cpp b/tests/src/core/testqgsmaprenderer.cpp
@@ -193,8 +193,7 @@ void TestQgsMapRenderer::performanceTest()
 {
   mpMapRenderer->setExtent( mpPolysLayer->extent() );
   QgsRenderChecker myChecker;
-  myChecker.setExpectedImage(
-        myChecker.controlImagePath() + "expected_maprender.png" );
+  myChecker.setControlName( "expected_maprender" );
   myChecker.setMapRenderer( mpMapRenderer );
   bool myResultFlag = myChecker.runTest( "maprender" );
   mReport += myChecker.report();

diff --git a/tests/src/core/testqgsrasterlayer.cpp b/tests/src/core/testqgsrasterlayer.cpp
@@ -256,8 +256,7 @@ bool TestQgsRasterLayer::render( QString theTestType )
 {
   mReport += "<h2>" + theTestType + "</h2>\n";
   QgsRenderChecker myChecker;
-  myChecker.setExpectedImage( myChecker.controlImagePath()
-                              + "expected_" + theTestType + ".png" );
+  myChecker.setControlName( "expected_" + theTestType );
   myChecker.setMapRenderer( mpMapRenderer );
   bool myResultFlag = myChecker.runTest( theTestType );
   mReport += "\n\n\n" + myChecker.report();

diff --git a/tests/src/core/testqgsrenderers.cpp b/tests/src/core/testqgsrenderers.cpp
@@ -216,9 +216,7 @@ bool TestQgsRenderers::imageCheck( QString theTestType )
   //ensure the rendered output matches our control image
   mpMapRenderer->setExtent( mpPointsLayer->extent() );
   QgsRenderChecker myChecker;
-  QString myExpectedImage = myChecker.controlImagePath() +
-      "expected_" + theTestType + ".png";
-  myChecker.setExpectedImage( myExpectedImage );
+  myChecker.setControlName( "expected_" + theTestType );
   myChecker.setMapRenderer( mpMapRenderer );
   bool myResultFlag = myChecker.runTest( theTestType );
   mReport += myChecker.report();

diff --git a/...ta/control_images/expected_continuous.png → ...pected_continuous/expected_continuous.png b/...ta/control_images/expected_continuous.png → ...pected_continuous/expected_continuous.png
diff --git a/..._images/expected_geometry_bufferCheck.png → ...erCheck/expected_geometry_bufferCheck.png b/..._images/expected_geometry_bufferCheck.png → ...erCheck/expected_geometry_bufferCheck.png
diff --git a/...es/expected_geometry_differenceCheck1.png → ...k1/expected_geometry_differenceCheck1.png b/...es/expected_geometry_differenceCheck1.png → ...k1/expected_geometry_differenceCheck1.png
diff --git a/...es/expected_geometry_differenceCheck2.png → ...k2/expected_geometry_differenceCheck2.png b/...es/expected_geometry_differenceCheck2.png → ...k2/expected_geometry_differenceCheck2.png
diff --git a/.../expected_geometry_intersectionCheck1.png → .../expected_geometry_intersectionCheck1.png b/.../expected_geometry_intersectionCheck1.png → .../expected_geometry_intersectionCheck1.png
diff --git a/...ages/expected_geometry_simplifyCheck1.png → ...eck1/expected_geometry_simplifyCheck1.png b/...ages/expected_geometry_simplifyCheck1.png → ...eck1/expected_geometry_simplifyCheck1.png
diff --git a/..._images/expected_geometry_unionCheck1.png → ...nCheck1/expected_geometry_unionCheck1.png b/..._images/expected_geometry_unionCheck1.png → ...nCheck1/expected_geometry_unionCheck1.png
diff --git a/..._images/expected_geometry_unionCheck2.png → ...nCheck2/expected_geometry_unionCheck2.png b/..._images/expected_geometry_unionCheck2.png → ...nCheck2/expected_geometry_unionCheck2.png
diff --git a/...ata/control_images/expected_graduated.png → ...expected_graduated/expected_graduated.png b/...ata/control_images/expected_graduated.png → ...expected_graduated/expected_graduated.png
diff --git a/...a/control_images/expected_landsat_875.png → ...cted_landsat_875/expected_landsat_875.png b/...a/control_images/expected_landsat_875.png → ...cted_landsat_875/expected_landsat_875.png
diff --git a/...control_images/expected_landsat_basic.png → ..._landsat_basic/expected_landsat_basic.png b/...control_images/expected_landsat_basic.png → ..._landsat_basic/expected_landsat_basic.png
diff --git a/...ata/control_images/expected_maprender.png → ...expected_maprender/expected_maprender.png b/...ata/control_images/expected_maprender.png → ...expected_maprender/expected_maprender.png
diff --git a/...stdata/control_images/expected_raster.png → ...mages/expected_raster/expected_raster.png b/...stdata/control_images/expected_raster.png → ...mages/expected_raster/expected_raster.png
diff --git a/tests/testdata/control_images/expected_raster/expected_raster.png.aux.xml b/tests/testdata/control_images/expected_raster/expected_raster.png.aux.xml
@@ -0,0 +1,13 @@
+<PAMDataset>
+  <Metadata domain="IMAGE_STRUCTURE">
+    <MDI key="INTERLEAVE">PIXEL</MDI>
+  </Metadata>
+  <PAMRasterBand band="1">
+    <Metadata>
+      <MDI key="STATISTICS_MINIMUM">0</MDI>
+      <MDI key="STATISTICS_MAXIMUM">255</MDI>
+      <MDI key="STATISTICS_MEAN">127.2</MDI>
+      <MDI key="STATISTICS_STDDEV">81.364365664583</MDI>
+    </Metadata>
+  </PAMRasterBand>
+</PAMDataset>
diff --git a/...control_images/expected_raster_pseudo.png → ..._raster_pseudo/expected_raster_pseudo.png b/...control_images/expected_raster_pseudo.png → ..._raster_pseudo/expected_raster_pseudo.png
diff --git a/..._images/expected_rgbwcmyk01_YeGeo.jp2.png → ...Geo.jp2/expected_rgbwcmyk01_YeGeo.jp2.png b/..._images/expected_rgbwcmyk01_YeGeo.jp2.png → ...Geo.jp2/expected_rgbwcmyk01_YeGeo.jp2.png
diff --git a/...stdata/control_images/expected_single.png → ...mages/expected_single/expected_single.png b/...stdata/control_images/expected_single.png → ...mages/expected_single/expected_single.png
diff --git a/...a/control_images/expected_uniquevalue.png → ...cted_uniquevalue/expected_uniquevalue.png b/...a/control_images/expected_uniquevalue.png → ...cted_uniquevalue/expected_uniquevalue.png