-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Commit
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -589,11 +589,11 @@ QString QgsCategorizedSymbolRendererV2::filter( const QgsFields& fields ) | |
} | ||
else if ( defaultActive ) | ||
{ | ||
return QString( "(%1) NOT IN (%2)" ).arg( mAttrName, inactiveValues ); | ||
return QString( "(\"%1\") NOT IN (%2)" ).arg( mAttrName, inactiveValues ); | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
nyalldawson
Author
Collaborator
|
||
} | ||
else | ||
{ | ||
return QString( "(%1) IN (%2)" ).arg( mAttrName, activeValues ); | ||
return QString( "(\"%1\") IN (%2)" ).arg( mAttrName, activeValues ); | ||
} | ||
} | ||
|
||
|
1 comment
on commit 8435fee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nyalldawson @nirvn
Does this also fix Redmine #13972 Categorize symbols uses wrong field after table join?
@nyalldawson , you also need to insure that features with null values show up. The line should be:
return QString( "(\"%1\") NOT IN (%2) OR (\"%1\") IS NULL" ).arg( mAttrName, inactiveValues );
I've tried it locally, it works.