Optimise destructors (pt 1)

- Remove some non-base class empty destructors. These add no value
and it's better to let the compiler auto generate optimised versions
- use virtual ~Class = default instead of virtual ~Class {}

Author: nyalldawson

src/analysis/interpolation/HalfEdge.h

@@ -38,7 +38,7 @@ class ANALYSIS_EXPORT HalfEdge
     //! Default constructor. Values for mDual, mNext, mPoint are set to -10 which means that they are undefined
     HalfEdge();
     HalfEdge( int dual, int next, int point, bool mbreak, bool forced );
-    ~HalfEdge();
+
     //! Returns the number of the dual HalfEdge
     int getDual() const;
     //! Returns the number of the next HalfEdge
@@ -71,11 +71,6 @@ inline HalfEdge::HalfEdge( int dual, int next, int point, bool mbreak, bool forc
 
 }
 
-inline HalfEdge::~HalfEdge()
-{
-
-}
-
 inline int HalfEdge::getDual() const
 {
   return mDual;

src/analysis/interpolation/Point3D.h

@@ -35,7 +35,6 @@ class ANALYSIS_EXPORT Point3D
     //! Constructor with the x-, y- and z-coordinate as arguments
     Point3D( double x, double y, double z );
     Point3D( const Point3D& p );
-    ~Point3D();
     Point3D& operator=( const Point3D& p );
     bool operator==( const Point3D& p ) const;
     bool operator!=( const Point3D& p ) const;
@@ -76,11 +75,6 @@ inline Point3D::Point3D( const Point3D& p ): mX( p.mX ), mY( p.mY ), mZ( p.mZ )
 
 }
 
-inline Point3D::~Point3D()
-{
-
-}
-
 inline double Point3D::getX() const
 {
   return mX;

src/analysis/interpolation/TriangleInterpolator.h

@@ -25,7 +25,7 @@
 class ANALYSIS_EXPORT TriangleInterpolator
 {
   public:
-    virtual ~TriangleInterpolator() {}
+    virtual ~TriangleInterpolator() = default;
     //! Calculates the normal vector and assigns it to vec
     virtual bool calcNormVec( double x, double y, Vector3D* result ) = 0;
     //! Performs a linear interpolation in a triangle and assigns the x-,y- and z-coordinates to point

src/analysis/interpolation/Vector3D.h

@@ -43,7 +43,6 @@ class ANALYSIS_EXPORT Vector3D
     //! Copy constructor
     Vector3D( const Vector3D& v );
 
-    ~Vector3D();
     Vector3D& operator=( const Vector3D& v );
     bool operator==( const Vector3D& v ) const;
     bool operator!=( const Vector3D& v ) const;
@@ -83,11 +82,6 @@ inline Vector3D::Vector3D()
 
 }
 
-inline Vector3D::~Vector3D()
-{
-
-}
-
 //-------------------------------------------setter and getters-------------------------------
 
 inline double Vector3D::getX() const

src/analysis/interpolation/qgsidwinterpolator.cpp

@@ -29,11 +29,6 @@ QgsIDWInterpolator::QgsIDWInterpolator(): QgsInterpolator( QList<LayerData>() ),
 
 }
 
-QgsIDWInterpolator::~QgsIDWInterpolator()
-{
-
-}
-
 int QgsIDWInterpolator::interpolatePoint( double x, double y, double& result )
 {
   if ( !mDataIsCached )

src/analysis/interpolation/qgsidwinterpolator.h

@@ -27,7 +27,6 @@ class ANALYSIS_EXPORT QgsIDWInterpolator: public QgsInterpolator
 {
   public:
     QgsIDWInterpolator( const QList<LayerData>& layerData );
-    ~QgsIDWInterpolator();
 
     /** Calculates interpolation value for map coordinates x, y
        @param x x-coordinate (in map units)

src/analysis/network/qgsnetworkstrategy.h

@@ -39,7 +39,7 @@ class ANALYSIS_EXPORT QgsNetworkStrategy
      */
     QgsNetworkStrategy() {}
 
-    virtual ~QgsNetworkStrategy() {}
+    virtual ~QgsNetworkStrategy() = default;
 
     /**
      * Returns list of the source layer attributes needed for cost calculation.

src/analysis/raster/qgsalignraster.h

@@ -147,7 +147,7 @@ class ANALYSIS_EXPORT QgsAlignRaster
       //! @return false if the execution should be cancelled, true otherwise
       virtual bool progress( double complete ) = 0;
 
-      virtual ~ProgressHandler() {}
+      virtual ~ProgressHandler() = default;
     };
 
     //! Assign a progress handler instance. Does not take ownership. nullptr can be passed.

src/analysis/raster/qgsaspectfilter.cpp

@@ -23,11 +23,6 @@ QgsAspectFilter::QgsAspectFilter( const QString& inputFile, const QString& outpu
 
 }
 
-QgsAspectFilter::~QgsAspectFilter()
-{
-
-}
-
 float QgsAspectFilter::processNineCellWindow(
   float* x11, float* x21, float* x31,
   float* x12, float* x22, float* x32,

src/analysis/raster/qgsaspectfilter.h

@@ -26,7 +26,6 @@ class ANALYSIS_EXPORT QgsAspectFilter: public QgsDerivativeFilter
 {
   public:
     QgsAspectFilter( const QString& inputFile, const QString& outputFile, const QString& outputFormat );
-    ~QgsAspectFilter();
 
     /** Calculates output value from nine input values. The input values and the output value can be equal to the
       nodata value if not present or outside of the border. Must be implemented by subclasses*/