Skip to content

Commit 85a0db2

Browse files
committed
Fix build against recent sip/PyQt4:
qgsfiledownloader.sip:33:0: src/gui/qgsfiledownloader.h:94:5: error: overriding non-deleted function 'virtual QgsFileDownloader::~QgsFileDownloader()' RuntimeError: qgis._core cannot import type 'QList<QVariant>' from PyQt4.QtCore
1 parent cfdb025 commit 85a0db2

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

python/core/core.sip

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33

44
%Feature QT5_SUPPORT
55

6+
%Import QtCore/QtCoremod.sip
67
%Import QtXml/QtXmlmod.sip
78
%Import QtNetwork/QtNetworkmod.sip
89
%Import QtSql/QtSqlmod.sip

src/gui/qgsfiledownloader.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,10 @@ class GUI_EXPORT QgsFileDownloader : public QObject
9090
void onSslErrors( QNetworkReply *reply, const QList<QSslError> &errors );
9191
#endif
9292

93-
private:
93+
protected:
9494
~QgsFileDownloader();
95+
96+
private:
9597
/**
9698
* Abort current request and show an error if the instance has GUI
9799
* notifications enabled.

0 commit comments

Comments
 (0)