Skip to content
Permalink
Browse files

Fix build against recent sip/PyQt4:

qgsfiledownloader.sip:33:0:
src/gui/qgsfiledownloader.h:94:5: error: overriding non-deleted function 'virtual QgsFileDownloader::~QgsFileDownloader()'

RuntimeError: qgis._core cannot import type 'QList<QVariant>' from PyQt4.QtCore
  • Loading branch information
manisandro committed Mar 1, 2017
1 parent cfdb025 commit 85a0db24f32351f6096cd8282f03ad5c2f4e6ef5
Showing with 4 additions and 1 deletion.
  1. +1 −0 python/core/core.sip
  2. +3 −1 src/gui/qgsfiledownloader.h
@@ -3,6 +3,7 @@

%Feature QT5_SUPPORT

%Import QtCore/QtCoremod.sip
%Import QtXml/QtXmlmod.sip
%Import QtNetwork/QtNetworkmod.sip
%Import QtSql/QtSqlmod.sip
@@ -90,8 +90,10 @@ class GUI_EXPORT QgsFileDownloader : public QObject
void onSslErrors( QNetworkReply *reply, const QList<QSslError> &errors );
#endif

private:
protected:
~QgsFileDownloader();

private:
/**
* Abort current request and show an error if the instance has GUI
* notifications enabled.

1 comment on commit 85a0db2

@Scimmia22

This comment has been minimized.

Copy link
Contributor

@Scimmia22 Scimmia22 commented on 85a0db2 Mar 4, 2017

I'm still getting the RuntimeError with sip 4.19.1 and pyqt4 4.12, even after this commit.

[ 91%] Generating ui_dialogAbout.py
Traceback (most recent call last):
  File "../../../../../scripts/pyuic-wrapper.py", line 26, in <module>
    import qgis.PyQt.uic.pyuic
  File "/home/dnewgard/PKGBUILDs/qgis/src/QGIS/build/output/python/qgis/__init__.py", line 27, in <m
odule>
    from qgis.core import QgsFeature, QgsGeometry
  File "/home/dnewgard/PKGBUILDs/qgis/src/QGIS/build/output/python/qgis/core/__init__.py", line 30,
in <module>
    from qgis._core import *
RuntimeError: qgis._core cannot import type 'QList<QVariant>' from PyQt4.QtCore
make[2]: *** [python/plugins/GdalTools/tools/CMakeFiles/zzz-GdalTools-2-depend.dir/build.make:118: p
ython/plugins/GdalTools/tools/ui_dialogAbout.py] Error 1
make[1]: *** [CMakeFiles/Makefile2:4667: python/plugins/GdalTools/tools/CMakeFiles/zzz-GdalTools-2-d
epend.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
Please sign in to comment.
You can’t perform that action at this time.