Skip to content
Permalink
Browse files
QgsFeatureSource/Sink can be stored in QVariant
  • Loading branch information
nyalldawson committed May 25, 2017
1 parent 4647662 commit 85d463052a668f526e2844ac57a954722defab99
Showing with 3 additions and 0 deletions.
  1. +1 −0 src/core/qgsfeaturesink.h
  2. +2 −0 src/core/qgsfeaturesource.h
@@ -94,5 +94,6 @@ class CORE_EXPORT QgsProxyFeatureSink : public QgsFeatureSink
QgsFeatureSink *mSink;
};

Q_DECLARE_METATYPE( QgsFeatureSink * )

#endif // QGSFEATURESINK_H
2 src/core/qgsfeaturesource.h 100644 → 100755
@@ -81,4 +81,6 @@ class CORE_EXPORT QgsFeatureSource

};

Q_DECLARE_METATYPE( QgsFeatureSource * )

#endif // QGSFEATURESOURCE_H

5 comments on commit 85d4630

@3nids

This comment has been minimized.

Copy link
Member

@3nids 3nids replied May 29, 2017

@nyalldawson I am getting a crash when opening a 2.x project on master
here is the trace
image
does it speak to you?

@3nids

This comment has been minimized.

Copy link
Member

@3nids 3nids replied May 29, 2017

another one with a master project + shapefile
image

am I the only one?

@nyalldawson

This comment has been minimized.

Copy link
Collaborator Author

@nyalldawson nyalldawson replied May 29, 2017

@3nids is it related to this commit? does reverting it fix this?

@3nids

This comment has been minimized.

Copy link
Member

@3nids 3nids replied May 29, 2017

I did not investigate much. I just saw in the members that there a feature sink, and I wondered if it could be related. I'll try to dig a bit more.

@3nids

This comment has been minimized.

Copy link
Member

@3nids 3nids replied May 29, 2017

sorry for the noise, cleaned and issue seems gone

Please sign in to comment.