Skip to content

Commit

Permalink
Fix error in Geometry by Expression
Browse files Browse the repository at this point in the history
We can't depend on preparing the expression, as we may not have
enough context to do this during the algorithm preparation step
  • Loading branch information
nyalldawson committed Nov 23, 2017
1 parent 59d55fc commit 8775aff
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions python/plugins/processing/algs/qgis/GeometryByExpression.py
Expand Up @@ -94,11 +94,7 @@ def prepareAlgorithm(self, parameters, context, feedback):
return False

self.expression_context = self.createExpressionContext(parameters, context)

if not self.expression.prepare(self.expression_context):
feedback.reportErro(
self.tr('Evaluation error: {0}').format(self.expression.evalErrorString()))
return False
self.expression.prepare(self.expression_context)

return True

Expand Down

0 comments on commit 8775aff

Please sign in to comment.