Skip to content

Commit

Permalink
Remove redundant overridden default destructor implementations
Browse files Browse the repository at this point in the history
  • Loading branch information
nyalldawson committed Dec 15, 2017
1 parent 4da1ce8 commit 8802482
Show file tree
Hide file tree
Showing 36 changed files with 3 additions and 63 deletions.
2 changes: 0 additions & 2 deletions python/analysis/network/qgsgraphdirector.sip
Expand Up @@ -32,8 +32,6 @@ using "builder" design patter.
%End
public:

~QgsGraphDirector();

virtual void makeGraph( QgsGraphBuilderInterface *builder,
const QVector< QgsPointXY > &additionalPoints,
QVector< QgsPointXY > &snappedPoints /Out/,
Expand Down
2 changes: 0 additions & 2 deletions python/analysis/network/qgsvectorlayerdirector.sip
Expand Up @@ -48,8 +48,6 @@ Default constructor
attribute value is not set or does not equal to the given values
%End

~QgsVectorLayerDirector();

virtual void makeGraph( QgsGraphBuilderInterface *builder,
const QVector< QgsPointXY > &additionalPoints,
QVector< QgsPointXY> &snappedPoints /Out/,
Expand Down
2 changes: 1 addition & 1 deletion python/analysis/raster/qgsderivativefilter.sip
Expand Up @@ -20,7 +20,7 @@ Adds the ability to calculate derivatives in x- and y-directions. Needs to be su
%End
public:
QgsDerivativeFilter( const QString &inputFile, const QString &outputFile, const QString &outputFormat );
~QgsDerivativeFilter();

virtual float processNineCellWindow( float *x11, float *x21, float *x31,
float *x12, float *x22, float *x32,
float *x13, float *x23, float *x33 ) = 0;
Expand Down
1 change: 0 additions & 1 deletion python/analysis/raster/qgsruggednessfilter.sip
Expand Up @@ -21,7 +21,6 @@ Algorithm from Riley et al. 1999: A terrain ruggedness index that quantifies top
%End
public:
QgsRuggednessFilter( const QString &inputFile, const QString &outputFile, const QString &outputFormat );
~QgsRuggednessFilter();

protected:

Expand Down
1 change: 0 additions & 1 deletion python/analysis/raster/qgsslopefilter.sip
Expand Up @@ -20,7 +20,6 @@ Calculates slope values in a window of 3x3 cells based on first order derivative
%End
public:
QgsSlopeFilter( const QString &inputFile, const QString &outputFile, const QString &outputFormat );
~QgsSlopeFilter();

virtual float processNineCellWindow( float *x11, float *x21, float *x31,
float *x12, float *x22, float *x32,
Expand Down
1 change: 0 additions & 1 deletion python/analysis/raster/qgstotalcurvaturefilter.sip
Expand Up @@ -20,7 +20,6 @@ Calculates total curvature as described by Wilson, Gallant (2000): terrain analy
%End
public:
QgsTotalCurvatureFilter( const QString &inputFile, const QString &outputFile, const QString &outputFormat );
~QgsTotalCurvatureFilter();

protected:

Expand Down
2 changes: 0 additions & 2 deletions python/core/annotations/qgshtmlannotation.sip
Expand Up @@ -30,8 +30,6 @@ An annotation item that embeds HTML content.
Constructor for QgsHtmlAnnotation.
%End

~QgsHtmlAnnotation();

virtual QgsHtmlAnnotation *clone() const /Factory/;


Expand Down
1 change: 0 additions & 1 deletion python/core/composer/qgscomposerobject.sip
Expand Up @@ -92,7 +92,6 @@ Returns the composer object property definitions.
Constructor
:param composition: parent composition
%End
~QgsComposerObject();

const QgsComposition *composition() const;
%Docstring
Expand Down
2 changes: 0 additions & 2 deletions python/core/layout/qgslayoutserializableobject.sip
Expand Up @@ -23,8 +23,6 @@ An interface for layout objects which can be stored and read from DOM elements.
%End
public:

~QgsLayoutSerializableObject();

virtual QString stringType() const = 0;
%Docstring
Return the object type as a string.
Expand Down
2 changes: 0 additions & 2 deletions python/core/symbology/qgsrendererregistry.sip
Expand Up @@ -114,8 +114,6 @@ Convenience metadata class that uses static functions to create renderer and its



~QgsRendererMetadata();

virtual QgsFeatureRenderer *createRenderer( QDomElement &elem, const QgsReadWriteContext &context ) /Factory/;
virtual QgsRendererWidget *createRendererWidget( QgsVectorLayer *layer, QgsStyle *style, QgsFeatureRenderer *renderer ) /Factory/;
virtual QgsFeatureRenderer *createRendererFromSld( QDomElement &elem, QgsWkbTypes::GeometryType geomType ) /Factory/;
Expand Down
2 changes: 0 additions & 2 deletions python/gui/layout/qgslayoutcustomdrophandler.sip
Expand Up @@ -27,8 +27,6 @@ Abstract base class that may be implemented to handle new types of data to be dr
Constructor for QgsLayoutCustomDropHandler.
%End

~QgsLayoutCustomDropHandler();

virtual bool handleFileDrop( QgsLayoutDesignerInterface *iface, const QString &file );
%Docstring
Called when the specified ``file`` has been dropped onto a QGIS layout. If true
Expand Down
2 changes: 0 additions & 2 deletions python/gui/layout/qgslayoutdesignerinterface.sip
Expand Up @@ -31,8 +31,6 @@ open layout designer dialogs.
Constructor for QgsLayoutDesignerInterface.
%End

~QgsLayoutDesignerInterface();

virtual QgsLayout *layout() = 0;
%Docstring
Returns the layout displayed in the designer.
Expand Down
5 changes: 0 additions & 5 deletions python/gui/qgsabstractdatasourcewidget.sip
Expand Up @@ -27,11 +27,6 @@ and add layers.
%End
public:

~QgsAbstractDataSourceWidget();
%Docstring
Destructor
%End

void setMapCanvas( const QgsMapCanvas *mapCanvas );
%Docstring
Store a pointer to the map canvas to retrieve extent and CRS
Expand Down
2 changes: 0 additions & 2 deletions python/gui/qgscomposerinterface.sip
Expand Up @@ -31,8 +31,6 @@ open composer dialogs.
Constructor for QgsComposerInterface.
%End

~QgsComposerInterface();

virtual QgsComposerView *view() = 0;
%Docstring
Returns the composer's QgsComposerView editor widget.
Expand Down
1 change: 0 additions & 1 deletion python/gui/qgscustomdrophandler.sip
Expand Up @@ -39,7 +39,6 @@ quickly and defer any intensive or slow processing.
#include "qgscustomdrophandler.h"
%End
public:
~QgsCustomDropHandler();

virtual QString customUriProviderKey() const;
%Docstring
Expand Down
2 changes: 0 additions & 2 deletions src/3d/chunks/qgschunkloader_p.h
Expand Up @@ -44,8 +44,6 @@ class QgsChunkLoader : public QgsChunkQueueJob
{
}

~QgsChunkLoader() override = default;

/**
* Run in main thread to use loaded data.
* Returns entity attached to the given parent entity in disabled state
Expand Down
1 change: 0 additions & 1 deletion src/3d/qgsvectorlayer3drenderer.h
Expand Up @@ -58,7 +58,6 @@ class _3D_EXPORT QgsVectorLayer3DRenderer : public QgsAbstract3DRenderer
public:
//! Takes ownership of the symbol object
explicit QgsVectorLayer3DRenderer( QgsAbstract3DSymbol *s SIP_TRANSFER = nullptr );
~QgsVectorLayer3DRenderer() override = default;

//! Sets vector layer associated with the renderer
void setLayer( QgsVectorLayer *layer );
Expand Down
1 change: 0 additions & 1 deletion src/3d/terrain/qgsdemterraintilegeometry_p.h
Expand Up @@ -56,7 +56,6 @@ class DemTerrainTileGeometry : public Qt3DRender::QGeometry
* heightMap is array of float values with one height value for each vertex
*/
explicit DemTerrainTileGeometry( int resolution, float skirtHeight, const QByteArray &heightMap, QNode *parent = nullptr );
~DemTerrainTileGeometry() override = default;

private:
void init();
Expand Down
2 changes: 0 additions & 2 deletions src/analysis/network/qgsgraphdirector.h
Expand Up @@ -56,8 +56,6 @@ class ANALYSIS_EXPORT QgsGraphDirector : public QObject

public:

~QgsGraphDirector() override = default;

/**
* Make a graph using QgsGraphBuilder
*
Expand Down
2 changes: 0 additions & 2 deletions src/analysis/network/qgsvectorlayerdirector.h
Expand Up @@ -68,8 +68,6 @@ class ANALYSIS_EXPORT QgsVectorLayerDirector : public QgsGraphDirector
const Direction defaultDirection
);

~QgsVectorLayerDirector() override = default;

/*
* MANDATORY DIRECTOR PROPERTY DECLARATION
*/
Expand Down
2 changes: 1 addition & 1 deletion src/analysis/raster/qgsderivativefilter.h
Expand Up @@ -28,7 +28,7 @@ class ANALYSIS_EXPORT QgsDerivativeFilter : public QgsNineCellFilter
{
public:
QgsDerivativeFilter( const QString &inputFile, const QString &outputFile, const QString &outputFormat );
~QgsDerivativeFilter() override = default;

//to be implemented by subclasses
float processNineCellWindow( float *x11, float *x21, float *x31,
float *x12, float *x22, float *x32,
Expand Down
1 change: 0 additions & 1 deletion src/analysis/raster/qgsruggednessfilter.h
Expand Up @@ -29,7 +29,6 @@ class ANALYSIS_EXPORT QgsRuggednessFilter: public QgsNineCellFilter
{
public:
QgsRuggednessFilter( const QString &inputFile, const QString &outputFile, const QString &outputFormat );
~QgsRuggednessFilter() override = default;

protected:

Expand Down
1 change: 0 additions & 1 deletion src/analysis/raster/qgsslopefilter.h
Expand Up @@ -28,7 +28,6 @@ class ANALYSIS_EXPORT QgsSlopeFilter: public QgsDerivativeFilter
{
public:
QgsSlopeFilter( const QString &inputFile, const QString &outputFile, const QString &outputFormat );
~QgsSlopeFilter() override = default;

/**
* Calculates output value from nine input values. The input values and the output value can be equal to the
Expand Down
1 change: 0 additions & 1 deletion src/analysis/raster/qgstotalcurvaturefilter.h
Expand Up @@ -28,7 +28,6 @@ class ANALYSIS_EXPORT QgsTotalCurvatureFilter: public QgsNineCellFilter
{
public:
QgsTotalCurvatureFilter( const QString &inputFile, const QString &outputFile, const QString &outputFormat );
~QgsTotalCurvatureFilter() override = default;

protected:

Expand Down
2 changes: 0 additions & 2 deletions src/core/annotations/qgshtmlannotation.h
Expand Up @@ -42,8 +42,6 @@ class CORE_EXPORT QgsHtmlAnnotation: public QgsAnnotation
*/
QgsHtmlAnnotation( QObject *parent SIP_TRANSFERTHIS = nullptr );

~QgsHtmlAnnotation() override = default;

QgsHtmlAnnotation *clone() const override SIP_FACTORY;

QSizeF minimumFrameSize() const override;
Expand Down
1 change: 0 additions & 1 deletion src/core/composer/qgscomposerobject.h
Expand Up @@ -116,7 +116,6 @@ class CORE_EXPORT QgsComposerObject: public QObject, public QgsExpressionContext
* \param composition parent composition
*/
QgsComposerObject( QgsComposition *composition );
~QgsComposerObject() override = default;

/**
* Returns the composition the item is attached to.
Expand Down
2 changes: 0 additions & 2 deletions src/core/layout/qgslayoutserializableobject.h
Expand Up @@ -36,8 +36,6 @@ class CORE_EXPORT QgsLayoutSerializableObject : public QgsLayoutUndoObjectInterf
{
public:

~QgsLayoutSerializableObject() override = default;

/**
* Return the object type as a string.
*
Expand Down
5 changes: 0 additions & 5 deletions src/core/qgsauxiliarystorage.h
Expand Up @@ -72,11 +72,6 @@ class CORE_EXPORT QgsAuxiliaryLayer : public QgsVectorLayer
*/
QgsAuxiliaryLayer( const QString &pkField, const QString &filename, const QString &table, QgsVectorLayer *vlayer );

/**
* Destructor
*/
~QgsAuxiliaryLayer() override = default;

/**
* Copy constructor deactivated
*/
Expand Down
2 changes: 0 additions & 2 deletions src/core/symbology/qgsrendererregistry.h
Expand Up @@ -149,8 +149,6 @@ class CORE_EXPORT QgsRendererMetadata : public QgsRendererAbstractMetadata
, mLayerTypes( layerTypes )
{}

~QgsRendererMetadata() override = default;

QgsFeatureRenderer *createRenderer( QDomElement &elem, const QgsReadWriteContext &context ) override SIP_FACTORY
{ return mCreateFunc ? mCreateFunc( elem, context ) : nullptr; }
QgsRendererWidget *createRendererWidget( QgsVectorLayer *layer, QgsStyle *style, QgsFeatureRenderer *renderer ) override SIP_FACTORY
Expand Down
2 changes: 0 additions & 2 deletions src/gui/layout/qgslayoutcustomdrophandler.h
Expand Up @@ -39,8 +39,6 @@ class GUI_EXPORT QgsLayoutCustomDropHandler : public QObject
*/
QgsLayoutCustomDropHandler( QObject *parent SIP_TRANSFERTHIS = nullptr );

~QgsLayoutCustomDropHandler() override = default;

/**
* Called when the specified \a file has been dropped onto a QGIS layout. If true
* is returned, then the handler has accepted this file and it should not
Expand Down
2 changes: 0 additions & 2 deletions src/gui/layout/qgslayoutdesignerinterface.h
Expand Up @@ -48,8 +48,6 @@ class GUI_EXPORT QgsLayoutDesignerInterface: public QObject
: QObject( parent )
{}

~QgsLayoutDesignerInterface() override = default;

/**
* Returns the layout displayed in the designer.
* \see view()
Expand Down
3 changes: 0 additions & 3 deletions src/gui/qgsabstractdatasourcewidget.h
Expand Up @@ -44,9 +44,6 @@ class GUI_EXPORT QgsAbstractDataSourceWidget : public QDialog

public:

//! Destructor
~QgsAbstractDataSourceWidget() override = default;

/**
* Store a pointer to the map canvas to retrieve extent and CRS
* Used to select an appropriate CRS and possibly to retrieve data only in the current extent
Expand Down
2 changes: 0 additions & 2 deletions src/gui/qgscomposerinterface.h
Expand Up @@ -47,8 +47,6 @@ class GUI_EXPORT QgsComposerInterface: public QObject
: QObject( parent )
{}

~QgsComposerInterface() override = default;

/**
* Returns the composer's QgsComposerView editor widget.
*/
Expand Down
1 change: 0 additions & 1 deletion src/gui/qgscustomdrophandler.h
Expand Up @@ -49,7 +49,6 @@ class GUI_EXPORT QgsCustomDropHandler : public QObject
Q_OBJECT

public:
~QgsCustomDropHandler() override = default;

/**
* Type of custom URI recognized by the handler. This must match
Expand Down
2 changes: 1 addition & 1 deletion src/providers/wms/qgswmsprovider.h
Expand Up @@ -86,7 +86,7 @@ class QgsCachedImageFetcher: public QgsImageFetcher
Q_OBJECT
public:
explicit QgsCachedImageFetcher( const QImage &img );
~QgsCachedImageFetcher() override = default;

void start() override;
private:
const QImage _img; // copy is intentional
Expand Down
1 change: 0 additions & 1 deletion tests/src/gui/testqgslayoutview.cpp
Expand Up @@ -242,7 +242,6 @@ class TestItem : public QgsLayoutItem
public:

TestItem( QgsLayout *layout ) : QgsLayoutItem( layout ) {}
~TestItem() override = default;