Skip to content

Commit 88fafe4

Browse files
author
rblazek
committed
fixed #2003, crash if topo is not available
git-svn-id: http://svn.osgeo.org/qgis/trunk@12782 c8812cc2-4d05-0410-92ff-de0c093fc19c
1 parent 486cf59 commit 88fafe4

File tree

2 files changed

+25
-11
lines changed

2 files changed

+25
-11
lines changed

src/plugins/grass/qgsgrassplugin.cpp

+15-1
Original file line numberDiff line numberDiff line change
@@ -303,11 +303,25 @@ void QgsGrassPlugin::addVector()
303303
/* Open vector */
304304
try
305305
{
306-
Vect_set_open_level( 2 );
306+
//Vect_set_open_level( 2 );
307307
struct Map_info map;
308308
int level = Vect_open_old_head( &map, sel->map.toUtf8().data(),
309309
sel->mapset.toUtf8().data() );
310310

311+
if ( level == 1 )
312+
{
313+
QgsDebugMsg( "Cannot open vector on level 2" );
314+
QMessageBox::warning( 0, tr( "Warning" ), tr( "Cannot open vector ") + sel->map + tr(" in mapset ") + sel->mapset + tr (" on level 2 (topology not available, try to rebuild tobopoly using v.build module)." ) );
315+
Vect_close( &map );
316+
return;
317+
}
318+
else if ( level < 1 )
319+
{
320+
QgsDebugMsg( "Cannot open vector" );
321+
QMessageBox::warning( 0, tr( "Warning" ), tr( "Cannot open vector ") + sel->map + tr(" in mapset ") + sel->mapset );
322+
return;
323+
}
324+
311325
if ( level >= 2 )
312326
{
313327
// Count layers

src/plugins/grass/qgsgrassselect.cpp

+10-10
Original file line numberDiff line numberDiff line change
@@ -400,17 +400,10 @@ QStringList QgsGrassSelect::vectorLayers( QString gisdbase,
400400

401401
/* Open vector */
402402
QgsGrass::resetError();
403-
Vect_set_open_level( 2 );
403+
//Vect_set_open_level( 2 );
404404
struct Map_info map;
405405
int level = -1;
406406

407-
// Mechanism to recover from fatal errors in GRASS
408-
// Since fatal error routine in GRASS >= 6.3 terminates the process,
409-
// we use setjmp() to set recovery place in case of a fatal error.
410-
// Call to setjmp() returns 0 first time. In case of fatal error,
411-
// our error routine uses longjmp() to come back to this context,
412-
// this time setjmp() will return non-zero value and we can continue...
413-
414407
try
415408
{
416409
level = Vect_open_old_head( &map, ( char * ) mapName.toUtf8().data(), ( char * ) mapset.toUtf8().data() );
@@ -422,10 +415,17 @@ QStringList QgsGrassSelect::vectorLayers( QString gisdbase,
422415
return list;
423416
}
424417

425-
if ( level < 2 )
418+
if ( level == 1 )
426419
{
427420
QgsDebugMsg( "Cannot open vector on level 2" );
428-
QMessageBox::warning( 0, tr( "Warning" ), tr( "Cannot open vector on level 2 (topology not available)." ) );
421+
QMessageBox::warning( 0, tr( "Warning" ), tr( "Cannot open vector ") + mapName + tr(" in mapset ") + mapset + tr (" on level 2 (topology not available, try to rebuild tobopoly using v.build module)." ) );
422+
Vect_close( &map );
423+
return list;
424+
}
425+
else if ( level < 1 )
426+
{
427+
QgsDebugMsg( "Cannot open vector" );
428+
QMessageBox::warning( 0, tr( "Warning" ), tr( "Cannot open vector ") + mapName + tr(" in mapset ") + mapset );
429429
return list;
430430
}
431431

0 commit comments

Comments
 (0)