Skip to content

Commit 895b955

Browse files
authored
Merge pull request #3166 from nirvn/fix_processing_refactor_fields
[processing] fix missing quotes to field name in refactor fields
2 parents 37598bd + 14342ce commit 895b955

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

python/plugins/processing/algs/qgis/ui/FieldsMappingPanel.py

+5-2
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ def newField(self, field=None):
220220
'type': field.type(),
221221
'length': field.length(),
222222
'precision': field.precision(),
223-
'expression': field.name()}
223+
'expression': QgsExpression.quotedColumnRef(field.name())}
224224

225225
def loadLayerFields(self, layer):
226226
self.beginResetModel()
@@ -292,7 +292,10 @@ def setModelData(self, editor, model, index):
292292

293293
elif fieldType == QgsExpression:
294294
(value, isExpression, isValid) = editor.currentField()
295-
model.setData(index, value)
295+
if isExpression is True:
296+
model.setData(index, value)
297+
else:
298+
model.setData(index, QgsExpression.quotedColumnRef(value))
296299

297300
else:
298301
QStyledItemDelegate.setModelData(self, editor, model, index)

0 commit comments

Comments
 (0)